Fix failing envtest (#4260)

Since the introduction of k8s 1.34 as the envtest latest,
some of our tests were failing due to missing elements of
the statefulset spec (mostly). This PR fixes those tests
by adding those elements.

Issues: [PGO-2648]

Author: benjaminjb

internal/controller/postgrescluster/apply_test.go

@@ -151,6 +151,7 @@ func TestServerSideApply(t *testing.T) {
 				MatchLabels: map[string]string{"select": name},
 			}
 			sts.Spec.Template.Labels = map[string]string{"select": name}
+			sts.Spec.Template.Spec.Containers = []corev1.Container{{Name: "test", Image: "test"}}
 			return &sts
 		}
 

internal/controller/postgrescluster/controller_ref_manager_test.go

@@ -46,6 +46,9 @@ func TestManageControllerRefs(t *testing.T) {
 				ObjectMeta: metav1.ObjectMeta{
 					Labels: map[string]string{"label1": "val1"},
 				},
+				Spec: corev1.PodSpec{
+					Containers: []corev1.Container{{Name: "test", Image: "test"}},
+				},
 			},
 		},
 	}

internal/controller/postgrescluster/pgbackrest_test.go

@@ -1707,7 +1707,9 @@ func TestGetPGBackRestResources(t *testing.T) {
 						ObjectMeta: metav1.ObjectMeta{
 							Labels: naming.PGBackRestDedicatedLabels(clusterName),
 						},
-						Spec: corev1.PodSpec{},
+						Spec: corev1.PodSpec{
+							Containers: []corev1.Container{{Name: "test", Image: "test"}},
+						},
 					},
 				},
 			},
@@ -1745,7 +1747,9 @@ func TestGetPGBackRestResources(t *testing.T) {
 						ObjectMeta: metav1.ObjectMeta{
 							Labels: naming.PGBackRestDedicatedLabels(clusterName),
 						},
-						Spec: corev1.PodSpec{},
+						Spec: corev1.PodSpec{
+							Containers: []corev1.Container{{Name: "test", Image: "test"}},
+						},
 					},
 				},
 			},
@@ -1781,7 +1785,9 @@ func TestGetPGBackRestResources(t *testing.T) {
 						ObjectMeta: metav1.ObjectMeta{
 							Labels: naming.PGBackRestDedicatedLabels(clusterName),
 						},
-						Spec: corev1.PodSpec{},
+						Spec: corev1.PodSpec{
+							Containers: []corev1.Container{{Name: "test", Image: "test"}},
+						},
 					},
 				},
 			},

internal/controller/standalone_pgadmin/statefulset_test.go

@@ -37,6 +37,7 @@ func TestReconcilePGAdminStatefulSet(t *testing.T) {
 	pgadmin := new(v1beta1.PGAdmin)
 	pgadmin.Name = "test-standalone-pgadmin"
 	pgadmin.Namespace = ns.Name
+	pgadmin.Spec.Image = initialize.String("test")
 	require.UnmarshalInto(t, &pgadmin.Spec, `{
 		dataVolumeClaimSpec: {
 			accessModes: [ReadWriteOnce],
@@ -113,6 +114,7 @@ terminationGracePeriodSeconds: 30
 		// add pod level customizations
 		custompgadmin.Name = "custom-pgadmin"
 		custompgadmin.Namespace = ns.Name
+		custompgadmin.Spec.Image = initialize.String("test")
 		require.UnmarshalInto(t, &custompgadmin.Spec, `{
 			dataVolumeClaimSpec: {
 				accessModes: [ReadWriteOnce],
@@ -231,7 +233,7 @@ tolerations:
 		// add pod level customizations
 		custompgadmin.Name = "custom-volumes"
 		custompgadmin.Namespace = ns.Name
-
+		custompgadmin.Spec.Image = initialize.String("test")
 		require.UnmarshalInto(t, &custompgadmin.Spec, `{
 			dataVolumeClaimSpec: {
 				accessModes: [ReadWriteOnce],