Cleanup - removed artifacts of c++03 atomics implementation

Author: AlexPeshkoff

configure.ac

@@ -685,11 +685,6 @@ AC_ARG_WITH(system-boost,
   [SYSTEM_BOOST=Y])
 AC_SUBST(SYSTEM_BOOST)
 
-ATOMICLIB=atomic
-AC_ARG_WITH(atomiclib,
-  [  --with-atomiclib        build with explicitly specified atomic support library],
-  [ATOMICLIB=${withval}])
-
 dnl Avoid dumb '-g -O2' autoconf's default
 dnl Debugging information and optimization flags should be set in prefix.$platform file
 dnl Should be replaced with AC_PROG_GCC_DEFAULT_FLAGS() when available
@@ -1044,7 +1039,6 @@ dnl Check for libraries
 AC_SEARCH_LIBS(dlopen, dl)
 AC_CHECK_LIB(m, main)
 AC_SEARCH_LIBS(inet_aton, resolv)
-AC_CHECK_LIB($ATOMICLIB, main)
 
 dnl Check for libraries for static C++ runtime linking
 AC_CHECK_LIB(supc++, main, XE_APPEND(-lsupc++, STATIC_CXXSUPPORT_LIB))

src/common/classes/SyncObject.cpp

@@ -57,7 +57,6 @@ bool SyncObject::lock(Sync* sync, SyncType type, const char* from, int timeOut)
 			const AtomicCounter::counter_type newState = oldState + 1;
 			if (lockState.compareExchange(oldState, newState))
 			{
-				WaitForFlushCache();
 #ifdef DEV_BUILD
 				MutexLockGuard g(mutex, FB_FUNCTION);
 				reason(from);
@@ -113,7 +112,6 @@ bool SyncObject::lock(Sync* sync, SyncType type, const char* from, int timeOut)
 			if (lockState.compareExchange(oldState, -1))
 			{
 				exclusiveThread = thread;
-				WaitForFlushCache();
 #ifdef DEV_BUILD
 				MutexLockGuard g(mutex, FB_FUNCTION);
 #endif
@@ -168,7 +166,6 @@ bool SyncObject::lockConditional(SyncType type, const char* from)
 			const AtomicCounter::counter_type newState = oldState + 1;
 			if (lockState.compareExchange(oldState, newState))
 			{
-				WaitForFlushCache();
 #ifdef DEV_BUILD
 				MutexLockGuard g(mutex, FB_FUNCTION);
 #endif
@@ -197,7 +194,6 @@ bool SyncObject::lockConditional(SyncType type, const char* from)
 
 			if (lockState.compareExchange(oldState, -1))
 			{
-				WaitForFlushCache();
 				exclusiveThread = thread;
 				reason(from);
 				return true;
@@ -227,8 +223,6 @@ void SyncObject::unlock(Sync* /*sync*/, SyncType type)
 		const AtomicCounter::counter_type oldState = lockState;
 		const AtomicCounter::counter_type newState = (type == SYNC_SHARED) ? oldState - 1 : 0;
 
-		FlushCache();
-
 		if (lockState.compareExchange(oldState, newState))
 		{
 			if (newState == 0 && waiters)
@@ -248,7 +242,6 @@ void SyncObject::downgrade(SyncType type)
 	fb_assert(exclusiveThread == ThreadSync::findThread());
 
 	exclusiveThread = NULL;
-	FlushCache();
 
 	while (true)
 	{

src/common/classes/fb_atomic.h

@@ -162,14 +162,6 @@ class AtomicCounter
 	std::atomic<counter_type> counter;
 };
 
-
-
-// NS 2014-08-01: FIXME. Atomic counters use barriers on all platforms, so
-// these operations are no-ops and will always be no-ops. They were used
-// to work around (incorrectly) bugs in Sparc and PPC atomics code.
-inline void FlushCache() { }
-inline void WaitForFlushCache() { }
-
 } // namespace Firebird
 
 #endif // CLASSES_FB_ATOMIC_H