[action] improvement: use null coalescing operator

Author: connorhu

lib/action/sfAction.class.php

@@ -388,15 +388,7 @@ public function getSecurityValue($name, $default = null)
     {
         $actionName = strtolower($this->getActionName());
 
-        if (isset($this->security[$actionName][$name])) {
-            return $this->security[$actionName][$name];
-        }
-
-        if (isset($this->security['all'][$name])) {
-            return $this->security['all'][$name];
-        }
-
-        return $default;
+        return $this->security[$actionName][$name] ?? $this->security['all'][$name] ?? $default;
     }
 
     /**

lib/action/sfActionStack.class.php

@@ -49,13 +49,7 @@ public function addEntry($moduleName, $actionName, $actionInstance)
      */
     public function getEntry($index)
     {
-        $retval = null;
-
-        if ($index > -1 && $index < count($this->stack)) {
-            $retval = $this->stack[$index];
-        }
-
-        return $retval;
+        return $this->stack[$index] ?? null;
     }
 
     /**
@@ -75,13 +69,7 @@ public function popEntry()
      */
     public function getFirstEntry()
     {
-        $retval = null;
-
-        if (isset($this->stack[0])) {
-            $retval = $this->stack[0];
-        }
-
-        return $retval;
+        return $this->stack[0] ?? null;
     }
 
     /**
@@ -91,14 +79,7 @@ public function getFirstEntry()
      */
     public function getLastEntry()
     {
-        $count = count($this->stack);
-        $retval = null;
-
-        if (isset($this->stack[0])) {
-            $retval = $this->stack[$count - 1];
-        }
-
-        return $retval;
+        return $this->stack[count($this->stack) - 1] ?? null;
     }
 
     /**