Merge pull request #272 from vemaeg/feature/more-php-8.1-fixes

Fix(php) Fix a few more php 8 issues

Author: thePanz

lib/config/sfViewConfigHandler.class.php

@@ -223,7 +223,7 @@ protected function addHtmlHead($viewName = '')
 
     foreach ($this->mergeConfigValue('metas', $viewName) as $name => $content)
     {
-      $data[] = sprintf("  \$response->addMeta('%s', '%s', false, false);", $name, str_replace('\'', '\\\'', preg_replace('/&(?=\w+;)/', '&', htmlspecialchars($content, ENT_QUOTES, sfConfig::get('sf_charset')))));
+      $data[] = sprintf("  \$response->addMeta('%s', '%s', false, false);", $name, str_replace('\'', '\\\'', preg_replace('/&(?=\w+;)/', '&', htmlspecialchars((string) $content, ENT_QUOTES, sfConfig::get('sf_charset')))));
     }
 
     return implode("\n", $data)."\n";

lib/controller/sfController.class.php

@@ -299,7 +299,10 @@ protected function getController($moduleName, $controllerName, $extension)
     $classSuffix = ucfirst(strtolower($extension));
     if (!isset($this->controllerClasses[$moduleName.'_'.$controllerName.'_'.$classSuffix]))
     {
-      $this->controllerExists($moduleName, $controllerName, $extension, true);
+      if (!$this->controllerExists($moduleName, $controllerName, $extension, true))
+      {
+        return null;
+      }
     }
 
     $class = $this->controllerClasses[$moduleName.'_'.$controllerName.'_'.$classSuffix];

lib/escaper/sfOutputEscaperArrayDecorator.class.php

@@ -124,7 +124,8 @@ public function offsetExists($offset)
   #[\ReturnTypeWillChange]
   public function offsetGet($offset)
   {
-    return sfOutputEscaper::escape($this->escapingMethod, $this->value[$offset]);
+    $value = isset($this->value[$offset]) ? $this->value[$offset] : null;
+    return sfOutputEscaper::escape($this->escapingMethod, $value);
   }
 
   /**

lib/request/sfWebRequest.class.php

@@ -192,7 +192,7 @@ public function getContentType($trim = true)
   {
     $contentType = $this->getHttpHeader('Content-Type', null);
 
-    if ($trim && false !== $pos = strpos($contentType, ';'))
+    if ($trim && false !== $pos = strpos((string) $contentType, ';'))
     {
       $contentType = substr($contentType, 0, $pos);
     }

lib/response/sfWebResponse.class.php

@@ -365,7 +365,8 @@ public function sendHttpHeaders()
     // cookies
     foreach ($this->cookies as $cookie)
     {
-      setrawcookie($cookie['name'], $cookie['value'], $cookie['expire'], $cookie['path'], $cookie['domain'], $cookie['secure'], $cookie['httpOnly']);
+      $expire = isset($cookie['expire']) ? $cookie['expire'] : 0;
+      setrawcookie($cookie['name'], $cookie['value'], $expire, $cookie['path'], $cookie['domain'], $cookie['secure'], $cookie['httpOnly']);
 
       if ($this->options['logging'])
       {