bugfix: avoid extra encoding/decoding PLD params (#10187)

The params and response from the PLD library are being encoded/decoded
unnecessarily. Removing this extra processing which is making the
password leak check to fail.

Change-Id: I7cd4a7baa25677689ea7e4a50f539fff8a035a4c

Author: serargz

recaptcha_enterprise/snippets/src/main/java/recaptcha/passwordleak/CreatePasswordLeakAssessment.java

@@ -30,7 +30,6 @@
 import java.util.List;
 import java.util.concurrent.ExecutionException;
 import java.util.stream.Collectors;
-import org.bouncycastle.util.encoders.Base64;
 
 public class CreatePasswordLeakAssessment {
 
@@ -93,9 +92,8 @@ public static void checkPasswordLeak(
     PasswordCheckVerification verification =
         passwordLeak.createVerification(username, password).get();
 
-    byte[] lookupHashPrefix = Base64.encode(verification.getLookupHashPrefix());
-    byte[] encryptedUserCredentialsHash = Base64.encode(
-        verification.getEncryptedUserCredentialsHash());
+    byte[] lookupHashPrefix = verification.getLookupHashPrefix();
+    byte[] encryptedUserCredentialsHash = verification.getEncryptedUserCredentialsHash();
 
     // Pass the credentials to the createPasswordLeakAssessment() to get back
     // the matching database entry for the hash prefix.
@@ -108,15 +106,15 @@ public static void checkPasswordLeak(
     // Convert to appropriate input format.
     List<byte[]> leakMatchPrefixes =
         credentials.getEncryptedLeakMatchPrefixesList().stream()
-            .map(x -> Base64.decode(x.toByteArray()))
+            .map(x -> x.toByteArray())
             .collect(Collectors.toList());
 
     // Verify if the encrypted credentials are present in the obtained match list.
     PasswordCheckResult result =
         passwordLeak
             .verify(
                 verification,
-                Base64.decode(credentials.getReencryptedUserCredentialsHash().toByteArray()),
+                credentials.getReencryptedUserCredentialsHash().toByteArray(),
                 leakMatchPrefixes)
             .get();
 

recaptcha_enterprise/snippets/src/pom.xml

@@ -14,7 +14,7 @@
   <parent>
     <groupId>com.google.cloud.samples</groupId>
     <artifactId>shared-configuration</artifactId>
-    <version>1.2.0</version>
+    <version>1.2.2</version>
   </parent>
 
   <properties>