Skip to content

Commit 70a5a5e

Browse files
Refactor: Use UpNavigationActivity and update dependencies
This commit refactors `SupportActivity` and `HelpActivity` to extend the new `UpNavigationActivity`, centralizing the "up" navigation logic. It also includes several dependency updates. Key changes: - **Base Activity Refactor**: `SupportActivity` and `HelpActivity` now inherit from `UpNavigationActivity` instead of `BaseActivity`. - **Dependency Updates**: - `material` to `1.14.0-alpha06` - `firebaseBom` to `34.4.0` - `googleServices` to `4.4.4` - `playServicesAds` to `24.7.0` - `room` to `2.8.3` - **Drawable Cleanup**: Removed an unnecessary, empty `<path>` from the `ic_arrow_forward.xml` drawable.
1 parent 7ec6376 commit 70a5a5e

File tree

4 files changed

+9
-11
lines changed

4 files changed

+9
-11
lines changed

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/help/HelpActivity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import com.d4rk.androidtutorials.java.databinding.ActivityHelpBinding;
2525
import com.d4rk.androidtutorials.java.databinding.DialogVersionInfoBinding;
2626
import com.d4rk.androidtutorials.java.databinding.ItemHelpFaqBinding;
27-
import com.d4rk.androidtutorials.java.ui.components.navigation.BaseActivity;
27+
import com.d4rk.androidtutorials.java.ui.components.navigation.UpNavigationActivity;
2828
import com.d4rk.androidtutorials.java.ui.screens.help.repository.HelpRepository;
2929
import com.d4rk.androidtutorials.java.utils.EdgeToEdgeHelper;
3030
import com.d4rk.androidtutorials.java.utils.OpenSourceLicensesUtils;
@@ -38,7 +38,7 @@
3838
import me.zhanghai.android.fastscroll.FastScrollerBuilder;
3939

4040
@AndroidEntryPoint
41-
public class HelpActivity extends BaseActivity {
41+
public class HelpActivity extends UpNavigationActivity {
4242

4343
private static final List<FaqItem> FAQ_ITEMS = Arrays.asList(
4444
new FaqItem(R.string.question_1, R.string.summary_preference_faq_1),

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/support/SupportActivity.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import com.d4rk.androidtutorials.java.data.repository.SupportRepository;
1313
import com.d4rk.androidtutorials.java.databinding.ActivitySupportBinding;
1414
import com.d4rk.androidtutorials.java.ui.components.navigation.BaseActivity;
15+
import com.d4rk.androidtutorials.java.ui.components.navigation.UpNavigationActivity;
1516
import com.d4rk.androidtutorials.java.utils.EdgeToEdgeHelper;
1617
import com.google.android.gms.ads.AdRequest;
1718

@@ -20,7 +21,7 @@
2021
import dagger.hilt.android.AndroidEntryPoint;
2122

2223
@AndroidEntryPoint
23-
public class SupportActivity extends BaseActivity {
24+
public class SupportActivity extends UpNavigationActivity {
2425

2526
private ActivitySupportBinding binding;
2627
private SupportViewModel supportViewModel;

app/src/main/res/drawable/ic_arrow_forward.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@
44
android:height="24dp"
55
android:viewportWidth="24"
66
android:viewportHeight="24">
7-
8-
<path
9-
android:pathData="M0 0h24v24H0V0z" />
107
<path
118
android:fillColor="#000000"
129
android:pathData="M12 4l-1.41 1.41L16.17 11H4v2h12.17l-5.58 5.59L12 20l8-8-8-8z" />

gradle/libs.versions.toml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[versions]
22
agp = "8.13.0"
33
firebaseCrashlyticsPlugin = "3.0.6"
4-
googleServices = "4.4.3"
4+
googleServices = "4.4.4"
55
ossLicensesPlugin = "0.10.9"
66
appcompat = "1.7.1"
77
appUpdate = "2.1.0"
@@ -10,7 +10,7 @@ constraintlayout = "2.2.1"
1010
coreSplashscreen = "1.0.1"
1111
core = "4.6.2"
1212
coreTesting = "2.2.0"
13-
firebaseBom = "34.3.0"
13+
firebaseBom = "34.4.0"
1414
gridlayout = "1.1.0"
1515
junit = "4.13.2"
1616
library = "1.3.0"
@@ -24,12 +24,12 @@ preference = "1.2.1"
2424
review = "2.0.2"
2525
volley = "1.2.1"
2626
coreKtx = "1.17.0"
27-
material = "1.14.0-alpha05"
28-
playServicesAds = "24.6.0"
27+
material = "1.14.0-alpha06"
28+
playServicesAds = "24.7.0"
2929
playServicesOssLicenses = "17.3.0"
3030
codeview = "1.3.9"
3131
hilt = "2.57.2"
32-
room = "2.8.2"
32+
room = "2.8.3"
3333
glide = "5.0.5"
3434
retrofit = "3.0.0"
3535

0 commit comments

Comments
 (0)