Simplify help screen and remove feedback fragment

Author: MihaiCristianCondrea

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/help/HelpActivity.java

@@ -4,22 +4,18 @@
 import android.content.Intent;
 import android.net.Uri;
 import android.os.Bundle;
+import android.os.Handler;
+import android.os.Looper;
 import android.view.LayoutInflater;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
-import android.view.ViewGroup;
-import android.widget.FrameLayout;
 import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
 import androidx.annotation.StringRes;
 import androidx.appcompat.app.AlertDialog;
 import androidx.appcompat.widget.LinearLayoutCompat;
 import androidx.core.view.ViewCompat;
 import androidx.lifecycle.ViewModelProvider;
-import androidx.preference.Preference;
-import androidx.preference.PreferenceFragmentCompat;
-import androidx.recyclerview.widget.RecyclerView;
 
 import com.d4rk.androidtutorials.java.BuildConfig;
 import com.d4rk.androidtutorials.java.R;
@@ -44,6 +40,7 @@ public class HelpActivity extends BaseActivity {
 
     private ActivityHelpBinding binding;
     private HelpViewModel helpViewModel;
+    private final Handler handler = new Handler(Looper.getMainLooper());
     private static final List<FaqItem> FAQ_ITEMS = Arrays.asList(
             new FaqItem(R.string.question_1, R.string.summary_preference_faq_1),
             new FaqItem(R.string.question_2, R.string.summary_preference_faq_2),
@@ -68,12 +65,8 @@ protected void onCreate(Bundle savedInstanceState) {
                 .build();
         bindFaqItems(binding);
         setupContactSupportCard();
-
-        if (savedInstanceState == null) {
-            getSupportFragmentManager().beginTransaction()
-                    .replace(R.id.frame_layout_feedback, new FeedbackFragment())
-                    .commit();
-        }
+        setupFeedbackFab();
+        handler.postDelayed(() -> binding.fabContactSupport.shrink(), 5000L);
     }
 
     @Override
@@ -144,6 +137,11 @@ private void setupContactSupportCard() {
         binding.contactSupportCard.setOnClickListener(v -> openSupportEmail());
     }
 
+    private void setupFeedbackFab() {
+        binding.fabContactSupport.setOnClickListener(v -> requestReview());
+        binding.fabContactSupport.setContentDescription(getString(R.string.send_feedback));
+    }
+
     private void openSupportEmail() {
         String supportEmail = getString(R.string.contact_support_email);
         Intent intent = new Intent(Intent.ACTION_SENDTO);
@@ -160,6 +158,37 @@ private void openSupportEmail() {
         }
     }
 
+    private void requestReview() {
+        binding.fabContactSupport.setEnabled(false);
+        helpViewModel.requestReviewFlow(new HelpRepository.OnReviewInfoListener() {
+            @Override
+            public void onSuccess(ReviewInfo info) {
+                helpViewModel.launchReviewFlow(HelpActivity.this, info);
+                binding.fabContactSupport.setEnabled(true);
+            }
+
+            @Override
+            public void onFailure(Exception e) {
+                binding.fabContactSupport.setEnabled(true);
+                launchGooglePlayReviews();
+            }
+        });
+    }
+
+    private void launchGooglePlayReviews() {
+        Uri uri = Uri.parse("https://play.google.com/store/apps/details?id=" + getPackageName() + "&showAllReviews=true");
+        Intent intent = new Intent(Intent.ACTION_VIEW, uri);
+        intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+        try {
+            startActivity(intent);
+        } catch (ActivityNotFoundException e) {
+            Snackbar.make(binding.getRoot(),
+                            R.string.snack_unable_to_open_google_play_store,
+                            Snackbar.LENGTH_SHORT)
+                    .show();
+        }
+    }
+
     public HelpViewModel getHelpViewModel() {
         return helpViewModel;
     }
@@ -206,73 +235,6 @@ private void toggleFaqItem(ItemHelpFaqBinding binding) {
         ViewCompat.setStateDescription(binding.questionContainer, stateDescription);
     }
 
-    public static class FeedbackFragment extends PreferenceFragmentCompat {
-
-        @Override
-        public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
-            setPreferencesFromResource(R.xml.preferences_feedback, rootKey);
-
-            Preference feedbackPreference = findPreference(getString(R.string.key_feedback));
-            if (feedbackPreference != null) {
-                feedbackPreference.setOnPreferenceClickListener(preference -> {
-                    if (requireActivity() instanceof HelpActivity helpActivity) {
-                        HelpViewModel vm = helpActivity.getHelpViewModel();
-
-                        vm.requestReviewFlow(new HelpRepository.OnReviewInfoListener() {
-                            @Override
-                            public void onSuccess(ReviewInfo info) {
-                                vm.launchReviewFlow(helpActivity, info);
-                            }
-
-                            @Override
-                            public void onFailure(Exception e) {
-                                launchGooglePlayReviews();
-                            }
-                        });
-                    }
-                    return true;
-                });
-            }
-        }
-
-        @Override
-        public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
-            super.onViewCreated(view, savedInstanceState);
-            RecyclerView listView = getListView();
-            listView.setNestedScrollingEnabled(false);
-            listView.setOverScrollMode(View.OVER_SCROLL_NEVER);
-            listView.setClipToPadding(false);
-
-            ViewGroup.LayoutParams layoutParams = listView.getLayoutParams();
-            FrameLayout.LayoutParams frameLayoutParams;
-            if (layoutParams instanceof FrameLayout.LayoutParams) {
-                frameLayoutParams = (FrameLayout.LayoutParams) layoutParams;
-            } else {
-                frameLayoutParams = new FrameLayout.LayoutParams(
-                        ViewGroup.LayoutParams.MATCH_PARENT,
-                        ViewGroup.LayoutParams.WRAP_CONTENT
-                );
-            }
-            frameLayoutParams.height = ViewGroup.LayoutParams.WRAP_CONTENT;
-            frameLayoutParams.width = ViewGroup.LayoutParams.MATCH_PARENT;
-            listView.setLayoutParams(frameLayoutParams);
-        }
-
-        private void launchGooglePlayReviews() {
-            Uri uri = Uri.parse("https://play.google.com/store/apps/details?id=" + requireActivity().getPackageName() + "&showAllReviews=true");
-            Intent intent = new Intent(Intent.ACTION_VIEW, uri);
-            intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
-            try {
-                startActivity(intent);
-            } catch (ActivityNotFoundException e) {
-                Snackbar.make(requireView(),
-                                R.string.snack_unable_to_open_google_play_store,
-                                Snackbar.LENGTH_SHORT)
-                        .show();
-            }
-        }
-    }
-
     private static final class FaqItem {
         @StringRes
         private final int questionResId;
@@ -284,4 +246,10 @@ private FaqItem(@StringRes int questionResId, @StringRes int answerResId) {
             this.answerResId = answerResId;
         }
     }
-}
+
+    @Override
+    protected void onDestroy() {
+        handler.removeCallbacksAndMessages(null);
+        super.onDestroy();
+    }
+}

app/src/main/res/drawable/bg_contact_support_icon.xml

@@ -1,5 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
-<shape xmlns:android="http://schemas.android.com/apk/res/android"
-    android:shape="oval">
-    <solid android:color="?attr/colorSecondaryContainer" />
-</shape>
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="289dp"
+    android:height="289dp"
+    android:viewportWidth="289"
+    android:viewportHeight="289">
+
+    <path
+        android:fillColor="?attr/colorSecondaryContainer"
+        android:pathData="M3.2,160.9c-3.9-6.6-4.2-14.7-0.8-21.6l4.8-9.7c2-4.1,2.8-8.8,2.1-13.3l-1.6-10.7C6.6,98,9.4,90.4,15.2,85.3 l8.1-7.1c3.4-3,5.9-7,7-11.5L33,56.2c1.9-7.5,7.4-13.4,14.7-15.9l10.2-3.5c4.4-1.5,8.2-4.2,10.9-7.9l6.4-8.7 c4.6-6.2,12-9.6,19.7-9.1l10.8,0.7c4.6,0.3,9.2-0.8,13.1-3.1l9.3-5.5c6.6-3.9,14.7-4.3,21.6-0.8l9.7,4.8c4.1,2,8.8,2.8,13.3,2.1 l10.7-1.6c7.6-1.1,15.2,1.7,20.3,7.5l7.1,8.1c3,3.4,7,5.9,11.5,7l10.5,2.7c7.5,1.9,13.4,7.4,15.9,14.7l3.5,10.2 c1.5,4.4,4.2,8.2,7.9,10.9l8.7,6.4c6.2,4.6,9.6,12,9.1,19.7l-0.7,10.8c-0.3,4.6,0.8,9.2,3.1,13.1l5.5,9.3c3.9,6.6,4.2,14.7,0.8,21.6 l-4.8,9.7c-2,4.1-2.8,8.8-2.1,13.3l1.6,10.7c1.1,7.6-1.7,15.2-7.5,20.3l-8.1,7.1c-3.4,3-5.9,7-7,11.5l-2.7,10.5 c-1.9,7.5-7.4,13.4-14.7,15.9l-10.2,3.5c-4.4,1.5-8.2,4.2-10.9,7.9l-6.4,8.7c-4.6,6.2-12,9.6-19.7,9.1l-10.8-0.7 c-4.6-0.3-9.2,0.8-13.1,3.1l-9.3,5.5c-6.6,3.9-14.7,4.3-21.6,0.8l-9.7-4.8c-4.1-2-8.8-2.8-13.3-2.1l-10.7,1.6 c-7.6,1.1-15.2-1.7-20.3-7.5l-7.1-8.1c-3-3.4-7-5.9-11.5-7L56.2,256c-7.5-1.9-13.4-7.4-15.9-14.7l-3.5-10.2 c-1.5-4.4-4.2-8.2-7.9-10.9l-8.7-6.4c-6.2-4.6-9.6-12-9.1-19.7l0.7-10.8c0.3-4.6-0.8-9.2-3.1-13.1L3.2,160.9L3.2,160.9z" />
+</vector>

app/src/main/res/drawable/ic_contact_support.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="utf-8"?>
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:viewportWidth="24"
+    android:viewportHeight="24">
+
+    <path
+        android:fillColor="#000000"
+        android:pathData="M12,2C6.48,2,2,6.48,2,12c0,5.52,4.48,10,10,10s10-4.48,10-10C22,6.48,17.52,2,12,2z M19.46,9.12l-2.78,1.15 c-0.51-1.36-1.58-2.44-2.95-2.94l1.15-2.78C16.98,5.35,18.65,7.02,19.46,9.12z M12,15c-1.66,0-3-1.34-3-3s1.34-3,3-3s3,1.34,3,3 S13.66,15,12,15z M9.13,4.54l1.17,2.78c-1.38,0.5-2.47,1.59-2.98,2.97L4.54,9.13C5.35,7.02,7.02,5.35,9.13,4.54z M4.54,14.87 l2.78-1.15c0.51,1.38,1.59,2.46,2.97,2.96l-1.17,2.78C7.02,18.65,5.35,16.98,4.54,14.87z M14.88,19.46l-1.15-2.78 c1.37-0.51,2.45-1.59,2.95-2.97l2.78,1.17C18.65,16.98,16.98,18.65,14.88,19.46z" />
+</vector>

app/src/main/res/layout/activity_help.xml

@@ -86,7 +86,8 @@
                             android:layout_width="match_parent"
                             android:layout_height="match_parent"
                             android:contentDescription="@null"
-                            android:src="@drawable/ic_feedback" />
+                            android:src="@drawable/ic_contact_support"
+                            android:tint="?attr/colorOnSecondaryContainer" />
 
                     </FrameLayout>
 
@@ -114,24 +115,22 @@
 
                     </androidx.appcompat.widget.LinearLayoutCompat>
 
-                    <androidx.appcompat.widget.AppCompatImageView
-                        android:layout_width="wrap_content"
-                        android:layout_height="wrap_content"
-                        android:contentDescription="@null"
-                        android:src="@drawable/ic_arrow_forward"
-                        android:tint="?attr/colorOnSurfaceVariant" />
-
                 </androidx.appcompat.widget.LinearLayoutCompat>
 
             </com.google.android.material.card.MaterialCardView>
 
-            <FrameLayout
-                android:id="@+id/frame_layout_feedback"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content" />
-
         </androidx.appcompat.widget.LinearLayoutCompat>
 
     </me.zhanghai.android.fastscroll.FastScrollScrollView>
 
+    <com.google.android.material.floatingactionbutton.ExtendedFloatingActionButton
+        android:id="@+id/fab_contact_support"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_margin="16dp"
+        android:text="@string/send_feedback"
+        app:icon="@drawable/ic_rate_review"
+        app:layout_constraintBottom_toBottomOf="parent"
+        app:layout_constraintEnd_toEndOf="parent" />
+
 </androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/ad_help.xml

@@ -5,6 +5,7 @@
     android:layout_height="wrap_content">
 
     <com.google.android.material.card.MaterialCardView
+        android:id="@+id/ad_card"
         style="@style/Widget.Material3.CardView.Filled"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"