Use public CFS feed and remove NuGet lockfiles (#2161)

Partially reverts commit 5b37344.

Author: andyleejordan

.github/dependabot.yml

@@ -1,15 +1,7 @@
 version: 2
-registries:
-  nuget-azure:
-    type: nuget-feed
-    url: https://pkgs.dev.azure.com/mscodehub/PowerShellCore/_packaging/PowerShellCore_PublicPackages/nuget/v3/index.json
-    username: powershell
-    password: ${{ secrets.AZURE_NUGET_TOKEN }}
 updates:
 - package-ecosystem: nuget
   directory: "/"
-  registries:
-    - nuget-azure
   labels: [ ]
   schedule:
     interval: weekly

.github/workflows/ci-test.yml

@@ -32,16 +32,12 @@ jobs:
         uses: actions/setup-dotnet@v4
         with:
           cache: true
-          cache-dependency-path: '**/packages.lock.json'
+          cache-dependency-path: '**/*.csproj'
           dotnet-version: |
             6.0.x
             7.0.x
             8.0.x
 
-      - name: Remove Azure Artifact Feed configurations
-        shell: pwsh
-        run: Remove-Item ./NuGet.Config
-
       - name: Install PSResources
         shell: pwsh
         run: ./tools/installPSResources.ps1

.github/workflows/codeql-analysis.yml

@@ -34,11 +34,7 @@ jobs:
       uses: actions/setup-dotnet@v4
       with:
         cache: true
-        cache-dependency-path: '**/packages.lock.json'
-
-    - name: Remove Azure Artifact Feed configurations
-      shell: pwsh
-      run: Remove-Item ./NuGet.Config
+        cache-dependency-path: '**/*.csproj'
 
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v3

.github/workflows/emacs-test.yml

@@ -26,11 +26,7 @@ jobs:
         uses: actions/setup-dotnet@v4
         with:
           cache: true
-          cache-dependency-path: '**/packages.lock.json'
-
-      - name: Remove Azure Artifact Feed configurations
-        shell: pwsh
-        run: Remove-Item ./NuGet.Config
+          cache-dependency-path: '**/*.csproj'
 
       - name: Install PSResources
         shell: pwsh

.github/workflows/vim-test.yml

@@ -26,11 +26,7 @@ jobs:
         uses: actions/setup-dotnet@v4
         with:
           cache: true
-          cache-dependency-path: '**/packages.lock.json'
-
-      - name: Remove Azure Artifact Feed configurations
-        shell: pwsh
-        run: Remove-Item ./NuGet.Config
+          cache-dependency-path: '**/*.csproj'
 
       - name: Install PSResources
         shell: pwsh

PowerShellEditorServices.Common.props

@@ -11,8 +11,6 @@
     <RepositoryType>git</RepositoryType>
     <RepositoryUrl>https://github.com/PowerShell/PowerShellEditorServices</RepositoryUrl>
     <DebugType>portable</DebugType>
-    <!-- See https://learn.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#locking-dependencies -->
-    <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
     <!-- See: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/overview -->
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>

NuGet.Config renamed to nuget.config

@@ -2,6 +2,6 @@
 <configuration>
   <packageSources>
     <clear />
-    <add key="PowerShellCore_PublicPackages" value="https://pkgs.dev.azure.com/mscodehub/PowerShellCore/_packaging/PowerShellCore_PublicPackages/nuget/v3/index.json" />
+    <add key="PowerShellCore_PublicPackages" value="https://pkgs.dev.azure.com/powershell/PowerShell/_packaging/powershell/nuget/v3/index.json" />
   </packageSources>
 </configuration>