Add timestamps and log levels to all extension-side log messages

Author: daviwil

src/logging.ts

@@ -49,10 +49,10 @@ export class Logger {
 
     public writeAtLevel(logLevel: LogLevel, message: string, ...additionalMessages: string[]) {
         if (logLevel >= this.MinimumLogLevel) {
-            this.writeLine(message)
+            this.writeLine(message, logLevel)
 
             additionalMessages.forEach((line) => {
-                this.writeLine(line);
+                this.writeLine(line, logLevel);
             });
         }
     }
@@ -136,11 +136,13 @@ export class Logger {
         }
     }
 
-    private writeLine(message: string) {
-        // TODO: Add timestamp
-        this.logChannel.appendLine(message);
+    private writeLine(message: string, level: LogLevel = LogLevel.Normal) {
+        let now = new Date();
+        let timestampedMessage = `${now.toLocaleDateString()} ${now.toLocaleTimeString()} [${LogLevel[level].toUpperCase()}] - ${message}`
+
+        this.logChannel.appendLine(timestampedMessage);
         if (this.logFilePath) {
-            fs.appendFile(this.logFilePath, message + os.EOL);
+            fs.appendFile(this.logFilePath, timestampedMessage + os.EOL);
         }
     }
 }

src/process.ts

@@ -85,7 +85,7 @@ export class PowerShellProcess {
                         powerShellExePath = batScriptPath;
                     }
 
-                    this.log.write(`${utils.getTimestampString()} Language server starting...`);
+                    this.log.write("Language server starting...");
 
                     // Make sure no old session file exists
                     utils.deleteSessionFile(this.sessionFilePath);

src/session.ts

@@ -329,7 +329,7 @@ export class SessionManager implements Middleware {
                     this.sessionDetails = sessionDetails;
 
                     if (sessionDetails.status === "started") {
-                        this.log.write(`${utils.getTimestampString()} Language server started.`);
+                        this.log.write("Language server started.");
 
                         // Start the language service client
                         this.startLanguageClient(sessionDetails);
@@ -352,7 +352,7 @@ export class SessionManager implements Middleware {
                     }
                 },
                 error => {
-                    this.log.write(`${utils.getTimestampString()} Language server startup failed.`);
+                    this.log.write("Language server startup failed.");
                     this.setSessionFailure("The language service could not be started: ", error);
                 }
             );