Skip to content

Commit 30eae08

Browse files
jClugstorChrisRackauckas
authored andcommitted
add deprecation path for alias_u0 in __init and __solve
1 parent 276d331 commit 30eae08

File tree

16 files changed

+47
-2
lines changed

16 files changed

+47
-2
lines changed

ext/NonlinearSolveFixedPointAccelerationExt.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ function SciMLBase.__solve(
1111
abstol = nothing, maxiters = 1000, alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = false),
1212
show_trace::Val = Val(false), termination_condition = nothing, kwargs...
1313
)
14+
if haskey(kwargs, :alias_u0)
15+
alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
16+
end
1417
alias_u0 = alias.alias_u0
1518
NonlinearSolveBase.assert_extension_supported_termination_condition(
1619
termination_condition, alg

ext/NonlinearSolveNLSolversExt.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ function SciMLBase.__solve(
1616
abstol = nothing, reltol = nothing, maxiters = 1000, alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = false),
1717
termination_condition = nothing, kwargs...
1818
)
19+
if haskey(kwargs, :alias_u0)
20+
alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
21+
end
1922
alias_u0 = alias.alias_u0
2023
NonlinearSolveBase.assert_extension_supported_termination_condition(
2124
termination_condition, alg

ext/NonlinearSolveNLsolveExt.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ function SciMLBase.__solve(
1313
termination_condition = nothing, trace_level = TraceMinimal(),
1414
store_trace::Val = Val(false), show_trace::Val = Val(false), kwargs...
1515
)
16+
if haskey(kwargs, :alias_u0)
17+
alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
18+
end
1619
alias_u0 = alias.alias_u0
1720
NonlinearSolveBase.assert_extension_supported_termination_condition(
1821
termination_condition, alg

ext/NonlinearSolvePETScExt.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ function SciMLBase.__solve(
1717
maxiters = 1000, alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = false), termination_condition = nothing,
1818
show_trace::Val = Val(false), kwargs...
1919
)
20+
if haskey(kwargs, :alias_u0)
21+
alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
22+
end
2023
alias_u0 = alias.alias_u0
2124
# XXX: https://petsc.org/release/manualpages/SNES/SNESSetConvergenceTest/
2225
NonlinearSolveBase.assert_extension_supported_termination_condition(

ext/NonlinearSolveSIAMFANLEquationsExt.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ function SciMLBase.__solve(
4242
abstol = nothing, reltol = nothing, alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = false), maxiters = 1000,
4343
termination_condition = nothing, show_trace = Val(false), kwargs...
4444
)
45+
if haskey(kwargs, :alias_u0)
46+
alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
47+
end
4548
alias_u0 = alias.alias_u0
4649
NonlinearSolveBase.assert_extension_supported_termination_condition(
4750
termination_condition, alg

ext/NonlinearSolveSpeedMappingExt.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ function SciMLBase.__solve(
1212
maxtime = nothing, store_trace::Val = Val(false),
1313
termination_condition = nothing, kwargs...
1414
)
15+
if haskey(kwargs, :alias_u0)
16+
alias = SciMLBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
17+
end
1518
alias_u0 = alias.alias_u0
1619
NonlinearSolveBase.assert_extension_supported_termination_condition(
1720
termination_condition, alg

lib/NonlinearSolveBase/src/polyalg.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,9 @@ function SciMLBase.__init(
122122
internalnorm::IN = L2_NORM, alias = NonlinearAliasSpecifier(alias_u0 = false), verbose = NonlinearVerbosity(),
123123
initializealg = NonlinearSolveDefaultInit(), kwargs...
124124
) where {IN}
125+
if haskey(kwargs, :alias_u0)
126+
alias = NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
127+
end
125128
alias_u0 = alias.alias_u0
126129
if alias_u0 && !ArrayInterface.ismutable(prob.u0)
127130
@SciMLMessage("`alias_u0` has been set to `true`, but `u0` is

lib/NonlinearSolveBase/src/solve.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,10 @@ function solve(prob::AbstractNonlinearProblem, args...; sensealg = nothing,
7171
elseif haskey(prob.kwargs, :alias) && prob.kwargs[:alias] isa Bool
7272
NonlinearAliasSpecifier(alias = prob.kwargs[:alias])
7373
elseif haskey(kwargs, :alias_u0)
74-
@warn lazy"The `alias_u0` keyword argument is deprecated. Please use a NonlinearAliasSpecifier, e.g. `alias = NonlinearAliasSpecifier(alias_u0 = true)`."
74+
@warn "The `alias_u0` keyword argument is deprecated. Please use a NonlinearAliasSpecifier, e.g. `alias = NonlinearAliasSpecifier(alias_u0 = true)`."
7575
NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
7676
elseif haskey(prob.kwargs, :alias_u0)
77-
@warn lazy"The `alias_u0` keyword argument is deprecated. Please use a NonlinearAliasSpecifier, e.g. `alias = NonlinearAliasSpecifier(alias_u0 = true)`."
77+
@warn "The `alias_u0` keyword argument is deprecated. Please use a NonlinearAliasSpecifier, e.g. `alias = NonlinearAliasSpecifier(alias_u0 = true)`."
7878
NonlinearAliasSpecifier(alias_u0 = prob.kwargs[:alias_u0])
7979
else
8080
NonlinearAliasSpecifier(alias_u0 = false)

lib/NonlinearSolveFirstOrder/src/solve.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,9 @@ function SciMLBase.__init(
134134
termination_condition = nothing, internalnorm::IN = L2_NORM, verbose = NonlinearVerbosity(),
135135
linsolve_kwargs = (;), initializealg = NonlinearSolveBase.NonlinearSolveDefaultInit(), kwargs...
136136
) where {IN}
137+
if haskey(kwargs, :alias_u0)
138+
alias = NonlinearSolveBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
139+
end
137140
alias_u0 = alias.alias_u0
138141
@set! alg.autodiff = NonlinearSolveBase.select_jacobian_autodiff(prob, alg.autodiff)
139142
provided_jvp_autodiff = alg.jvp_autodiff !== nothing

lib/NonlinearSolveQuasiNewton/src/solve.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,9 @@ function SciMLBase.__init(
154154
verbose = NonlinearVerbosity(),
155155
kwargs...
156156
) where {F}
157+
if haskey(kwargs, :alias_u0)
158+
alias = NonlinearSolveBase.NonlinearAliasSpecifier(alias_u0 = kwargs[:alias_u0])
159+
end
157160
alias_u0 = alias.alias_u0
158161
timer = get_timer_output()
159162
@static_timeit timer "cache construction" begin

0 commit comments

Comments
 (0)