fix: Consider schema encapsulation.

Author: ShogunPanda

lib/validation.js

@@ -176,6 +176,7 @@ function addResponseValidation(route) {
       This makes possible to handle shared schemas.
     */
     this[interfaces_1.kHttpErrorsEnhancedResponseValidations].push([
+        this,
         validators,
         Object.entries(route.schema.response)
     ]);
@@ -206,18 +207,18 @@ function addResponseValidation(route) {
 }
 exports.addResponseValidation = addResponseValidation;
 function compileResponseValidationSchema() {
-    const validator = new ajv_1.default({
-        // The fastify defaults, with the exception of removeAdditional and coerceTypes, which have been reversed
-        removeAdditional: false,
-        useDefaults: true,
-        coerceTypes: false,
-        allErrors: true,
-        nullable: true
-    });
-    validator.addSchema(Object.values(this.getSchemas()));
-    for (const [validators, schemas] of this[interfaces_1.kHttpErrorsEnhancedResponseValidations]) {
+    for (const [instance, validators, schemas] of this[interfaces_1.kHttpErrorsEnhancedResponseValidations]) {
+        const compiler = new ajv_1.default({
+            // The fastify defaults, with the exception of removeAdditional and coerceTypes, which have been reversed
+            removeAdditional: false,
+            useDefaults: true,
+            coerceTypes: false,
+            allErrors: true,
+            nullable: true
+        });
+        compiler.addSchema(Object.values(instance.getSchemas()));
         for (const [code, schema] of schemas) {
-            validators[code] = validator.compile(schema);
+            validators[code] = compiler.compile(schema);
         }
     }
 }

src/interfaces.ts

@@ -7,7 +7,8 @@ declare module 'fastify' {
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   interface FastifyInstance {
     responseValidatorSchemaCompiler: Ajv
-    [kHttpErrorsEnhancedResponseValidations]: Array<[ResponseSchemas, Array<[string, object]>]>
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    [kHttpErrorsEnhancedResponseValidations]: Array<[FastifyInstance, ResponseSchemas, Array<[string, object]>]>
   }
 
   // eslint-disable-next-line @typescript-eslint/no-unused-vars

src/validation.ts

@@ -208,6 +208,7 @@ export function addResponseValidation(this: FastifyInstance, route: RouteOptions
     This makes possible to handle shared schemas.
   */
   this[kHttpErrorsEnhancedResponseValidations].push([
+    this,
     validators,
     Object.entries(route.schema.response as { [key: string]: object })
   ])
@@ -251,20 +252,20 @@ export function addResponseValidation(this: FastifyInstance, route: RouteOptions
 }
 
 export function compileResponseValidationSchema(this: FastifyInstance): void {
-  const validator = new Ajv({
-    // The fastify defaults, with the exception of removeAdditional and coerceTypes, which have been reversed
-    removeAdditional: false,
-    useDefaults: true,
-    coerceTypes: false,
-    allErrors: true,
-    nullable: true
-  })
-
-  validator.addSchema(Object.values(this.getSchemas()))
-
-  for (const [validators, schemas] of this[kHttpErrorsEnhancedResponseValidations]) {
+  for (const [instance, validators, schemas] of this[kHttpErrorsEnhancedResponseValidations]) {
+    const compiler = new Ajv({
+      // The fastify defaults, with the exception of removeAdditional and coerceTypes, which have been reversed
+      removeAdditional: false,
+      useDefaults: true,
+      coerceTypes: false,
+      allErrors: true,
+      nullable: true
+    })
+
+    compiler.addSchema(Object.values(instance.getSchemas()))
+
     for (const [code, schema] of schemas) {
-      validators[code] = validator.compile(schema)
+      validators[code] = compiler.compile(schema)
     }
   }
 }

types/interfaces.d.ts

@@ -5,7 +5,7 @@ export declare const kHttpErrorsEnhancedResponseValidations: unique symbol;
 declare module 'fastify' {
     interface FastifyInstance {
         responseValidatorSchemaCompiler: Ajv;
-        [kHttpErrorsEnhancedResponseValidations]: Array<[ResponseSchemas, Array<[string, object]>]>;
+        [kHttpErrorsEnhancedResponseValidations]: Array<[FastifyInstance, ResponseSchemas, Array<[string, object]>]>;
     }
     interface FastifyRequest {
         [kHttpErrorsEnhancedProperties]?: {