From dd5eeed4cc4cf691a091b95a05a07e511e4ce3c6 Mon Sep 17 00:00:00 2001 From: Anshul Sahni Date: Wed, 29 Mar 2017 21:37:12 +0530 Subject: [PATCH 1/2] re-arranging require statements --- gulpfile.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index 5989578..4b7b019 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -5,17 +5,18 @@ */ const gulp = require('gulp'); const gutil = require('gulp-util'); -const browserify = require('browserify'); -const watchify = require('watchify'); -const source = require('vinyl-source-stream'); -const buffer = require('vinyl-buffer'); -const browserSync = require('browser-sync'); const eslint = require('gulp-eslint'); const sourcemaps = require('gulp-sourcemaps'); const uglify = require('gulp-uglify'); const mocha = require('gulp-mocha'); const babel = require('gulp-babel'); +const browserify = require('browserify'); +const watchify = require('watchify'); +const source = require('vinyl-source-stream'); +const buffer = require('vinyl-buffer'); +const browserSync = require('browser-sync'); + /** * function to handle errors from any task */ From c5590025642c5b7927f41a16c4e87441edfcc03a Mon Sep 17 00:00:00 2001 From: Anshul Sahni Date: Thu, 30 Mar 2017 00:00:47 +0530 Subject: [PATCH 2/2] improvements in some of the gulp tasks --- gulpfile.js | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index 4b7b019..998916c 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -114,7 +114,9 @@ gulp.task('lint:failOnError', checkLint(true)); gulp.task('lint:noFailOnError', checkLint(false)); // default lint task -gulp.task('lint', ['lint:failOnError']); +gulp.task('lint', ['lint:failOnError'], function() { + gutil.log('No Lint Errors'); +}); /** * tasks to bundle all the javscript files @@ -130,27 +132,32 @@ gulp.task('scripts:development', bundleJs({ })); // from src directory to distribution directory - release/production mode -gulp.task('scripts:release', function() { - return gulp.src([ +gulp.task('scripts:release', ['lint:failOnError', 'test'] , function() { + gulp.src([ 'src/**/*.js', 'src/**/*.jsx', ]) .pipe(babel()) .pipe(gulp.dest('dist')); + + gutil.log('Scripts released into dist folder'); }); /** * task to initial tests using mocha */ -gulp.task('test', function() { - gulp.src([ +gulp.task('test', function(done) { + return gulp.src([ 'test/.setup.js', 'test/**/*.test.js', ]) .pipe(mocha({ require: 'babel-core/register', - })); + })) + .once('error', () => { + process.exit(1); + }); }); /**