fix: reinstate createAndFill hack, to solve unique id issue

Author: nperez0111

packages/core/src/editor/BlockNoteEditor.ts

@@ -917,6 +917,25 @@ export class BlockNoteEditor<
       );
     }
 
+    // When y-prosemirror creates an empty document, the `blockContainer` node is created with an `id` of `null`.
+    // This causes the unique id extension to generate a new id for the initial block, which is not what we want
+    // Since it will be randomly generated & cause there to be more updates to the ydoc
+    // This is a hack to make it so that anytime `schema.doc.createAndFill` is called, the initial block id is already set to "initialBlockId"
+    let cache: Node | undefined = undefined;
+    const oldCreateAndFill = this.pmSchema.nodes.doc.createAndFill;
+    this.pmSchema.nodes.doc.createAndFill = (...args: any) => {
+      if (cache) {
+        return cache;
+      }
+      const ret = oldCreateAndFill.apply(this.pmSchema.nodes.doc, args)!;
+
+      // create a copy that we can mutate (otherwise, assigning attrs is not safe and corrupts the pm state)
+      const jsonNode = ret.toJSON();
+      jsonNode.content[0].content[0].attrs.id = "initialBlockId";
+
+      cache = Node.fromJSON(this.pmSchema, jsonNode);
+      return cache;
+    };
     this.pmSchema.cached.blockNoteEditor = this;
 
     // Initialize managers

packages/core/src/extensions/Collaboration/__snapshots__/fork-yjs-snap-editor-forked.json

@@ -8,7 +8,7 @@
         "type": "text",
       },
     ],
-    "id": "3",
+    "id": "1",
     "props": {
       "backgroundColor": "default",
       "textAlignment": "left",
@@ -19,7 +19,7 @@
   {
     "children": [],
     "content": [],
-    "id": "4",
+    "id": "initialBlockId",
     "props": {
       "backgroundColor": "default",
       "textAlignment": "left",

packages/core/src/extensions/Collaboration/__snapshots__/fork-yjs-snap-editor.json

@@ -8,7 +8,7 @@
         "type": "text",
       },
     ],
-    "id": "1",
+    "id": "0",
     "props": {
       "backgroundColor": "default",
       "textAlignment": "left",
@@ -19,7 +19,7 @@
   {
     "children": [],
     "content": [],
-    "id": "2",
+    "id": "initialBlockId",
     "props": {
       "backgroundColor": "default",
       "textAlignment": "left",

packages/core/src/extensions/Collaboration/__snapshots__/fork-yjs-snap-forked.html

@@ -1 +1 @@
-<blockgroup><blockcontainer id="3"><paragraph backgroundColor="default" textAlignment="left" textColor="default">Hello World</paragraph></blockcontainer><blockcontainer id="4"><paragraph backgroundColor="default" textAlignment="left" textColor="default"></paragraph></blockcontainer></blockgroup>
+<blockgroup><blockcontainer id="1"><paragraph backgroundColor="default" textAlignment="left" textColor="default">Hello World</paragraph></blockcontainer><blockcontainer id="initialBlockId"><paragraph backgroundColor="default" textAlignment="left" textColor="default"></paragraph></blockcontainer></blockgroup>

packages/core/src/extensions/Collaboration/__snapshots__/fork-yjs-snap.html

@@ -1 +1 @@
-<blockgroup><blockcontainer id="1"><paragraph backgroundColor="default" textAlignment="left" textColor="default">Hello</paragraph></blockcontainer><blockcontainer id="2"><paragraph backgroundColor="default" textAlignment="left" textColor="default"></paragraph></blockcontainer></blockgroup>
+<blockgroup><blockcontainer id="0"><paragraph backgroundColor="default" textAlignment="left" textColor="default">Hello</paragraph></blockcontainer><blockcontainer id="initialBlockId"><paragraph backgroundColor="default" textAlignment="left" textColor="default"></paragraph></blockcontainer></blockgroup>

packages/core/src/extensions/UniqueID/UniqueID.ts

@@ -130,18 +130,10 @@ const UniqueID = Extension.create({
   addProseMirrorPlugins() {
     let dragSourceElement: any = null;
     let transformPasted = false;
-    let isFirstCollaborationTransaction = true;
     return [
       new Plugin({
         key: new PluginKey("uniqueID"),
         appendTransaction: (transactions, oldState, newState) => {
-          if (
-            isFirstCollaborationTransaction &&
-            transactions.some((tr) => tr.getMeta("y-sync$"))
-          ) {
-            isFirstCollaborationTransaction = false;
-            return;
-          }
           const docChanges =
             transactions.some((transaction) => transaction.docChanged) &&
             !oldState.doc.eq(newState.doc);