fix: make asset links in the example bundle relative with vite

activescott · activescott · commit 37e5ec1e9c84 · 2025-01-31T11:46:12.000-08:00
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -14,6 +14,12 @@ concurrency:
 jobs:
   build:
     runs-on: ubuntu-latest
+    # permissions on the GITHUB_TOKEN for semantic-release
+    # see https://github.com/semantic-release/semantic-release/blob/master/docs/recipes/ci-configurations/github-actions.md
+    permissions:
+      contents: write # to be able to publish a GitHub release
+      issues: write # to be able to comment on released issues
+      pull-requests: write # to be able to comment on released pull requests
 
     steps:
       - uses: actions/checkout@v4
@@ -30,6 +36,13 @@ jobs:
         with:
           path: "./apps/browser-example/dist/"
 
+      # do the semantic-release release notes
+      - env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          # TODO: NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+        run: |
+          npx semantic-release@24
+
   pages:
     needs: build
     runs-on: ubuntu-latest
@@ -45,19 +58,3 @@ jobs:
       # https://github.com/actions/deploy-pages & https://github.com/actions/starter-workflows/blob/main/pages/static.yml
       - uses: actions/deploy-pages@v4
         id: deployment
-
-  release:
-    needs: build
-    runs-on: ubuntu-latest
-    # permissions on the GITHUB_TOKEN to allow deployment to GitHub Pages and for semantic-release
-    permissions:
-      contents: write # to be able to publish a GitHub release
-      issues: write # to be able to comment on released issues
-      pull-requests: write # to be able to comment on released pull requests
-      id-token: write # to enable use of OIDC for npm provenance and github pages publishing
-    steps:
-      - env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          # TODO: NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
-        run: |
-          npx semantic-release@24
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-# tsorta: TypeScript OpenAPI Realtime API
+# tsorta: TypeScript OpenAI Realtime API
 
 This repo is for an article I've written about how to use the OpenAI Realtime API with TypeScript + React and WebRTC.
 It is a working example that you can experience the Realtime API with yourself. The WebRTC client also does some heavy lifting around managing the conversation state and audio streams.
diff --git a/apps/browser-example/index.html b/apps/browser-example/index.html
@@ -1,10 +1,10 @@
-<!doctype html>
+<!DOCTYPE html>
 <html lang="en">
   <head>
     <meta charset="UTF-8" />
     <link rel="icon" type="image/svg+xml" href="/vite.svg" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <title>Vite + React + TS</title>
+    <title>TypeScript with OpenAI Realtime API</title>
   </head>
   <body>
     <div id="root"></div>
diff --git a/apps/browser-example/vite.config.ts b/apps/browser-example/vite.config.ts
@@ -3,6 +3,7 @@ import react from "@vitejs/plugin-react"
 
 // https://vite.dev/config/
 export default defineConfig({
+  base: "", // This makes Vite use relative paths
   plugins: [react()],
   css: {
     // https://vite.dev/config/shared-options.html#css-preprocessoroptions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# tsorta: TypeScript OpenAPI Realtime API`
	`1`	`+# tsorta: TypeScript OpenAI Realtime API`
`2`	`2`
`3`	`3`	`This repo is for an article I've written about how to use the OpenAI Realtime API with TypeScript + React and WebRTC.`
`4`	`4`	`It is a working example that you can experience the Realtime API with yourself. The WebRTC client also does some heavy lifting around managing the conversation state and audio streams.`