fix to be tested

Author: LFDanLu

packages/@internationalized/date/src/CalendarDate.ts

@@ -64,14 +64,17 @@ export class CalendarDate {
   constructor(calendar: Calendar, year: number, month: number, day: number, constrainDay?: boolean);
   constructor(calendar: Calendar, era: string, year: number, month: number, day: number, constrainDay?: boolean);
   constructor(...args: any[]) {
-    let [calendar, era, year, month, day, constrainDay] = shiftArgs(args);
+    let [calendar, era, year, month, day] = shiftArgs(args);
+
     this.calendar = calendar;
     this.era = era;
     this.year = year;
     this.month = month;
     this.day = day;
+    // TODO: naive fix, ideally should just grab from shiftArgs
+    let shouldConstraint = typeof args.at(-1) === 'boolean' ? args.at(-1) : undefined;
 
-    constrain(this, constrainDay);
+    constrain(this, shouldConstraint);
   }
 
   /** Returns a copy of this date. */
@@ -373,14 +376,14 @@ export class ZonedDateTime {
   }
 
   /** Returns a new `ZonedDateTime` with the given fields set to the provided values. Other fields will be constrained accordingly. */
-  set(fields: DateFields & TimeFields, value?: Disambiguation | boolean): ZonedDateTime { 
+  set(fields: DateFields & TimeFields, value?: Disambiguation | boolean): ZonedDateTime {
     let disambiguation, constrainDay = false;
     if (value && typeof value === 'string') {
       disambiguation = value;
     } else if (value && typeof value === 'boolean') {
       constrainDay = value;
     }
-    return setZoned(this, fields, disambiguation, constrainDay); 
+    return setZoned(this, fields, disambiguation, constrainDay);
   }
 
 

packages/@internationalized/date/tests/manipulation.test.js

@@ -524,12 +524,12 @@ describe('CalendarDate manipulation', function () {
 
     it('should constrain month', function () {
       let date = new CalendarDate(2020, 2, 3);
-      expect(date.set({month: 13})).toEqual(new CalendarDate(2020, 12, 3));
+      expect(date.set({month: 13}, true)).toEqual(new CalendarDate(2020, 12, 3));
     });
 
     it('should set month and constrain day', function () {
       let date = new CalendarDate(2020, 8, 31);
-      expect(date.set({month: 9})).toEqual(new CalendarDate(2020, 9, 30));
+      expect(date.set({month: 9}, true)).toEqual(new CalendarDate(2020, 9, 30));
     });
 
     it('should set day', function () {
@@ -539,12 +539,12 @@ describe('CalendarDate manipulation', function () {
 
     it('should constrain day', function () {
       let date = new CalendarDate(2020, 9, 3);
-      expect(date.set({day: 31})).toEqual(new CalendarDate(2020, 9, 30));
+      expect(date.set({day: 31}, true)).toEqual(new CalendarDate(2020, 9, 30));
     });
 
     it('should constrain day on leap years', function () {
       let date = new CalendarDate(2020, 2, 3);
-      expect(date.set({day: 31})).toEqual(new CalendarDate(2020, 2, 29));
+      expect(date.set({day: 31}, true)).toEqual(new CalendarDate(2020, 2, 29));
 
       date = new CalendarDate(2019, 2, 3);
       expect(date.set({day: 31})).toEqual(new CalendarDate(2019, 2, 28));
@@ -553,7 +553,7 @@ describe('CalendarDate manipulation', function () {
     describe('Japanese calendar', function () {
       it('should constrain date in era', function () {
         let date = new CalendarDate(new JapaneseCalendar(), 'heisei', 30, 4, 30);
-        expect(date.set({year: 35})).toEqual(new CalendarDate(new JapaneseCalendar(), 'heisei', 31, 4, 30));
+        expect(date.set({year: 35}, true)).toEqual(new CalendarDate(new JapaneseCalendar(), 'heisei', 31, 4, 30));
 
         date = new CalendarDate(new JapaneseCalendar(), 'showa', 63, 1, 6);
         expect(date.set({year: 72})).toEqual(new CalendarDate(new JapaneseCalendar(), 'showa', 64, 1, 6));
@@ -578,7 +578,7 @@ describe('CalendarDate manipulation', function () {
     describe('Taiwan calendar', function () {
       it('should constrain year in era', function () {
         let date = new CalendarDate(new TaiwanCalendar(), 'before_minguo', 5, 4, 30);
-        expect(date.set({year: -2})).toEqual(new CalendarDate(new TaiwanCalendar(), 'before_minguo', 1, 4, 30));
+        expect(date.set({year: -2}, true)).toEqual(new CalendarDate(new TaiwanCalendar(), 'before_minguo', 1, 4, 30));
       });
     });
   });