Merge pull request #155 from rashiq/master

Some little things

Author: android10

data/src/main/java/com/fernandocejas/android10/sample/data/cache/UserCacheImpl.java

@@ -80,10 +80,10 @@ public UserCacheImpl(Context context, JsonSerializer userCacheSerializer,
 
   @Override public void put(UserEntity userEntity) {
     if (userEntity != null) {
-      File userEntitiyFile = this.buildFile(userEntity.getUserId());
+      File userEntityFile = this.buildFile(userEntity.getUserId());
       if (!isCached(userEntity.getUserId())) {
         String jsonString = this.serializer.serialize(userEntity);
-        this.executeAsynchronously(new CacheWriter(this.fileManager, userEntitiyFile,
+        this.executeAsynchronously(new CacheWriter(this.fileManager, userEntityFile,
             jsonString));
         setLastCacheUpdateTimeMillis();
       }

data/src/main/java/com/fernandocejas/android10/sample/data/repository/UserDataRepository.java

@@ -47,18 +47,14 @@ public UserDataRepository(UserDataStoreFactory dataStoreFactory,
     this.userEntityDataMapper = userEntityDataMapper;
   }
 
-  @SuppressWarnings("Convert2MethodRef")
   @Override public Observable<List<User>> users() {
     //we always get all users from the cloud
     final UserDataStore userDataStore = this.userDataStoreFactory.createCloudDataStore();
-    return userDataStore.userEntityList()
-        .map(userEntities -> this.userEntityDataMapper.transform(userEntities));
+    return userDataStore.userEntityList().map(this.userEntityDataMapper::transform);
   }
 
-  @SuppressWarnings("Convert2MethodRef")
   @Override public Observable<User> user(int userId) {
     final UserDataStore userDataStore = this.userDataStoreFactory.create(userId);
-    return userDataStore.userEntityDetails(userId)
-        .map(userEntity -> this.userEntityDataMapper.transform(userEntity));
+    return userDataStore.userEntityDetails(userId).map(this.userEntityDataMapper::transform);
   }
 }

data/src/main/java/com/fernandocejas/android10/sample/data/repository/datasource/UserDataStoreFactory.java

@@ -16,6 +16,7 @@
 package com.fernandocejas.android10.sample.data.repository.datasource;
 
 import android.content.Context;
+import android.support.annotation.NonNull;
 import com.fernandocejas.android10.sample.data.cache.UserCache;
 import com.fernandocejas.android10.sample.data.entity.mapper.UserEntityJsonMapper;
 import com.fernandocejas.android10.sample.data.net.RestApi;
@@ -33,10 +34,7 @@ public class UserDataStoreFactory {
   private final UserCache userCache;
 
   @Inject
-  public UserDataStoreFactory(Context context, UserCache userCache) {
-    if (context == null || userCache == null) {
-      throw new IllegalArgumentException("Constructor parameters cannot be null!!!");
-    }
+  public UserDataStoreFactory(@NonNull Context context, @NonNull UserCache userCache) {
     this.context = context.getApplicationContext();
     this.userCache = userCache;
   }

domain/src/main/java/com/fernandocejas/android10/sample/domain/interactor/UseCase.java

@@ -52,15 +52,15 @@ protected UseCase(ThreadExecutor threadExecutor,
   /**
    * Executes the current use case.
    *
-   * @param UseCaseSubscriber The guy who will be listen to the observable build
+   * @param useCaseSubscriber The guy who will be listen to the observable build
    * with {@link #buildUseCaseObservable()}.
    */
   @SuppressWarnings("unchecked")
-  public void execute(Subscriber UseCaseSubscriber) {
+  public void execute(Subscriber useCaseSubscriber) {
     this.subscription = this.buildUseCaseObservable()
         .subscribeOn(Schedulers.from(threadExecutor))
         .observeOn(postExecutionThread.getScheduler())
-        .subscribe(UseCaseSubscriber);
+        .subscribe(useCaseSubscriber);
   }
 
   /**

presentation/src/main/java/com/fernandocejas/android10/sample/presentation/view/activity/BaseActivity.java

@@ -41,7 +41,7 @@ protected void addFragment(int containerViewId, Fragment fragment) {
    * @return {@link com.fernandocejas.android10.sample.presentation.internal.di.components.ApplicationComponent}
    */
   protected ApplicationComponent getApplicationComponent() {
-    return ((AndroidApplication)getApplication()).getApplicationComponent();
+    return ((AndroidApplication) getApplication()).getApplicationComponent();
   }
 
   /**