fix(aria/combobox): readonly esc behavior

Author: wagnermaciel

src/aria/combobox/combobox.spec.ts

@@ -550,13 +550,13 @@ describe('Combobox', () => {
         expect(inputElement.getAttribute('aria-expanded')).toBe('false');
       });
 
-      it('should clear selection on escape when closed', () => {
+      it('should NOT clear selection on escape when closed', () => {
         focus();
         down();
         enter();
         expect(inputElement.value).toBe('Alabama');
         escape();
-        expect(inputElement.value).toBe('');
+        expect(inputElement.value).toBe('Alabama');
       });
     });
 
@@ -1114,7 +1114,7 @@ describe('Combobox', () => {
         expect(inputElement.getAttribute('aria-expanded')).toBe('false');
       });
 
-      it('should clear selection on escape when closed', () => {
+      it('should NOT clear selection on escape when closed', () => {
         focus();
         down();
         right();
@@ -1123,7 +1123,7 @@ describe('Combobox', () => {
         expect(inputElement.value).toBe('December');
         expect(inputElement.getAttribute('aria-expanded')).toBe('false');
         escape();
-        expect(inputElement.value).toBe('');
+        expect(inputElement.value).toBe('December');
       });
     });
   });

src/aria/private/combobox/combobox.spec.ts

@@ -604,14 +604,14 @@ describe('Combobox with Listbox Pattern', () => {
       expect(combobox.expanded()).toBe(false);
     });
 
-    it('should clear selection on escape when already closed', () => {
+    it('should NOT clear selection on escape when already closed', () => {
       const {combobox, listbox} = getPatterns({readonly: true});
       combobox.onPointerup(clickOption(listbox.inputs.items(), 2));
       expect(listbox.getSelectedItem()).toBe(listbox.inputs.items()[2]);
       expect(listbox.inputs.value()).toEqual(['Banana']);
       combobox.onKeydown(escape());
-      expect(listbox.getSelectedItem()).toBe(undefined);
-      expect(listbox.inputs.value()).toEqual([]);
+      expect(listbox.getSelectedItem()).toBe(listbox.inputs.items()[2]);
+      expect(listbox.inputs.value()).toEqual(['Banana']);
     });
   });
 });
@@ -943,16 +943,16 @@ describe('Combobox with Tree Pattern', () => {
       expect(combobox.expanded()).toBe(false);
     });
 
-    it('should clear selection on escape when already closed', () => {
+    it('should NOT clear selection on escape when already closed', () => {
       const {combobox, tree, inputEl} = getPatterns({readonly: true});
       combobox.onPointerup(clickInput(inputEl));
       combobox.onPointerup(clickTreeItem(tree.inputs.allItems(), 0));
       expect(tree.inputs.value()).toEqual(['Fruit']);
       expect(inputEl.value).toBe('Fruit');
       expect(combobox.expanded()).toBe(false);
       combobox.onKeydown(escape());
-      expect(tree.inputs.value()).toEqual([]);
-      expect(inputEl.value).toBe('');
+      expect(tree.inputs.value()).toEqual(['Fruit']);
+      expect(inputEl.value).toBe('Fruit');
     });
   });
 });

src/aria/private/combobox/combobox.ts

@@ -383,7 +383,7 @@ export class ComboboxPattern<T extends ListItem<V>, V> {
 
     const popupControls = this.inputs.popupControls();
 
-    if (!this.expanded()) {
+    if (!this.expanded() && !this.readonly()) {
       this.inputs.inputValue?.set('');
       popupControls?.clearSelection();