Skip to content

Commit 9450c33

Browse files
authored
refactor: disambiguate project testing with serve testing (#126)
Right now it's easy to think project tests are running, while actually the served app is being tested.
1 parent 62612de commit 9450c33

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

runner/orchestration/build-serve-test-loop.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ export async function attemptBuildAndTest(
184184
testRepairAttempts++;
185185
progress.log(
186186
rootPromptDef,
187-
'test',
187+
'project-test',
188188
`Trying to repair test failures (attempt #${attemptId})...`,
189189
);
190190

runner/orchestration/serve-testing-worker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export async function serveAndTestApp(
2525
progress: ProgressLogger,
2626
userJourneyAgentTaskInput?: BrowserAgentTaskInput,
2727
): Promise<ServeTestingResult> {
28-
progress.log(rootPromptDef, 'serve-testing', `Testing the app`);
28+
progress.log(rootPromptDef, 'serve-testing', `Validating the running app`);
2929

3030
const result = await env.executor.serveWebApplication(
3131
evalID,

runner/orchestration/test-worker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export async function runTest(
1313
workerConcurrencyQueue: PQueue,
1414
progress: ProgressLogger,
1515
): Promise<TestExecutionResult | null> {
16-
progress.log(rootPromptDef, 'test', `Running tests`);
16+
progress.log(rootPromptDef, 'project-test', `Running project tests`);
1717

1818
try {
1919
const result = await env.executor.executeProjectTests(

runner/progress/dynamic-progress-logger.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ export class DynamicProgressLogger implements ProgressLogger {
148148
switch (type) {
149149
case 'success':
150150
case 'serve-testing':
151-
case 'test':
151+
case 'project-test':
152152
case 'build':
153153
return chalk.green;
154154
case 'error':

runner/progress/progress-logger.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {AssessmentResult, RootPromptDefinition} from '../shared-interfaces.js';
55
export type ProgressType =
66
| 'codegen'
77
| 'build'
8-
| 'test'
8+
| 'project-test'
99
| 'serve-testing'
1010
| 'success'
1111
| 'error'
@@ -19,7 +19,7 @@ export function progressTypeToIcon(type: ProgressType): string {
1919
return '🤖';
2020
case 'build':
2121
return '🔨';
22-
case 'test':
22+
case 'project-test':
2323
return '🧪';
2424
case 'serve-testing':
2525
return '🌊';

0 commit comments

Comments
 (0)