Merge pull request #19 from arduino/issue_795

fix: make example code optional for brick example details endpoint request

Author: mirkoCrobu

internal/store/store.go

@@ -99,6 +99,9 @@ func (s *StaticStore) GetBrickCodeExamplesPathFromID(brickID string) (paths.Path
 	targetDir := paths.New(s.codeExamplesPath, namespace, brickName)
 	dirEntries, err := targetDir.ReadDir()
 	if err != nil {
+		if errors.Is(err, os.ErrNotExist) {
+			return nil, nil
+		}
 		return nil, fmt.Errorf("cannot read examples directory %q: %w", targetDir, err)
 	}
 	return dirEntries, nil

internal/store/store_test.go

@@ -0,0 +1,146 @@
+package store
+
+import (
+	"testing"
+
+	"github.com/arduino/go-paths-helper"
+	"github.com/stretchr/testify/require"
+)
+
+const validBrickID = "arduino:arduino_cloud"
+
+func TestGetBrickReadmeFromID(t *testing.T) {
+	store := NewStaticStore(paths.New("testdata", "assets", "0.4.8").String())
+
+	testCases := []struct {
+		name        string
+		brickID     string
+		wantContent string
+		wantErr     bool
+		wantErrMsg  string
+	}{
+		{
+			name:        "Success - file found",
+			brickID:     validBrickID,
+			wantContent: "## Readme test file",
+			wantErr:     false,
+		},
+		{
+			name:        "Failure - file not found",
+			brickID:     "namespace:non_existent_brick",
+			wantContent: "",
+			wantErr:     true,
+			wantErrMsg:  "open testdata/assets/0.4.8/docs/namespace/non_existent_brick/README.md: no such file or directory",
+		},
+		{
+			name:        "Failure - invalid ID",
+			brickID:     "invalid-id",
+			wantContent: "",
+			wantErr:     true,
+			wantErrMsg:  "invalid ID",
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			content, err := store.GetBrickReadmeFromID(tc.brickID)
+			if tc.wantErr {
+				require.Error(t, err, "should have returned an error")
+				if tc.wantErrMsg != "" {
+					require.EqualError(t, err, tc.wantErrMsg, "error message mismatch")
+				}
+			} else {
+				require.NoError(t, err, "should not have returned an error")
+			}
+			require.Equal(t, tc.wantContent, content, "content mismatch")
+		})
+	}
+}
+
+func TestGetBrickComposeFilePathFromID(t *testing.T) {
+	store := NewStaticStore(paths.New("testdata", "assets", "0.4.8").String())
+
+	testCases := []struct {
+		name       string
+		brickID    string
+		wantPath   string
+		wantErr    bool
+		wantErrMsg string
+	}{
+		{
+			name:     "Success - valid ID",
+			brickID:  validBrickID,
+			wantPath: "testdata/assets/0.4.8/compose/arduino/arduino_cloud/brick_compose.yaml",
+			wantErr:  false,
+		},
+		{
+			name:       "Failure - invalid ID",
+			brickID:    "invalid ID",
+			wantPath:   "",
+			wantErr:    true,
+			wantErrMsg: "invalid ID",
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			path, err := store.GetBrickComposeFilePathFromID(tc.brickID)
+			if tc.wantErr {
+				require.Error(t, err, "function was expected to return an error")
+				require.Nil(t, path, "path was expected to be nil")
+				require.EqualError(t, err, tc.wantErrMsg, "error message mismatch")
+			} else {
+				require.NoError(t, err, "function was not expected to return an error")
+				require.NotNil(t, path, "path was expected to be not nil")
+				require.Equal(t, tc.wantPath, path.String(), "path string mismatch")
+			}
+		})
+	}
+}
+
+func TestGetBrickCodeExamplesPathFromID(t *testing.T) {
+	store := NewStaticStore(paths.New("testdata", "assets", "0.4.8").String())
+
+	testCases := []struct {
+		name           string
+		brickID        string
+		wantEntryCount int
+		wantErr        string
+	}{
+		{
+			name:           "Success - directory found",
+			brickID:        validBrickID,
+			wantEntryCount: 2,
+			wantErr:        "",
+		},
+		{
+			name:           "Success - directory not found",
+			brickID:        "namespace:non_existent_brick",
+			wantEntryCount: 0,
+			wantErr:        "",
+		},
+		{
+			name:           "Failure - invalid ID",
+			brickID:        "invalid-id",
+			wantEntryCount: 0,
+			wantErr:        "invalid ID",
+		},
+	}
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			pathList, err := store.GetBrickCodeExamplesPathFromID(tc.brickID)
+			if tc.wantErr != "" {
+				require.Error(t, err, "should have returned an error")
+				require.EqualError(t, err, tc.wantErr, "error message mismatch")
+			} else {
+				require.NoError(t, err, "should not have returned an error")
+			}
+			if tc.wantEntryCount == 0 {
+				require.Nil(t, pathList, "pathList should be nil")
+			} else {
+				require.NotNil(t, pathList, "pathList should not be nil")
+			}
+			require.Equal(t, tc.wantEntryCount, len(pathList), "entry count mismatch")
+		})
+	}
+}

internal/store/testdata/assets/0.4.8/compose/arduino/arduino_cloud/brick_compose.yaml

@@ -0,0 +1 @@
+## brick compose test file

internal/store/testdata/assets/0.4.8/docs/arduino/arduino_cloud/README.md

@@ -0,0 +1 @@
+## Readme test file

internal/store/testdata/assets/0.4.8/examples/arduino/arduino_cloud/example_1.py

@@ -0,0 +1 @@
+# test file 1

internal/store/testdata/assets/0.4.8/examples/arduino/arduino_cloud/example_2.py

@@ -0,0 +1 @@
+#test file 2