rename variable name

Author: mirkoCrobu

internal/orchestrator/bricks/bricks.go

@@ -129,9 +129,9 @@ func (s *Service) AppBrickInstanceDetails(a *app.ArduinoApp, brickID string) (Br
 
 func getBrickConfigDetails(
 	brick *bricksindex.Brick, userVariables map[string]string,
-) (map[string]string, []BrickInstanceVariable) {
+) (map[string]string, []BrickConfigVariable) {
 	variablesMap := make(map[string]string, len(brick.Variables))
-	variableDetails := make([]BrickInstanceVariable, 0, len(brick.Variables))
+	variableDetails := make([]BrickConfigVariable, 0, len(brick.Variables))
 
 	for _, v := range brick.Variables {
 		finalValue := v.DefaultValue
@@ -142,7 +142,7 @@ func getBrickConfigDetails(
 		}
 		variablesMap[v.Name] = finalValue
 
-		variableDetails = append(variableDetails, BrickInstanceVariable{
+		variableDetails = append(variableDetails, BrickConfigVariable{
 			Name:        v.Name,
 			Value:       finalValue,
 			Description: v.Description,

internal/orchestrator/bricks/bricks_test.go

@@ -116,7 +116,7 @@ func TestGetBrickInstanceVariableDetails(t *testing.T) {
 		name                     string
 		brick                    *bricksindex.Brick
 		userVariables            map[string]string
-		expectedInstanceVariable []BrickInstanceVariable
+		expectedInstanceVariable []BrickConfigVariable
 		expectedVariableMap      map[string]string
 	}{
 		{
@@ -127,7 +127,7 @@ func TestGetBrickInstanceVariableDetails(t *testing.T) {
 				},
 			},
 			userVariables: map[string]string{"VAR1": "value1"},
-			expectedInstanceVariable: []BrickInstanceVariable{
+			expectedInstanceVariable: []BrickConfigVariable{
 				{Name: "VAR1", Value: "value1", Description: "desc", Required: true},
 			},
 			expectedVariableMap: map[string]string{"VAR1": "value1"},
@@ -140,7 +140,7 @@ func TestGetBrickInstanceVariableDetails(t *testing.T) {
 				},
 			},
 			userVariables: map[string]string{},
-			expectedInstanceVariable: []BrickInstanceVariable{
+			expectedInstanceVariable: []BrickConfigVariable{
 				{Name: "VAR1", Value: "", Description: "desc", Required: true},
 			},
 			expectedVariableMap: map[string]string{"VAR1": ""},
@@ -153,7 +153,7 @@ func TestGetBrickInstanceVariableDetails(t *testing.T) {
 				},
 			},
 			userVariables: map[string]string{},
-			expectedInstanceVariable: []BrickInstanceVariable{
+			expectedInstanceVariable: []BrickConfigVariable{
 				{Name: "VAR1", Value: "default", Description: "desc", Required: false},
 			},
 			expectedVariableMap: map[string]string{"VAR1": "default"},
@@ -167,7 +167,7 @@ func TestGetBrickInstanceVariableDetails(t *testing.T) {
 				},
 			},
 			userVariables: map[string]string{"VAR1": "v1"},
-			expectedInstanceVariable: []BrickInstanceVariable{
+			expectedInstanceVariable: []BrickConfigVariable{
 				{Name: "VAR1", Value: "v1", Description: "desc1", Required: true},
 				{Name: "VAR2", Value: "def2", Description: "desc2", Required: false},
 			},
@@ -177,7 +177,7 @@ func TestGetBrickInstanceVariableDetails(t *testing.T) {
 			name:                     "no variables",
 			brick:                    &bricksindex.Brick{Variables: []bricksindex.BrickVariable{}},
 			userVariables:            map[string]string{},
-			expectedInstanceVariable: []BrickInstanceVariable{},
+			expectedInstanceVariable: []BrickConfigVariable{},
 			expectedVariableMap:      map[string]string{},
 		},
 	}

internal/orchestrator/bricks/types.go

@@ -34,17 +34,17 @@ type AppBrickInstancesResult struct {
 }
 
 type BrickInstance struct {
-	ID              string                  `json:"id"`
-	Name            string                  `json:"name"`
-	Author          string                  `json:"author"`
-	Category        string                  `json:"category"`
-	Status          string                  `json:"status"`
-	Variables       map[string]string       `json:"variables,omitempty" description:"Deprecated: use config_variables instead. This field is kept for backward compatibility."`
-	ConfigVariables []BrickInstanceVariable `json:"config_variables,omitempty"`
-	ModelID         string                  `json:"model,omitempty"`
+	ID              string                `json:"id"`
+	Name            string                `json:"name"`
+	Author          string                `json:"author"`
+	Category        string                `json:"category"`
+	Status          string                `json:"status"`
+	Variables       map[string]string     `json:"variables,omitempty" description:"Deprecated: use config_variables instead. This field is kept for backward compatibility."`
+	ConfigVariables []BrickConfigVariable `json:"config_variables,omitempty"`
+	ModelID         string                `json:"model,omitempty"`
 }
 
-type BrickInstanceVariable struct {
+type BrickConfigVariable struct {
 	Name        string `json:"name"`
 	Value       string `json:"value"`
 	Description string `json:"description"`