feat(tests): update BrickCreate tests and add dummy app configurations

Author: dido18

internal/orchestrator/bricks/bricks_test.go

@@ -16,8 +16,6 @@
 package bricks
 
 import (
-	"fmt"
-	"math/rand"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -34,7 +32,7 @@ func TestBrickCreate(t *testing.T) {
 	brickService := NewService(nil, bricksIndex, nil)
 
 	t.Run("fails if brick id does not exist", func(t *testing.T) {
-		err = brickService.BrickCreate(BrickCreateUpdateRequest{ID: "not-existing-id"}, f.Must(app.Load("./testdata/my-app")))
+		err = brickService.BrickCreate(BrickCreateUpdateRequest{ID: "not-existing-id"}, f.Must(app.Load("testdata/dummy-app")))
 		require.Error(t, err)
 		require.Equal(t, "brick 'not-existing-id' not found", err.Error())
 	})
@@ -43,7 +41,7 @@ func TestBrickCreate(t *testing.T) {
 		req := BrickCreateUpdateRequest{ID: "arduino:arduino_cloud", Variables: map[string]string{
 			"NON_EXISTING_VARIABLE": "some-value",
 		}}
-		err = brickService.BrickCreate(req, f.Must(app.Load("./testdata/my-app")))
+		err = brickService.BrickCreate(req, f.Must(app.Load("testdata/dummy-app")))
 		require.Error(t, err)
 		require.Equal(t, "variable 'NON_EXISTING_VARIABLE' does not exist on brick 'arduino:arduino_cloud'", err.Error())
 	})
@@ -53,7 +51,7 @@ func TestBrickCreate(t *testing.T) {
 			"ARDUINO_DEVICE_ID": "",
 			"ARDUINO_SECRET":    "a-secret-a",
 		}}
-		err = brickService.BrickCreate(req, f.Must(app.Load("./testdata/my-app")))
+		err = brickService.BrickCreate(req, f.Must(app.Load("testdata/dummy-app")))
 		require.Error(t, err)
 		require.Equal(t, "variable 'ARDUINO_DEVICE_ID' cannot be empty", err.Error())
 	})
@@ -62,7 +60,7 @@ func TestBrickCreate(t *testing.T) {
 		req := BrickCreateUpdateRequest{ID: "arduino:arduino_cloud", Variables: map[string]string{
 			"ARDUINO_SECRET": "a-secret-a",
 		}}
-		err = brickService.BrickCreate(req, f.Must(app.Load("./testdata/my-app")))
+		err = brickService.BrickCreate(req, f.Must(app.Load("testdata/dummy-app")))
 		require.Error(t, err)
 		require.Equal(t, "required variable 'ARDUINO_DEVICE_ID' is mandatory", err.Error())
 	})
@@ -71,18 +69,23 @@ func TestBrickCreate(t *testing.T) {
 		req := BrickCreateUpdateRequest{ID: "arduino:dbstorage_sqlstore"}
 		// TODO: find a better way to test if the brick has been added to the app.yaml
 		// Currently we only check that there is no error since the app.yaml is populated with the brick at every test execution.
-		err = brickService.BrickCreate(req, f.Must(app.Load("./testdata/my-app")))
+		err = brickService.BrickCreate(req, f.Must(app.Load("testdata/dummy-app")))
 		require.Nil(t, err)
 	})
 }
 
 func TestOverrideBrickVariablesOfApp(t *testing.T) {
+	appWithOverride := paths.New("testdata/my-app.override")
+	appWithOverride.RemoveAll()
+
+	err := paths.New("testdata/my-app.source").CopyDirTo(appWithOverride)
+	require.Nil(t, err)
 	bricksIndex, err := bricksindex.GenerateBricksIndexFromFile(paths.New("testdata"))
 	require.Nil(t, err)
 	brickService := NewService(nil, bricksIndex, nil)
 
-	deviceID := fmt.Sprintf("my-device-id-%x", rand.Int())
-	secret := fmt.Sprintf("my-device-secret-%x", rand.Int())
+	deviceID := "this-is-a-device-id"
+	secret := "this-is-a-secret"
 
 	req := BrickCreateUpdateRequest{
 		ID: "arduino:arduino_cloud",
@@ -92,10 +95,10 @@ func TestOverrideBrickVariablesOfApp(t *testing.T) {
 		},
 	}
 
-	err = brickService.BrickCreate(req, f.Must(app.Load("./testdata/my-app")))
+	err = brickService.BrickCreate(req, f.Must(app.Load("testdata/my-app.override")))
 	require.Nil(t, err)
 
-	after, err := app.Load("./testdata/my-app")
+	after, err := app.Load("testdata/my-app.override")
 	require.Nil(t, err)
 	require.Len(t, after.Descriptor.Bricks, 1)
 	require.Equal(t, "arduino:arduino_cloud", after.Descriptor.Bricks[0].ID)

internal/orchestrator/bricks/testdata/.gitignore

@@ -0,0 +1 @@
+my-app.override/

internal/orchestrator/bricks/testdata/my-app/app.yaml renamed to internal/orchestrator/bricks/testdata/dummy-app/app.yaml

@@ -0,0 +1,9 @@
+name: Copy of Blinking LED from Arduino Cloud
+description: Control the LED from the Arduino IoT Cloud using RPC calls
+ports: []
+bricks:
+- arduino:arduino_cloud:
+    variables:
+      ARDUINO_DEVICE_ID: this-is-a-device-id
+      ARDUINO_SECRET: this-is-a-secret
+icon: ☁️

internal/orchestrator/bricks/testdata/my-app/python/main.py renamed to internal/orchestrator/bricks/testdata/dummy-app/python/main.py

@@ -0,0 +1,2 @@
+def main():
+    # empty file

internal/orchestrator/bricks/testdata/my-app.override/app.yaml

@@ -0,0 +1,6 @@
+name: Copy of Blinking LED from Arduino Cloud
+description: Control the LED from the Arduino IoT Cloud using RPC calls
+ports: []
+bricks:
+- arduino:arduino_cloud:
+icon: ☁️

internal/orchestrator/bricks/testdata/my-app.override/python/main.py

@@ -0,0 +1,2 @@
+def main():
+    # empty file