Skip to content

Commit b1ae171

Browse files
authored
[skip-changelog] fix: CI should not rely on external resources / CI CodeCov upload workaround (#3036)
* fix: CI should not rely on external resources > Retrokits-RK002:arm@1.0.6 0 B / ? 0.00% > Retrokits-RK002:arm@1.0.6 Server responded with: 403 Forbidden > Error during install: Server responded with: 403 Forbidden > ESC[90m<<< Run completed (err = exit status 1)ESC[0m > core_test.go:832: > Error Trace: /home/runner/work/arduino-cli/arduino-cli/internal/integrationtest/core/core_test.go:832 > Error: Received unexpected error: > exit status 1 > Test: TestCoreListSortedResults > --- FAIL: TestCoreListSortedResults (3.76s) * Workaround for codevcov uploader bug There is a bug in the codecov uploader that makes it fail when there are broken symlinks in the repository. We must keep this workaround until the bug is fixed: codecov/codecov-action#1890
1 parent 7b8b215 commit b1ae171

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

.github/workflows/test-go-task.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,13 @@ jobs:
204204
fi
205205
echo "CODECOV_TOKEN=$CODECOV_TOKEN" >> "$GITHUB_ENV"
206206
207+
# There is a bug in the codecov uploader that makes it fail when there are broken symlinks in the repository.
208+
# We must keep this workaround until the bug is fixed: https://github.com/codecov/codecov-action/issues/1890
209+
- name: Workaround for codecov uploader bug
210+
run: |
211+
rm internal/integrationtest/compile_4/testdata/ValidSketchWithNonInoBrokenSketchFileSymlink/other_file.c
212+
touch internal/integrationtest/compile_4/testdata/ValidSketchWithNonInoBrokenSketchFileSymlink/other_file.c
213+
207214
- name: Send unit tests coverage to Codecov
208215
uses: codecov/codecov-action@v5
209216
with:

internal/integrationtest/core/core_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -828,7 +828,7 @@ func TestCoreListSortedResults(t *testing.T) {
828828
require.NoError(t, err)
829829

830830
// install some core for testing
831-
_, _, err = cli.Run("core", "install", "test:x86@2.0.0", "Retrokits-RK002:arm", "Package:x86", "--additional-urls="+url.String())
831+
_, _, err = cli.Run("core", "install", "test:x86@2.0.0", "arduino:samd", "Package:x86", "--additional-urls="+url.String())
832832
require.NoError(t, err)
833833

834834
// list all with additional url specified

0 commit comments

Comments
 (0)