Fix monitor service id creation (#1025)

Alberto Iannaccone · web-flow · commit 726628e20c00 · 2022-06-08T17:21:26.000+02:00
diff --git a/arduino-ide-extension/src/node/arduino-firmware-uploader-impl.ts b/arduino-ide-extension/src/node/arduino-firmware-uploader-impl.ts
@@ -76,7 +76,7 @@ export class ArduinoFirmwareUploaderImpl implements ArduinoFirmwareUploader {
       fqbn: firmware.board_fqbn,
     };
     try {
-      this.monitorManager.notifyUploadStarted(board, port);
+      await this.monitorManager.notifyUploadStarted(board, port);
       output = await this.runCommand([
         'firmware',
         'flash',
diff --git a/arduino-ide-extension/src/node/monitor-manager.ts b/arduino-ide-extension/src/node/monitor-manager.ts
@@ -215,6 +215,8 @@ export class MonitorManager extends CoreClientAware {
    * @returns a unique monitor ID
    */
   private monitorID(board: Board, port: Port): MonitorID {
-    return `${board.fqbn}-${port.address}-${port.protocol}`;
+    const splitFqbn = board?.fqbn?.split(':') || [];
+    const shortenedFqbn = splitFqbn.slice(0, 3).join(':') || '';
+    return `${shortenedFqbn}-${port.address}-${port.protocol}`;
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -215,6 +215,8 @@ export class MonitorManager extends CoreClientAware {`
`215`	`215`	`* @returns a unique monitor ID`
`216`	`216`	`*/`
`217`	`217`	`private monitorID(board: Board, port: Port): MonitorID {`
`218`		- return `${board.fqbn}-${port.address}-${port.protocol}`;
	`218`	`+ const splitFqbn = board?.fqbn?.split(':') \|\| [];`
	`219`	`+ const shortenedFqbn = splitFqbn.slice(0, 3).join(':') \|\| '';`
	`220`	+ return `${shortenedFqbn}-${port.address}-${port.protocol}`;
`219`	`221`	`}`
`220`	`222`	`}`