Separate weak-node-api package (#308)

* Don't export weakNodeApiPath from host

* Move weak-node-api into its own package

* Add a podspec to weak-node-api

* Delete node-api headers from the host package

* Remove symlink restoring of weak-node-api from host

* Give preference to a Debug build of weak-node-api

* Combined two buildFeatures

* Error if weak-node-api is included outside of cmake-rn (for now)

* Temporary work-around deep-referencing into weak-node-api

* Use `find_package` instead of `include` to locate "weak-node-api"

* Updates to the package lock

* Moved weak-node-api into a peer dependency as it's supposed to be installed by the app

* Reset weak-node-api version to 0.0.1 as published

* Update readme and package description

Author: kraenhansen

.changeset/eight-walls-push.md

@@ -0,0 +1,5 @@
+---
+"react-native-node-api": patch
+---
+
+Moved weak-node-api into a separate "weak-node-api" package.

.changeset/quick-poets-greet.md

@@ -0,0 +1,7 @@
+---
+"gyp-to-cmake": minor
+"cmake-rn": minor
+"react-native-node-api": minor
+---
+
+Use `find_package` instead of `include` to locate "weak-node-api"

.changeset/spotty-beers-repeat.md

@@ -0,0 +1,5 @@
+---
+"react-native-node-api": minor
+---
+
+No longer exporting weakNodeApiPath, import from "weak-node-api" instead

.changeset/tired-words-relate.md

@@ -0,0 +1,5 @@
+---
+"weak-node-api": patch
+---
+
+Initial release!

.github/workflows/check.yml

@@ -40,9 +40,9 @@ jobs:
       - run: rustup target add x86_64-linux-android
       - run: npm ci
       - run: npm run build
-      # Bootstrap host package to get weak-node-api and ferric-example to get types
+      # Bootstrap weak-node-api and ferric-example to get types
       # TODO: Solve this by adding an option to ferric to build only types or by committing the types into the repo as a fixture for an "init" command
-      - run: npm run bootstrap --workspace react-native-node-api
+      - run: npm run bootstrap --workspace weak-node-api
       - run: npm run bootstrap --workspace @react-native-node-api/ferric-example
       - run: npm run lint
         env:
@@ -184,9 +184,8 @@ jobs:
           echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
           sudo udevadm control --reload-rules
           sudo udevadm trigger --name-match=kvm
-      - name: Build weak-node-api for all architectures
-        run: npm run build-weak-node-api:android
-        working-directory: packages/host
+      - name: Build weak-node-api for all Android architectures
+        run: npm run build-weak-node-api:android --workspace weak-node-api
       - name: Build ferric-example for all architectures
         run: npm run build -- --android
         working-directory: packages/ferric-example
@@ -239,11 +238,10 @@ jobs:
       - run: rustup toolchain install nightly --component rust-src
       - run: npm ci
       - run: npm run build
-      # Build weak-node-api for all Apple architectures
-      - run: |
-          npm run prepare-weak-node-api
-          npm run build-weak-node-api:apple
-        working-directory: packages/host
+      - name: Build weak-node-api for all Apple architectures
+        run: |
+          npm run prepare-weak-node-api --workspace weak-node-api
+          npm run build-weak-node-api:apple --workspace weak-node-api
       # Build Ferric example for all Apple architectures
       - run: npx ferric --apple
         working-directory: packages/ferric-example

.gitignore

@@ -7,3 +7,6 @@ dist/
 
 # Treading the MacOS app as ephemeral
 apps/macos-test-app
+
+# Cache used by the rust analyzer
+target/rust-analyzer/

apps/test-app/package.json

@@ -42,6 +42,7 @@
     "react": "19.1.0",
     "react-native": "0.81.4",
     "react-native-node-api": "*",
-    "react-native-test-app": "^4.4.7"
+    "react-native-test-app": "^4.4.7",
+    "weak-node-api": "*"
   }
 }

package-lock.json

@@ -6,6 +6,7 @@
   "workspaces": [
     "packages/cli-utils",
     "packages/cmake-file-api",
+    "packages/weak-node-api",
     "packages/cmake-rn",
     "packages/ferric",
     "packages/gyp-to-cmake",
@@ -66,7 +67,7 @@
     "prettier": "^3.6.2",
     "react-native": "0.81.4",
     "read-pkg": "^9.0.1",
-    "tsx": "^4.20.5",
+    "tsx": "^4.20.6",
     "typescript": "^5.8.0",
     "typescript-eslint": "^8.38.0"
   }

package.json

@@ -10,14 +10,14 @@ Android's dynamic linker imposes restrictions on the access to global symbols (s
 
 The implementation of Node-API is split between Hermes and our host package and to avoid addons having to explicitly link against either, we've introduced a `weak-node-api` library (published in `react-native-node-api` package). This library exposes only Node-API and will have its implementation injected by the host.
 
-To link against `weak-node-api` just include the CMake config exposed through `WEAK_NODE_API_CONFIG` and add `weak-node-api` to the `target_link_libraries` of the addon's library target.
+To link against `weak-node-api` just use `find_package` to import the `weak-node-api` target and add it to the `target_link_libraries` of the addon's library target.
 
 ```cmake
 cmake_minimum_required(VERSION 3.15...3.31)
 project(tests-buffers)
 
 # Defines the "weak-node-api" target
-include(${WEAK_NODE_API_CONFIG})
+find_package(weak-node-api REQUIRED CONFIG)
 
 add_library(addon SHARED addon.c)
 target_link_libraries(addon PRIVATE weak-node-api)