CLJS-2133: Invalid variadic IFn implementations now fail

revert self__ hoisting, need to emit self__ ref in variadic delegate

Author: swannodette

src/main/clojure/cljs/compiler.cljc

@@ -744,13 +744,13 @@
           mname (munge name)
           delegate-name (str mname "__delegate")]
       (emitln "(function() { ")
-      (when type
-        (emitln "var self__ = this;"))
       (emits "var " delegate-name " = function (")
       (doseq [param params]
         (emit param)
         (when-not (= param (last params)) (emits ",")))
       (emitln "){")
+      (when type
+        (emitln "var self__ = this;"))
       (when recurs (emitln "while(true){"))
       (emits expr)
       (when recurs
@@ -762,6 +762,8 @@
                                              (if variadic
                                                (concat (butlast params) ['var_args])
                                                params)) "){")
+      (when type
+        (emitln "var self__ = this;"))
       (when variadic
         (emits "var ")
         (emit (last params))

src/test/cljs/cljs/core_test.cljs

@@ -1339,6 +1339,16 @@
   (testing "Syntax quoted dotted symbol without namespace should resolve to itself"
     (is (= 'clojure.core `clojure.core))))
 
+(deftype Partial [f args]
+  IFn
+  (-invoke [_ & a]
+    (apply (apply partial f args) a)))
+
+(deftest test-cljs-2133
+  (testing "Invalid variadic IFn implementation should work"
+    (let [p (Partial. + [1])]
+      (p 2))))
+
 (comment
   ;; ObjMap
   ;; (let [ks (map (partial str "foo") (range 500))