refactor: Rename hasRationalPrimaryKey()

Author: neznaika0

system/BaseModel.php

@@ -966,7 +966,7 @@ public function insertBatch(?array $set = null, ?bool $escape = null, int $batch
      */
     public function update($id = null, $row = null): bool
     {
-        if ($this->hasRationalPrimaryKey($id)) {
+        if ($this->hasAllowedValueId($id)) {
             $id = [$id];
         }
 
@@ -1093,7 +1093,7 @@ public function updateBatch(?array $set = null, ?string $index = null, int $batc
      */
     public function delete($id = null, bool $purge = false)
     {
-        if ($this->hasRationalPrimaryKey($id)) {
+        if ($this->hasAllowedValueId($id)) {
             $id = [$id];
         }
 
@@ -1900,7 +1900,7 @@ protected function convertToReturnType(array $row, string $returnType): array|ob
      *
      * @throws InvalidArgumentException
      */
-    protected function hasRationalPrimaryKey($id): bool
+    protected function hasAllowedValueId($id): bool
     {
         if (is_bool($id)) {
             throw new InvalidArgumentException('The ID value should not be boolean.');

system/Model.php

@@ -381,7 +381,7 @@ protected function doUpdate($id = null, $row = null): bool
 
         $builder = $this->builder();
 
-        if ((is_array($id) && $id !== []) || $this->hasRationalPrimaryKey($id)) {
+        if ((is_array($id) && $id !== []) || $this->hasAllowedValueId($id)) {
             $builder = $builder->whereIn($this->table . '.' . $this->primaryKey, $id);
         }
 
@@ -409,7 +409,7 @@ protected function doDelete($id = null, bool $purge = false)
         $set     = [];
         $builder = $this->builder();
 
-        if ((is_array($id) && $id !== []) || $this->hasRationalPrimaryKey($id)) {
+        if ((is_array($id) && $id !== []) || $this->hasAllowedValueId($id)) {
             $builder = $builder->whereIn($this->primaryKey, $id);
         }
 

tests/system/Models/MiscellaneousModelTest.php

@@ -125,31 +125,31 @@ public function testEmptyDataInTransformDataToArray(): void
         $method([], 'insert');
     }
 
-    public function testHasRationalPrimaryKeyWithBoolean(): void
+    public function testHasAllowedValueIdWithBoolean(): void
     {
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessage('The ID value should not be boolean.');
 
         $this->createModel(JobModel::class);
-        $method = self::getPrivateMethodInvoker($this->model, 'hasRationalPrimaryKey');
+        $method = self::getPrivateMethodInvoker($this->model, 'hasAllowedValueId');
         $method(true); // @phpstan-ignore argument.type
     }
 
     /**
      * @param float|int|string|null $value
      */
-    #[DataProvider('provideHasRationalPrimaryKey')]
-    public function testHasRationalPrimaryKey($value, bool $expected): void
+    #[DataProvider('provideHasAllowedValueId')]
+    public function testHasAllowedValueId($value, bool $expected): void
     {
         $this->createModel(JobModel::class);
-        $method = self::getPrivateMethodInvoker($this->model, 'hasRationalPrimaryKey');
+        $method = self::getPrivateMethodInvoker($this->model, 'hasAllowedValueId');
         $this->assertSame($method($value), $expected);
     }
 
     /**
      * @return list<list<bool|float|int|string|null>>
      */
-    public static function provideHasRationalPrimaryKey(): iterable
+    public static function provideHasAllowedValueId(): iterable
     {
         return [
             [0, false],