fix: TypeError in DataCaster init

Author: neznaika0

system/DataCaster/DataCaster.php

@@ -28,6 +28,12 @@
 use CodeIgniter\Entity\Exceptions\CastException;
 use CodeIgniter\Exceptions\InvalidArgumentException;
 
+/**
+ * @template TCastHandlers of array<string, CastInterface|class-string|EntityCastInterface>
+ *
+ * @see CodeIgniter\DataCaster\DataCasterTest
+ * @see CodeIgniter\Entity\EntityTest
+ */
 final class DataCaster
 {
     /**
@@ -38,9 +44,9 @@ final class DataCaster
     private array $types = [];
 
     /**
-     * Convert handlers
+     * Convert handlers.
      *
-     * @var array<string, class-string> [type => classname]
+     * @var TCastHandlers [type => classname]
      */
     private array $castHandlers = [
         'array'     => ArrayCast::class,
@@ -59,18 +65,20 @@ final class DataCaster
     ];
 
     /**
-     * @param array<string, class-string>|null $castHandlers Custom convert handlers
-     * @param array<string, string>|null       $types        [field => type]
-     * @param object|null                      $helper       Helper object.
-     * @param bool                             $strict       Strict mode? Set to false for casts for Entity.
+     * @param TCastHandlers|null         $castHandlers Custom convert handlers
+     * @param array<string, string>|null $types        [field => type]
+     * @param object|null                $helper       Helper object.
+     * @param bool                       $strict       Strict mode? Set to false for casts for Entity.
      */
     public function __construct(
         ?array $castHandlers = null,
         ?array $types = null,
         private readonly ?object $helper = null,
         private readonly bool $strict = true,
     ) {
-        $this->castHandlers = array_merge($this->castHandlers, $castHandlers);
+        if ($castHandlers !== null && $castHandlers !== []) {
+            $this->castHandlers = array_merge($this->castHandlers, $castHandlers);
+        }
 
         if ($types !== null) {
             $this->setTypes($types);
@@ -119,6 +127,10 @@ public function setTypes(array $types): static
      */
     public function castAs(mixed $value, string $field, string $method = 'get'): mixed
     {
+        if ($method !== 'get' && $method !== 'set') {
+            throw CastException::forInvalidMethod($method);
+        }
+
         // If the type is not defined, return as it is.
         if (! isset($this->types[$field])) {
             return $value;

system/Entity/Cast/BaseCast.php

@@ -14,31 +14,15 @@
 namespace CodeIgniter\Entity\Cast;
 
 /**
- * Class BaseCast
+ * Class BaseCast.
  */
 abstract class BaseCast implements CastInterface
 {
-    /**
-     * Get
-     *
-     * @param array|bool|float|int|object|string|null $value  Data
-     * @param array                                   $params Additional param
-     *
-     * @return array|bool|float|int|object|string|null
-     */
     public static function get($value, array $params = [])
     {
         return $value;
     }
 
-    /**
-     * Set
-     *
-     * @param array|bool|float|int|object|string|null $value  Data
-     * @param array                                   $params Additional param
-     *
-     * @return array|bool|float|int|object|string|null
-     */
     public static function set($value, array $params = [])
     {
         return $value;

tests/system/DataCaster/DataCasterTest.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * This file is part of CodeIgniter 4 framework.
+ *
+ * (c) CodeIgniter Foundation <admin@codeigniter.com>
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace CodeIgniter\DataCaster;
+
+use CodeIgniter\Entity\Exceptions\CastException;
+use CodeIgniter\Test\CIUnitTestCase;
+use PHPUnit\Framework\Attributes\Group;
+
+/**
+ * @internal
+ */
+#[Group('Others')]
+final class DataCasterTest extends CIUnitTestCase
+{
+    public function testCastInvalidMethodException(): void
+    {
+        $this->expectException(CastException::class);
+        $this->expectExceptionMessage('The "add" is invalid cast method, valid methods are: ["get", "set"].');
+
+        $dataCaster = new DataCaster();
+        $dataCaster->castAs([], 'name', 'add'); // @phpstan-ignore argument.type
+    }
+}