fix(Init): raise InitFailedError on keyboard interrupt on pre-commit hook question, remove unreachable code path

Author: bearomorphism

commitizen/commands/init.py

@@ -150,9 +150,30 @@ def __call__(self) -> None:
             tag_format = self._ask_tag_format(tag)  # confirm & text
             update_changelog_on_bump = self._ask_update_changelog_on_bump()  # confirm
             major_version_zero = self._ask_major_version_zero(version)  # confirm
+            hook_types: list[str] | None = questionary.checkbox(
+                "What types of pre-commit hook you want to install? (Leave blank if you don't want to install)",
+                choices=[
+                    questionary.Choice("commit-msg", checked=False),
+                    questionary.Choice("pre-push", checked=False),
+                ],
+            ).unsafe_ask()
         except KeyboardInterrupt:
             raise InitFailedError("Stopped by user")
 
+        if hook_types:
+            config_data = self._get_config_data()
+            with smart_open(
+                self._PRE_COMMIT_CONFIG_PATH, "w", encoding=self.encoding
+            ) as config_file:
+                yaml.safe_dump(config_data, stream=config_file)
+
+            if not self.project_info.is_pre_commit_installed:
+                raise InitFailedError(
+                    "pre-commit is not installed in current environment."
+                )
+            self._exec_install_pre_commit_hook(hook_types)
+            out.write("commitizen pre-commit hook is now installed in your '.git'\n")
+
         # Initialize configuration
         if "toml" in config_path:
             self.config = TomlConfig(data="", path=config_path)
@@ -161,20 +182,6 @@ def __call__(self) -> None:
         elif "yaml" in config_path:
             self.config = YAMLConfig(data="", path=config_path)
 
-        # Collect hook data
-        hook_types = questionary.checkbox(
-            "What types of pre-commit hook you want to install? (Leave blank if you don't want to install)",
-            choices=[
-                questionary.Choice("commit-msg", checked=False),
-                questionary.Choice("pre-push", checked=False),
-            ],
-        ).unsafe_ask()
-        if hook_types:
-            try:
-                self._install_pre_commit_hook(hook_types)
-            except InitFailedError as e:
-                raise InitFailedError(f"Failed to install pre-commit hook.\n{e}")
-
         # Create and initialize config
         self.config.init_empty_config_content()
 
@@ -369,17 +376,3 @@ def _get_config_data(self) -> dict[str, Any]:
         else:
             repos.append(CZ_HOOK_CONFIG)
         return config_data
-
-    def _install_pre_commit_hook(self, hook_types: list[str] | None = None) -> None:
-        config_data = self._get_config_data()
-        with smart_open(
-            self._PRE_COMMIT_CONFIG_PATH, "w", encoding=self.encoding
-        ) as config_file:
-            yaml.safe_dump(config_data, stream=config_file)
-
-        if not self.project_info.is_pre_commit_installed:
-            raise InitFailedError("pre-commit is not installed in current environment.")
-        if hook_types is None:
-            hook_types = ["commit-msg", "pre-push"]
-        self._exec_install_pre_commit_hook(hook_types)
-        out.write("commitizen pre-commit hook is now installed in your '.git'\n")