cleanups

Author: mr-c

cwltool/errors.py

@@ -18,8 +18,10 @@ class WorkflowKillSwitch(Exception):
     """When processStatus != "success" and on-error=kill, raise this exception."""
 
     def __init__(self, job_id, rcode):
+        """Record the job identifier and the error code."""
         self.job_id = job_id
         self.rcode = rcode
 
     def __str__(self):
-        return f'[job {self.job_id}] activated kill switch with return code {self.rcode}'
+        """Represent this exception as a string."""
+        return f"[job {self.job_id}] activated kill switch with return code {self.rcode}"

cwltool/job.py

@@ -547,7 +547,8 @@ def monitor_kill_switch() -> None:
             nonlocal ks_tm
             if kill_switch.is_set():
                 _logger.error("[job %s] terminating by kill switch", self.name)
-                if sproc.stdin: sproc.stdin.close()
+                if sproc.stdin:
+                    sproc.stdin.close()
                 sproc.terminate()
             else:
                 ks_tm = Timer(interval=1, function=monitor_kill_switch)

cwltool/task_queue.py

@@ -7,8 +7,8 @@
 import threading
 from typing import Callable, Optional
 
-from .loghandler import _logger
 from .errors import WorkflowKillSwitch
+from .loghandler import _logger
 
 
 class TaskQueue: