Skip to content

Commit aaf4512

Browse files
authored
Add detailed block samples stats for partition compactor (#7095)
* add separate float and histogram samples stats in sharded block populator Signed-off-by: yeya24 <benye@amazon.com> * use errors wrapf Signed-off-by: yeya24 <benye@amazon.com> --------- Signed-off-by: yeya24 <benye@amazon.com>
1 parent f3113c9 commit aaf4512

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

pkg/compactor/sharded_block_populator.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,16 @@ func (c ShardedBlockPopulator) PopulateBlock(ctx context.Context, metrics *tsdb.
177177
meta.Stats.NumChunks += uint64(len(chks))
178178
meta.Stats.NumSeries++
179179
for _, chk := range chks {
180-
meta.Stats.NumSamples += uint64(chk.Chunk.NumSamples())
180+
samples := uint64(chk.Chunk.NumSamples())
181+
meta.Stats.NumSamples += samples
182+
switch chk.Chunk.Encoding() {
183+
case chunkenc.EncHistogram, chunkenc.EncFloatHistogram:
184+
meta.Stats.NumHistogramSamples += samples
185+
case chunkenc.EncXOR:
186+
meta.Stats.NumFloatSamples += samples
187+
default:
188+
return errors.Wrapf(err, "unknown chunk encoding %s", chk.Chunk.Encoding().String())
189+
}
181190
}
182191

183192
for _, chk := range chks {

0 commit comments

Comments
 (0)