Merge pull request #256 from db-ui/refactor-xo-feedback

refactor(xo): optimizations

Author: mfranzke

packages/components/plugins/power-apps/index.js

@@ -1,5 +1,5 @@
-const ChildProcess = require('child_process');
-const Buff = require('buffer');
+const ChildProcess = require('node:child_process');
+const Buff = require('node:buffer');
 
 module.exports = () => ({
 	json: {

packages/components/scripts/post-build/copy-files.js

@@ -2,14 +2,14 @@ const Fse = require('fs-extra');
 const Frameworks = require('./framworks');
 
 module.exports = () => {
-	[
+	for (const file of [
 		'package.json',
 		'angular.json',
 		'tsconfig.json',
 		'ng-package.json',
 		'vite.config.ts'
-	].forEach((file) => {
-		Frameworks.forEach((framework) => {
+	]) {
+		for (const framework of Frameworks) {
 			const resolvedFramework =
 				framework === 'vue' ? `vue/vue3` : framework;
 			if (
@@ -20,6 +20,6 @@ module.exports = () => {
 					`../../output/${resolvedFramework}/${file}`
 				);
 			}
-		});
-	});
+		}
+	}
 };

packages/components/scripts/post-build/react.js

@@ -6,7 +6,7 @@ module.exports = () => {
 		try {
 			const cleanName = component.name
 				.split('-')
-				.map((part) => `${part[0].toUpperCase()}${part.substring(1)}`)
+				.map((part) => `${part[0].toUpperCase()}${part.slice(1)}`)
 				.join('');
 			const stateName = `DB${cleanName}State`;
 
@@ -32,14 +32,14 @@ module.exports = () => {
 				];
 			}
 
-			replacements.forEach((replacement) => {
+			for (const replacement of replacements) {
 				const option = {
 					files: tsxFile,
 					from: replacement.from,
 					to: replacement.to
 				};
 				Replace.replaceInFileSync(option);
-			});
+			}
 		} catch (error) {
 			console.error('Error occurred:', error);
 		}

packages/components/scripts/post-build/vue.js

@@ -63,14 +63,14 @@ module.exports = () => {
 				];
 			}
 
-			replacements.forEach((replacement) => {
+			for (const replacement of replacements) {
 				const option = {
 					files: vueFile,
 					from: replacement.from,
 					to: replacement.to
 				};
 				Replace.replaceInFileSync(option);
-			});
+			}
 		} catch (error) {
 			console.error('Error occurred:', error);
 		}

packages/components/src/components/button/button.lite.tsx

@@ -1,6 +1,6 @@
 import { onMount, Show, useMetadata, useStore } from '@builder.io/mitosis';
-import type { DBButtonProps, DBButtonState } from './model';
 import { DBIcon } from '../icon';
+import type { DBButtonProps, DBButtonState } from './model';
 
 useMetadata({
 	isAttachedToShadowDom: true,

packages/components/src/components/button/model.ts

@@ -1,8 +1,8 @@
 import {
-	ClickEventProps,
-	ClickEventState,
-	GlobalProps,
-	GlobalState
+	type ClickEventProps,
+	type ClickEventState,
+	type GlobalProps,
+	type GlobalState
 } from '../../shared/model';
 
 export type DBButtonDefaultProps = {

packages/components/src/components/card/model.ts

@@ -1,9 +1,9 @@
 import {
-	ClickEventProps,
-	ClickEventState,
-	GlobalProps,
-	GlobalState,
-	ImageProps
+	type ClickEventProps,
+	type ClickEventState,
+	type GlobalProps,
+	type GlobalState,
+  type ImageProps
 } from '../../shared/model';
 
 export type DBCardDefaultProps = {

packages/components/src/components/divider/divider.lite.tsx

@@ -1,5 +1,5 @@
 import { onMount, Show, useMetadata, useStore } from '@builder.io/mitosis';
-import { DBDividerState, DBDividerProps } from './model';
+import { type DBDividerState, type DBDividerProps } from './model';
 
 useMetadata({
 	isAttachedToShadowDom: true,

packages/components/src/components/divider/model.ts

@@ -1,9 +1,9 @@
-import { GlobalProps, GlobalState } from '../../shared/model';
+import { type GlobalProps, type GlobalState } from '../../shared/model';
 
-export interface DBDividerDefaultProps {
+export type DBDividerDefaultProps = {
 	margin?: 'none' | '_';
 	variant?: 'horizontal' | 'vertical';
-}
+};
 
 export type DBDividerProps = DBDividerDefaultProps & GlobalProps;
 

packages/components/src/components/icon/model.ts

@@ -1,4 +1,4 @@
-import { GlobalProps, GlobalState } from '../../shared/model';
+import { type GlobalProps, type GlobalState } from '../../shared/model';
 
 export type DBIconDefaultProps = {
 	icon?: string;