fix _getPreSelectedTabId bug

Author: dev-javascript

src/utils/api/api.factory.js

@@ -110,10 +110,10 @@ const _apiProps = {
     return result;
   },
   _getPreSelectedTabId: function () {
-    const selectedTabHistory = this.activedTabsHistory;
+    const selectedTabHistory = [...this.activedTabsHistory.tabsId];
     let tabID = '';
-    while (!tabID && selectedTabHistory.tabsId.length) {
-      const _tabID = selectedTabHistory.popLastTabID();
+    while (!tabID && selectedTabHistory.length) {
+      const _tabID = selectedTabHistory.pop();
       if (_tabID) {
         const _tabData = this.getTab(_tabID);
         if (_tabData && !_tabData.disable && this.isOpen(_tabID) && !this.isSelected(_tabID)) tabID = _tabID;
@@ -186,7 +186,7 @@ Helper.setNoneEnumProps(_apiProps, {
       openedTabIDs.length && this.trigger('onOpen', this.userProxy, openedTabIDs);
       closedTabIDs.length && this.trigger('onClose', this.userProxy, closedTabIDs);
       if (isSwitched) {
-        if (this.activedTabsHistory.tabsId.indexOf(newState.selectedTabID) === -1) {
+        if (newState.selectedTabID && this.activedTabsHistory.tabsId.indexOf(newState.selectedTabID) === -1) {
           this.trigger('onFirstSelect', this.userProxy, {
             currentSelectedTabId: newState.selectedTabID,
             previousSelectedTabId: oldState.selectedTabID,

src/utils/api/api.factory.test.js

@@ -532,8 +532,7 @@ describe('Api.prototype._subscribeSelectedTabsHistory : ', () => {
   });
 });
 describe('Api.prototype._getPreSelectedTabId : ', () => {
-  test(`it calls activeTabsHistory.popLastTabID repeatedly until it returns a tabID 
-    which is opened, not selected and none disable`, () => {
+  test(`it should find an item from activeTabsHistory.tabsId which is opened, not selected and none disable`, () => {
     const obj = new apiConstructor(getDeps, {
       options: {
         tabs: [{id: '1'}, {id: '2'}, {id: '3'}, {id: '4'}, {id: '5'}],
@@ -545,7 +544,6 @@ describe('Api.prototype._getPreSelectedTabId : ', () => {
     obj.setTab('3', {disable: true}).setTab('4', {disable: true});
     const tabID = obj._getPreSelectedTabId();
     expect(tabID).toBe('2');
-    expect(obj.activedTabsHistory.tabsId).toEqual(['3']);
   });
   test('it should return an empty string if activedTabsHistory.tabsId is empty or does not contain any valid tabID', () => {
     obj.stateRef = {selectedTabID: 'tab1', openTabIDs: ['tab1', 'tab2']};