Fixed a bug where calling startup multiple times with a callback would reinitialize the client.

Author: niemyjski

packages/browser/src/BrowserExceptionlessClient.ts

@@ -8,11 +8,9 @@ import { BrowserRequestInfoPlugin } from "./plugins/BrowserRequestInfoPlugin.js"
 import { BrowserWrapFunctions } from "./plugins/BrowserWrapFunctions.js";
 
 export class BrowserExceptionlessClient extends ExceptionlessClient {
-  public async startup(
-    configurationOrApiKey?: (config: Configuration) => void | string,
-  ): Promise<void> {
+  public async startup(configurationOrApiKey?: (config: Configuration) => void | string): Promise<void> {
     const config = this.config;
-    if (configurationOrApiKey) {
+    if (configurationOrApiKey && !this._initialized) {
       config.useLocalStorage();
 
       config.addPlugin(new BrowserGlobalHandlerPlugin());
@@ -24,7 +22,7 @@ export class BrowserExceptionlessClient extends ExceptionlessClient {
     }
 
     await super.startup(configurationOrApiKey);
-    if (configurationOrApiKey) {
+    if (configurationOrApiKey && !this._initialized) {
       config.removePlugin(new SimpleErrorPlugin());
     }
   }

packages/core/src/ExceptionlessClient.ts

@@ -11,12 +11,14 @@ import { PluginContext } from "./plugins/PluginContext.js";
 export class ExceptionlessClient {
   private _intervalId = 0;
   private _timeoutId = 0;
+  protected _initialized = false;
 
   public constructor(public config: Configuration = new Configuration()) { }
 
   /** Resume background submission, resume any timers. */
   public async startup(configurationOrApiKey?: (config: Configuration) => void | string): Promise<void> {
-    if (configurationOrApiKey) {
+    if (configurationOrApiKey && !this._initialized) {
+      this._initialized = true;
       EventPluginManager.addDefaultPlugins(this.config);
 
       if (typeof configurationOrApiKey === "string") {
@@ -33,6 +35,7 @@ export class ExceptionlessClient {
 
     this.updateSettingsTimer(!!configurationOrApiKey);
     await EventPluginManager.startup(new PluginContext(this));
+
     const { queue } = this.config.services;
     await queue.startup();
     if (this.config.usePersistedQueueStorage) {

packages/node/src/NodeExceptionlessClient.ts

@@ -20,7 +20,7 @@ export class NodeExceptionlessClient extends ExceptionlessClient {
   public async startup(configurationOrApiKey?: (config: Configuration) => void | string): Promise<void> {
     const config = this.config;
 
-    if (configurationOrApiKey) {
+    if (configurationOrApiKey && !this._initialized) {
       if (!globalThis?.localStorage) {
         const storage = new LocalStorage(undefined, new LocalStoragePolyfill(process.cwd() + '/.exceptionless'));
         config.useLocalStorage = () => storage;
@@ -43,7 +43,7 @@ export class NodeExceptionlessClient extends ExceptionlessClient {
 
     await super.startup(configurationOrApiKey);
 
-    if (configurationOrApiKey) {
+    if (configurationOrApiKey && !this._initialized) {
       config.removePlugin(new SimpleErrorPlugin());
     }
   }