Skip to content

Commit 06e1b04

Browse files
committed
fix: fixup stings and minor errors
1 parent 42b5efd commit 06e1b04

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

analytics/src/analytics_android.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -561,6 +561,7 @@ void SetDefaultEventParameters(const Parameter* parameters,
561561
if (util::CheckAndClearJniExceptions(env)) {
562562
LogError("Failed to set default event parameters");
563563
}
564+
env->DeleteLocalRef(bundle);
564565
}
565566

566567
// Set the default event parameters

analytics/src/analytics_ios.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ void SetDefaultEventParameters(const Parameter* parameters, size_t number_of_par
334334
if (!AddVariantToDictionary(parameters_dict, parameter_name, parameter.value)) {
335335
// A Variant type that couldn't be handled was passed in.
336336
LogError("SetDefaultEventParameters(%s): %s is not a valid parameter value type. "
337-
"No event was logged.",
337+
"The parameter was not added.",
338338
parameter.name, Variant::TypeName(parameter.value.type()));
339339
}
340340
}

analytics/src/include/firebase/analytics.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -493,9 +493,7 @@ void LogEvent(const char* name, const Parameter* parameters,
493493
/// prefix is reserved and should not be used. Note that event names are
494494
/// case-sensitive and that logging two events whose names differ only in
495495
/// case will result in two distinct events.
496-
/// @param[in] parameters Array of Parameter structures.
497-
/// @param[in] number_of_parameters Number of elements in the parameters
498-
/// array.
496+
/// @param[in] parameters Vector of Parameter structures.
499497
void LogEvent(const char* name, const std::vector<Parameter>& parameters);
500498

501499
/// @brief Adds parameters that will be set on every event logged from the SDK.

app/src/util_android.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ bool LookupFieldIds(JNIEnv* env, jclass clazz,
191191

192192
// Used to populate an array of MethodNameSignature.
193193
#define METHOD_NAME_SIGNATURE_5(id, name, signature, method_type, optional) \
194-
{name, signature, method_type, optional}
194+
{ name, signature, method_type, optional }
195195
#define METHOD_NAME_SIGNATURE_4(id, name, signature, method_type) \
196196
METHOD_NAME_SIGNATURE_5( \
197197
id, name, signature, method_type, \

0 commit comments

Comments
 (0)