Merge pull request #699 from fortran-lang/gnikit/issue698

bug: internal vscode module output

Author: gnikit

CHANGELOG.md

@@ -70,6 +70,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 
+- Fixed bug where the linter's internal cache directory would not always exist
+  ([#698](https://github.com/fortran-lang/vscode-fortran-support/issues/698))
 - Fixed bugs in relative path resolution for `fortls`
   ([#693](https://github.com/fortran-lang/vscode-fortran-support/issues/693))
 - Fixed issues with linter unittests running asynchronously

src/extension.ts

@@ -47,7 +47,8 @@ export async function activate(context: vscode.ExtensionContext) {
     })
   );
   // Linter is always activated but will only lint if compiler !== Disabled
-  const linterCache = path.join(context.storageUri.fsPath);
+  const linterCache = path.join(context.storageUri.fsPath, 'include');
+  await vscode.workspace.fs.createDirectory(vscode.Uri.parse(linterCache));
   const linter = new FortranLintingProvider(logger, linterCache);
   context.subscriptions.push(...(await linter.activate()));
   vscode.languages.registerCodeActionsProvider(FortranDocumentSelector(), linter);

test/integration/lsp-client.test.ts

@@ -47,42 +47,3 @@ suite('Language Server integration tests', () => {
     strictEqual(JSON.stringify(ref), JSON.stringify(res));
   });
 });
-
-suite('Language Server integration tests', () => {
-  const server = new FortlsClient(logger);
-  const fileUri = vscode.Uri.file(path.resolve(__dirname, '../../../test/fortran/sample.f90'));
-
-  suiteSetup(async () => {
-    const doc = await vscode.workspace.openTextDocument(fileUri);
-    await vscode.window.showTextDocument(doc);
-    await server.activate();
-  });
-
-  test('Restart the Language Server', async () => {
-    await server['restartLS']();
-    await delay(6000); // wait for server to initialize
-
-    const ref = {
-      capabilities: {
-        completionProvider: {
-          resolveProvider: false,
-          triggerCharacters: ['%'],
-        },
-        definitionProvider: true,
-        documentSymbolProvider: true,
-        referencesProvider: true,
-        hoverProvider: true,
-        implementationProvider: true,
-        renameProvider: true,
-        workspaceSymbolProvider: true,
-        textDocumentSync: 2,
-        signatureHelpProvider: {
-          triggerCharacters: ['(', ','],
-        },
-        codeActionProvider: true,
-      },
-    };
-    const res = server['client']?.initializeResult;
-    strictEqual(JSON.stringify(ref), JSON.stringify(res));
-  });
-});

updates/RELEASE_NOTES-unreleased.md

@@ -207,3 +207,6 @@ which is slower but does not suffer from this issue.
 The cache used by the linter should help mitigate any performance issues.
 
 ## 🐛 Bug Fixes 🐛
+
+- Fixed bug where the linter's internal cache directory would not always exist
+  ([#698](https://github.com/fortran-lang/vscode-fortran-support/issues/698))