chore(eslint): Add eslint-plugin-regexp rule (dev-packages) (#18063)

Enabling eslint rules for RegEx in `dev-packages`.

This is a part of this (now closed) PR:
#18053

The first commit contains all changes that were automatically made with
`--fix`, the second commit contains the manual changes.

Author: s1gr1d

dev-packages/browser-integration-tests/.eslintrc.js

@@ -3,7 +3,9 @@ module.exports = {
     browser: true,
     node: true,
   },
-  extends: ['../../.eslintrc.js'],
+  // todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project
+  extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],
+  plugins: ['regexp'],
   ignorePatterns: [
     'suites/**/subject.js',
     'suites/**/dist/*',

dev-packages/browser-integration-tests/package.json

@@ -54,6 +54,7 @@
   "devDependencies": {
     "@types/glob": "8.0.0",
     "@types/node": "^18.19.1",
+    "eslint-plugin-regexp": "^1.15.0",
     "glob": "8.0.3"
   },
   "volta": {

dev-packages/browser-integration-tests/suites/manual-client/browser-context/test.ts

@@ -46,7 +46,7 @@ sentryTest('allows to setup a client manually & capture exceptions', async ({ ge
       },
     },
     contexts: {
-      trace: { trace_id: expect.stringMatching(/[a-f0-9]{32}/), span_id: expect.stringMatching(/[a-f0-9]{16}/) },
+      trace: { trace_id: expect.stringMatching(/[a-f\d]{32}/), span_id: expect.stringMatching(/[a-f\d]{16}/) },
     },
   });
 });

dev-packages/browser-integration-tests/suites/profiling/traceLifecycleMode_multiple-chunks/test.ts

@@ -58,9 +58,9 @@ sentryTest(
 
     // Required profile metadata (Sample Format V2)
     expect(typeof envelopeItemPayload1.profiler_id).toBe('string');
-    expect(envelopeItemPayload1.profiler_id).toMatch(/^[a-f0-9]{32}$/);
+    expect(envelopeItemPayload1.profiler_id).toMatch(/^[a-f\d]{32}$/);
     expect(typeof envelopeItemPayload1.chunk_id).toBe('string');
-    expect(envelopeItemPayload1.chunk_id).toMatch(/^[a-f0-9]{32}$/);
+    expect(envelopeItemPayload1.chunk_id).toMatch(/^[a-f\d]{32}$/);
     expect(envelopeItemPayload1.client_sdk).toBeDefined();
     expect(typeof envelopeItemPayload1.client_sdk.name).toBe('string');
     expect(typeof envelopeItemPayload1.client_sdk.version).toBe('string');
@@ -170,9 +170,9 @@ sentryTest(
     // Required profile metadata (Sample Format V2)
     // https://develop.sentry.dev/sdk/telemetry/profiles/sample-format-v2/
     expect(typeof envelopeItemPayload2.profiler_id).toBe('string');
-    expect(envelopeItemPayload2.profiler_id).toMatch(/^[a-f0-9]{32}$/);
+    expect(envelopeItemPayload2.profiler_id).toMatch(/^[a-f\d]{32}$/);
     expect(typeof envelopeItemPayload2.chunk_id).toBe('string');
-    expect(envelopeItemPayload2.chunk_id).toMatch(/^[a-f0-9]{32}$/);
+    expect(envelopeItemPayload2.chunk_id).toMatch(/^[a-f\d]{32}$/);
     expect(envelopeItemPayload2.client_sdk).toBeDefined();
     expect(typeof envelopeItemPayload2.client_sdk.name).toBe('string');
     expect(typeof envelopeItemPayload2.client_sdk.version).toBe('string');

dev-packages/browser-integration-tests/suites/profiling/traceLifecycleMode_overlapping-spans/test.ts

@@ -60,9 +60,9 @@ sentryTest(
     // Required profile metadata (Sample Format V2)
     // https://develop.sentry.dev/sdk/telemetry/profiles/sample-format-v2/
     expect(typeof envelopeItemPayload.profiler_id).toBe('string');
-    expect(envelopeItemPayload.profiler_id).toMatch(/^[a-f0-9]{32}$/);
+    expect(envelopeItemPayload.profiler_id).toMatch(/^[a-f\d]{32}$/);
     expect(typeof envelopeItemPayload.chunk_id).toBe('string');
-    expect(envelopeItemPayload.chunk_id).toMatch(/^[a-f0-9]{32}$/);
+    expect(envelopeItemPayload.chunk_id).toMatch(/^[a-f\d]{32}$/);
     expect(envelopeItemPayload.client_sdk).toBeDefined();
     expect(typeof envelopeItemPayload.client_sdk.name).toBe('string');
     expect(typeof envelopeItemPayload.client_sdk.version).toBe('string');
@@ -175,7 +175,7 @@ sentryTest('attaches thread data to child spans (trace mode)', async ({ page, ge
   const profilerId = rootSpan?.contexts?.profile?.profiler_id as string | undefined;
   expect(typeof profilerId).toBe('string');
 
-  expect(profilerId).toMatch(/^[a-f0-9]{32}$/);
+  expect(profilerId).toMatch(/^[a-f\d]{32}$/);
 
   const spans = (rootSpan?.spans ?? []) as Array<{ data?: Record<string, unknown> }>;
   expect(spans.length).toBeGreaterThan(0);

dev-packages/browser-integration-tests/suites/public-api/startSpan/standalone-mixed-transaction/test.ts

@@ -34,8 +34,8 @@ sentryTest(
     const traceId = transactionEnvelopeHeader.trace!.trace_id!;
     const parentSpanId = transactionEnvelopeItem.contexts?.trace?.span_id;
 
-    expect(traceId).toMatch(/[a-f0-9]{32}/);
-    expect(parentSpanId).toMatch(/[a-f0-9]{16}/);
+    expect(traceId).toMatch(/[a-f\d]{32}/);
+    expect(parentSpanId).toMatch(/[a-f\d]{16}/);
 
     expect(spanEnvelopeHeader).toEqual({
       sent_at: expect.any(String),
@@ -76,7 +76,7 @@ sentryTest(
       segment_id: transactionEnvelopeItem.contexts?.trace?.span_id,
       parent_span_id: parentSpanId,
       origin: 'manual',
-      span_id: expect.stringMatching(/[a-f0-9]{16}/),
+      span_id: expect.stringMatching(/[a-f\d]{16}/),
       start_timestamp: expect.any(Number),
       timestamp: expect.any(Number),
       trace_id: traceId,
@@ -111,7 +111,7 @@ sentryTest(
           description: 'inner',
           origin: 'manual',
           parent_span_id: parentSpanId,
-          span_id: expect.stringMatching(/[a-f0-9]{16}/),
+          span_id: expect.stringMatching(/[a-f\d]{16}/),
           start_timestamp: expect.any(Number),
           timestamp: expect.any(Number),
           trace_id: traceId,

dev-packages/browser-integration-tests/suites/public-api/startSpan/standalone/test.ts

@@ -48,10 +48,10 @@ sentryTest('sends a segment span envelope', async ({ getLocalTestUrl, page }) =>
     },
     description: 'standalone_segment_span',
     origin: 'manual',
-    span_id: expect.stringMatching(/^[0-9a-f]{16}$/),
+    span_id: expect.stringMatching(/^[\da-f]{16}$/),
     start_timestamp: expect.any(Number),
     timestamp: expect.any(Number),
-    trace_id: expect.stringMatching(/^[0-9a-f]{32}$/),
+    trace_id: expect.stringMatching(/^[\da-f]{32}$/),
     is_segment: true,
     segment_id: spanJson.span_id,
   });

dev-packages/browser-integration-tests/suites/replay/dsc/test.ts

@@ -57,7 +57,7 @@ sentryTest(
     expect(envHeader.trace).toEqual({
       environment: 'production',
       sample_rate: '1',
-      trace_id: expect.stringMatching(/[a-f0-9]{32}/),
+      trace_id: expect.stringMatching(/[a-f\d]{32}/),
       public_key: 'public',
       replay_id: replay.session?.id,
       sampled: 'true',
@@ -105,7 +105,7 @@ sentryTest(
     expect(envHeader.trace).toEqual({
       environment: 'production',
       sample_rate: '1',
-      trace_id: expect.stringMatching(/[a-f0-9]{32}/),
+      trace_id: expect.stringMatching(/[a-f\d]{32}/),
       public_key: 'public',
       sampled: 'true',
       sample_rand: expect.any(String),
@@ -158,7 +158,7 @@ sentryTest(
     expect(envHeader.trace).toEqual({
       environment: 'production',
       sample_rate: '1',
-      trace_id: expect.stringMatching(/[a-f0-9]{32}/),
+      trace_id: expect.stringMatching(/[a-f\d]{32}/),
       public_key: 'public',
       replay_id: replay.session?.id,
       sampled: 'true',
@@ -201,7 +201,7 @@ sentryTest(
     expect(envHeader.trace).toEqual({
       environment: 'production',
       sample_rate: '1',
-      trace_id: expect.stringMatching(/[a-f0-9]{32}/),
+      trace_id: expect.stringMatching(/[a-f\d]{32}/),
       public_key: 'public',
       sampled: 'true',
       sample_rand: expect.any(String),
@@ -243,7 +243,7 @@ sentryTest('should add replay_id to error DSC while replay is active', async ({
   expect(error1Header.trace).toBeDefined();
   expect(error1Header.trace).toEqual({
     environment: 'production',
-    trace_id: expect.stringMatching(/[a-f0-9]{32}/),
+    trace_id: expect.stringMatching(/[a-f\d]{32}/),
     public_key: 'public',
     replay_id: replay.session?.id,
     ...(hasTracing
@@ -265,7 +265,7 @@ sentryTest('should add replay_id to error DSC while replay is active', async ({
   expect(error2Header.trace).toBeDefined();
   expect(error2Header.trace).toEqual({
     environment: 'production',
-    trace_id: expect.stringMatching(/[a-f0-9]{32}/),
+    trace_id: expect.stringMatching(/[a-f\d]{32}/),
     public_key: 'public',
     ...(hasTracing
       ? {

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/http-timings/test.ts

@@ -34,7 +34,7 @@ sentryTest('creates fetch spans with http timing', async ({ browserName, getLoca
     expect(span).toMatchObject({
       description: `GET http://sentry-test-site.example/${index}`,
       parent_span_id: tracingEvent.contexts?.trace?.span_id,
-      span_id: expect.stringMatching(/[a-f0-9]{16}/),
+      span_id: expect.stringMatching(/[a-f\d]{16}/),
       start_timestamp: expect.any(Number),
       timestamp: expect.any(Number),
       trace_id: tracingEvent.contexts?.trace?.trace_id,

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta-negative/test.ts

@@ -60,7 +60,7 @@ sentryTest.describe('When `consistentTraceSampling` is `true` and page contains
 
         expect(extractTraceparentData(sentryTrace)).toEqual({
           traceId: expect.not.stringContaining(metaTagTraceId),
-          parentSpanId: expect.stringMatching(/^[0-9a-f]{16}$/),
+          parentSpanId: expect.stringMatching(/^[\da-f]{16}$/),
           parentSampled: false,
         });