Skip to content

Commit 7eef636

Browse files
committed
add some tests
1 parent 3b702e8 commit 7eef636

File tree

14 files changed

+133
-0
lines changed

14 files changed

+133
-0
lines changed

static/app/gettingStartedDocs/javascript/angular.spec.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,4 +153,11 @@ describe('javascript-angular onboarding docs', () => {
153153

154154
expect(screen.queryByText('Logging Integrations')).not.toBeInTheDocument();
155155
});
156+
157+
it('has metrics onboarding configuration', () => {
158+
expect(docs.metricsOnboarding).toBeDefined();
159+
expect(docs.metricsOnboarding?.install).toBeDefined();
160+
expect(docs.metricsOnboarding?.configure).toBeDefined();
161+
expect(docs.metricsOnboarding?.verify).toBeDefined();
162+
});
156163
});

static/app/gettingStartedDocs/javascript/astro.spec.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,4 +198,11 @@ describe('javascript-astro onboarding docs', () => {
198198
// This is a bit complex to test precisely, but we can ensure the config is split correctly
199199
expect(astroConfigSections.length).toBeGreaterThan(0);
200200
});
201+
202+
it('has metrics onboarding configuration', () => {
203+
expect(docs.metricsOnboarding).toBeDefined();
204+
expect(docs.metricsOnboarding?.install).toBeDefined();
205+
expect(docs.metricsOnboarding?.configure).toBeDefined();
206+
expect(docs.metricsOnboarding?.verify).toBeDefined();
207+
});
201208
});

static/app/gettingStartedDocs/javascript/ember.spec.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,4 +156,11 @@ describe('javascript-ember onboarding docs', () => {
156156
screen.queryByText(textWithMarkupMatcher(/Sentry\.logger\.info/))
157157
).not.toBeInTheDocument();
158158
});
159+
160+
it('has metrics onboarding configuration', () => {
161+
expect(docs.metricsOnboarding).toBeDefined();
162+
expect(docs.metricsOnboarding?.install).toBeDefined();
163+
expect(docs.metricsOnboarding?.configure).toBeDefined();
164+
expect(docs.metricsOnboarding?.verify).toBeDefined();
165+
});
159166
});

static/app/gettingStartedDocs/javascript/gatsby.spec.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,4 +213,11 @@ describe('javascript-gatsby onboarding docs', () => {
213213
// - Sentry.feedbackIntegration() is included when feedback is selected
214214
// - colorScheme: "system" is configured
215215
// - Feedback configuration options are applied
216+
217+
it('has metrics onboarding configuration', () => {
218+
expect(docs.metricsOnboarding).toBeDefined();
219+
expect(docs.metricsOnboarding?.install).toBeDefined();
220+
expect(docs.metricsOnboarding?.configure).toBeDefined();
221+
expect(docs.metricsOnboarding?.verify).toBeDefined();
222+
});
216223
});

static/app/gettingStartedDocs/javascript/javascript/onboarding.spec.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,4 +126,11 @@ describe('javascript onboarding docs', () => {
126126

127127
expect(screen.getByRole('heading', {name: 'Configure SDK'})).toBeInTheDocument();
128128
});
129+
130+
it('has metrics onboarding configuration', () => {
131+
expect(docs.metricsOnboarding).toBeDefined();
132+
expect(docs.metricsOnboarding?.install).toBeDefined();
133+
expect(docs.metricsOnboarding?.configure).toBeDefined();
134+
expect(docs.metricsOnboarding?.verify).toBeDefined();
135+
});
129136
});

static/app/gettingStartedDocs/javascript/nextjs.spec.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,11 @@ describe('javascript-nextjs onboarding docs', () => {
3434
screen.getByText(textWithMarkupMatcher(/sentry-example-page/))
3535
).toBeInTheDocument();
3636
});
37+
38+
it('has metrics onboarding configuration', () => {
39+
expect(docs.metricsOnboarding).toBeDefined();
40+
expect(docs.metricsOnboarding?.install).toBeDefined();
41+
expect(docs.metricsOnboarding?.configure).toBeDefined();
42+
expect(docs.metricsOnboarding?.verify).toBeDefined();
43+
});
3744
});

static/app/gettingStartedDocs/javascript/nuxt.spec.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,11 @@ describe('javascript-nuxt onboarding docs', () => {
4040
screen.getByText(textWithMarkupMatcher(/sentry-example-page/))
4141
).toBeInTheDocument();
4242
});
43+
44+
it('has metrics onboarding configuration', () => {
45+
expect(docs.metricsOnboarding).toBeDefined();
46+
expect(docs.metricsOnboarding?.install).toBeDefined();
47+
expect(docs.metricsOnboarding?.configure).toBeDefined();
48+
expect(docs.metricsOnboarding?.verify).toBeDefined();
49+
});
4350
});

static/app/gettingStartedDocs/javascript/react-router.spec.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,4 +105,11 @@ describe('javascript-react-router onboarding docs', () => {
105105
screen.getByText(textWithMarkupMatcher(/Sentry\.logger\.info\(/))
106106
).toBeInTheDocument();
107107
});
108+
109+
it('has metrics onboarding configuration', () => {
110+
expect(docs.metricsOnboarding).toBeDefined();
111+
expect(docs.metricsOnboarding?.install).toBeDefined();
112+
expect(docs.metricsOnboarding?.configure).toBeDefined();
113+
expect(docs.metricsOnboarding?.verify).toBeDefined();
114+
});
108115
});

static/app/gettingStartedDocs/javascript/react.spec.tsx

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,41 @@ describe('javascript-react onboarding docs', () => {
9696
).toBeInTheDocument();
9797
});
9898

99+
it('includes metrics API calls in verify when metrics is selected', () => {
100+
renderWithOnboardingLayout(docs, {
101+
selectedProducts: [ProductSolution.ERROR_MONITORING, ProductSolution.METRICS],
102+
});
103+
104+
expect(
105+
screen.getByText(
106+
textWithMarkupMatcher(/Sentry\.metrics\.count\('test_counter', 1\)/)
107+
)
108+
).toBeInTheDocument();
109+
});
110+
111+
it('shows Metrics in next steps when metrics is selected', () => {
112+
renderWithOnboardingLayout(docs, {
113+
selectedProducts: [
114+
ProductSolution.ERROR_MONITORING,
115+
ProductSolution.PERFORMANCE_MONITORING,
116+
ProductSolution.METRICS,
117+
],
118+
});
119+
120+
expect(screen.getByText('Metrics')).toBeInTheDocument();
121+
});
122+
123+
it('does not show Metrics in next steps when metrics is not selected', () => {
124+
renderWithOnboardingLayout(docs, {
125+
selectedProducts: [
126+
ProductSolution.ERROR_MONITORING,
127+
ProductSolution.PERFORMANCE_MONITORING,
128+
],
129+
});
130+
131+
expect(screen.queryByText('Metrics')).not.toBeInTheDocument();
132+
});
133+
99134
it('shows Logging Integrations in next steps when logs is selected', () => {
100135
renderWithOnboardingLayout(docs, {
101136
selectedProducts: [
@@ -118,4 +153,11 @@ describe('javascript-react onboarding docs', () => {
118153

119154
expect(screen.queryByText('Logging Integrations')).not.toBeInTheDocument();
120155
});
156+
157+
it('has metrics onboarding configuration', () => {
158+
expect(docs.metricsOnboarding).toBeDefined();
159+
expect(docs.metricsOnboarding?.install).toBeDefined();
160+
expect(docs.metricsOnboarding?.configure).toBeDefined();
161+
expect(docs.metricsOnboarding?.verify).toBeDefined();
162+
});
121163
});

static/app/gettingStartedDocs/javascript/remix.spec.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,11 @@ describe('javascript-remix onboarding docs', () => {
1818
screen.getByText(textWithMarkupMatcher(/npx @sentry\/wizard@latest -i remix/))
1919
).toBeInTheDocument();
2020
});
21+
22+
it('has metrics onboarding configuration', () => {
23+
expect(docs.metricsOnboarding).toBeDefined();
24+
expect(docs.metricsOnboarding?.install).toBeDefined();
25+
expect(docs.metricsOnboarding?.configure).toBeDefined();
26+
expect(docs.metricsOnboarding?.verify).toBeDefined();
27+
});
2128
});

0 commit comments

Comments
 (0)