Rule 6.9.2: AvoidStandardIntegerTypeNames.ql

Adds a new query for detecting the use of the standard integer
types.

Author: lcartey

cpp/common/src/codingstandards/cpp/exclusions/cpp/BannedAPIs.qll

@@ -12,7 +12,8 @@ newtype BannedAPIsQuery =
   TUseSmartPtrFactoryFunctionsQuery() or
   TCharacterHandlingFunctionRestrictionsQuery() or
   TNoMemoryFunctionsFromCStringQuery() or
-  TLocaleGlobalFunctionNotAllowedQuery()
+  TLocaleGlobalFunctionNotAllowedQuery() or
+  TAvoidStandardIntegerTypeNamesQuery()
 
 predicate isBannedAPIsQueryMetadata(Query query, string queryId, string ruleId, string category) {
   query =
@@ -95,6 +96,15 @@ predicate isBannedAPIsQueryMetadata(Query query, string queryId, string ruleId,
     "cpp/misra/locale-global-function-not-allowed" and
   ruleId = "RULE-25-5-1" and
   category = "required"
+  or
+  query =
+    // `Query` instance for the `avoidStandardIntegerTypeNames` query
+    BannedAPIsPackage::avoidStandardIntegerTypeNamesQuery() and
+  queryId =
+    // `@id` for the `avoidStandardIntegerTypeNames` query
+    "cpp/misra/avoid-standard-integer-type-names" and
+  ruleId = "RULE-6-9-2" and
+  category = "advisory"
 }
 
 module BannedAPIsPackage {
@@ -160,4 +170,11 @@ module BannedAPIsPackage {
       // `Query` type for `localeGlobalFunctionNotAllowed` query
       TQueryCPP(TBannedAPIsPackageQuery(TLocaleGlobalFunctionNotAllowedQuery()))
   }
+
+  Query avoidStandardIntegerTypeNamesQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `avoidStandardIntegerTypeNames` query
+      TQueryCPP(TBannedAPIsPackageQuery(TAvoidStandardIntegerTypeNamesQuery()))
+  }
 }

cpp/misra/src/rules/RULE-6-9-2/AvoidStandardIntegerTypeNames.ql

@@ -0,0 +1,23 @@
+/**
+ * @id cpp/misra/avoid-standard-integer-type-names
+ * @name RULE-6-9-2: The names of the standard signed integer types and standard unsigned integer types should not be
+ * @description Using standard signed and unsigned integer type names instead of specified width
+ *              types makes storage requirements unclear and implementation-dependent.
+ * @kind problem
+ * @precision very-high
+ * @problem.severity error
+ * @tags external/misra/id/rule-6-9-2
+ *       scope/single-translation-unit
+ *       external/misra/enforcement/decidable
+ *       external/misra/obligation/advisory
+ */
+
+import cpp
+import codingstandards.cpp.misra
+import codingstandards.cpp.rules.variablewidthintegertypesused.VariableWidthIntegerTypesUsed
+
+class AvoidStandardIntegerTypeNamesQuery extends VariableWidthIntegerTypesUsedSharedQuery {
+  AvoidStandardIntegerTypeNamesQuery() {
+    this = BannedAPIsPackage::avoidStandardIntegerTypeNamesQuery()
+  }
+}

cpp/misra/test/rules/RULE-6-9-2/AvoidStandardIntegerTypeNames.testref

@@ -0,0 +1 @@
+cpp/common/test/rules/variablewidthintegertypesused/VariableWidthIntegerTypesUsed.ql

rule_packages/cpp/BannedAPIs.json

@@ -179,6 +179,27 @@
         }
       ],
       "title": "The setlocale and std::locale::global functions shall not be called"
+    },
+    "RULE-6-9-2": {
+      "properties": {
+        "enforcement": "decidable",
+        "obligation": "advisory"
+      },
+      "queries": [
+        {
+          "description": "Using standard signed and unsigned integer type names instead of specified width types makes storage requirements unclear and implementation-dependent.",
+          "kind": "problem",
+          "name": "The names of the standard signed integer types and standard unsigned integer types should not be",
+          "precision": "very-high",
+          "severity": "error",
+          "short_name": "AvoidStandardIntegerTypeNames",
+          "shared_implementation_short_name": "VariableWidthIntegerTypesUsed",
+          "tags": [
+            "scope/single-translation-unit"
+          ]
+        }
+      ],
+      "title": "The names of the standard signed integer types and standard unsigned integer types should not be used"
     }
   }
 }

rules.csv

@@ -869,7 +869,7 @@ cpp,MISRA-C++-2023,RULE-6-8-2,Yes,Mandatory,Decidable,Single Translation Unit,A
 cpp,MISRA-C++-2023,RULE-6-8-3,Yes,Required,Decidable,Single Translation Unit,An assignment operator shall not assign the address of an object with automatic storage duration to an object with a greater lifetime,,Lifetime,Medium,
 cpp,MISRA-C++-2023,RULE-6-8-4,Yes,Advisory,Decidable,Single Translation Unit,Member functions returning references to their object should be refqualified appropriately,,Declarations2,Medium,
 cpp,MISRA-C++-2023,RULE-6-9-1,Yes,Required,Decidable,Single Translation Unit,The same type aliases shall be used in all declarations of the same entity,,Declarations2,Medium,
-cpp,MISRA-C++-2023,RULE-6-9-2,Yes,Advisory,Decidable,Single Translation Unit,The names of the standard signed integer types and standard unsigned integer types should not be used,A3-9-1,FixedWithInt,Easy,
+cpp,MISRA-C++-2023,RULE-6-9-2,Yes,Advisory,Decidable,Single Translation Unit,The names of the standard signed integer types and standard unsigned integer types should not be used,A3-9-1,BannedAPIs,Easy,
 cpp,MISRA-C++-2023,RULE-7-0-1,Yes,Required,Decidable,Single Translation Unit,There shall be no conversion from type bool,,Conversions,Easy,
 cpp,MISRA-C++-2023,RULE-7-0-2,Yes,Required,Decidable,Single Translation Unit,There shall be no conversion to type bool,,Conversions,Easy,
 cpp,MISRA-C++-2023,RULE-7-0-3,Yes,Required,Decidable,Single Translation Unit,The numerical value of a character shall not be used,M5-0-11,Conversions,Medium,