Address clippy issues

Author: cruessler

asyncgit/src/sync/hooks.rs

@@ -27,6 +27,7 @@ impl From<git2_hooks::HookResult> for HookResult {
 }
 
 /// this hook is documented here <https://git-scm.com/docs/githooks#_commit_msg>
+///
 /// we use the same convention as other git clients to create a temp file containing
 /// the commit message at `<.git|hooksPath>/COMMIT_EDITMSG` and pass it's relative path as the only
 /// parameter to the hook script.

git2-hooks/src/lib.rs

@@ -113,6 +113,7 @@ fn create_hook_in_path(path: &Path, hook_script: &[u8]) {
 }
 
 /// this hook is documented here <https://git-scm.com/docs/githooks#_commit_msg>
+///
 /// we use the same convention as other git clients to create a temp file containing
 /// the commit message at `<.git|hooksPath>/COMMIT_EDITMSG` and pass it's relative path as the only
 /// parameter to the hook script.

src/gitui.rs

@@ -24,7 +24,7 @@ use crate::{
 	SPINNER_INTERVAL, TICK_INTERVAL,
 };
 
-pub(crate) struct Gitui {
+pub struct Gitui {
 	app: crate::app::App,
 	rx_input: Receiver<InputEvent>,
 	rx_git: Receiver<AsyncGitNotification>,
@@ -62,8 +62,7 @@ impl Gitui {
 			input.clone(),
 			theme,
 			key_config.clone(),
-		)
-		.unwrap();
+		)?;
 
 		Ok(Self {
 			app,
@@ -130,7 +129,7 @@ impl Gitui {
 					QueueEvent::SpinnerUpdate => unreachable!(),
 				}
 
-				self.draw(terminal);
+				self.draw(terminal)?;
 
 				spinner.set_state(self.app.any_work_pending());
 				spinner.draw(terminal)?;
@@ -145,10 +144,10 @@ impl Gitui {
 	}
 
 	fn draw<B: ratatui::backend::Backend>(
-		&mut self,
+		&self,
 		terminal: &mut ratatui::Terminal<B>,
-	) {
-		draw(terminal, &self.app).unwrap();
+	) -> std::io::Result<()> {
+		draw(terminal, &self.app)
 	}
 
 	#[cfg(test)]
@@ -224,7 +223,7 @@ mod tests {
 		let mut terminal =
 			Terminal::new(TestBackend::new(120, 40)).unwrap();
 
-		gitui.draw(&mut terminal);
+		gitui.draw(&mut terminal).unwrap();
 
 		sleep(Duration::from_millis(500));
 
@@ -236,7 +235,7 @@ mod tests {
 
 		sleep(Duration::from_millis(500));
 
-		gitui.draw(&mut terminal);
+		gitui.draw(&mut terminal).unwrap();
 
 		assert_snapshot!("app_loading_finished", terminal.backend());
 
@@ -250,7 +249,7 @@ mod tests {
 
 		gitui.update();
 
-		gitui.draw(&mut terminal);
+		gitui.draw(&mut terminal).unwrap();
 
 		assert_snapshot!(
 			"app_log_tab_showing_one_commit",

src/main.rs

@@ -151,7 +151,7 @@ fn main() -> Result<()> {
 			app_start,
 			repo_path.clone(),
 			theme.clone(),
-			key_config.clone(),
+			&key_config,
 			updater,
 			&mut terminal,
 		)?;
@@ -171,12 +171,11 @@ fn run_app(
 	app_start: Instant,
 	repo: RepoPath,
 	theme: Theme,
-	key_config: KeyConfig,
+	key_config: &KeyConfig,
 	updater: Updater,
 	terminal: &mut Terminal,
 ) -> Result<QuitState, anyhow::Error> {
-	let mut gitui =
-		Gitui::new(repo.clone(), theme, &key_config, updater)?;
+	let mut gitui = Gitui::new(repo, theme, key_config, updater)?;
 
 	log::trace!("app start: {} ms", app_start.elapsed().as_millis());