Prettify request response when GraphiQL. Fixed #6

Author: syrusakbary

flask_graphql/graphqlview.py

@@ -133,14 +133,15 @@ def get_response(self, request, data, show_graphiql=False):
                     'status': status_code,
                 }
 
-            result = self.json_encode(request, response)
+            result = self.json_encode(request, response, show_graphiql)
         else:
             result = None
 
         return result, status_code
 
-    def json_encode(self, request, d):
-        if not self.pretty and not request.args.get('pretty'):
+    def json_encode(self, request, d, show_graphiql=False):
+        pretty = self.pretty or show_graphiql or request.args.get('pretty')
+        if not pretty:
             return json.dumps(d, separators=(',', ':'))
 
         return json.dumps(d, sort_keys=True,

tests/test_graphiqlview.py

@@ -12,3 +12,17 @@ def app():
 def test_graphiql_is_enabled(client):
     response = client.get(url_for('graphql'), headers={'Accept': 'text/html'})
     assert response.status_code == 200
+
+
+def test_graphiql_renders_pretty(client):
+    response = client.get(url_for('graphql', query='{test}'), headers={'Accept': 'text/html'})
+    assert response.status_code == 200
+    pretty_response = (
+        '{\n'
+        '  "data": {\n'
+        '    "test": "Hello World"\n'
+        '  }\n'
+        '}'
+    ).replace("\"","\\\"").replace("\n","\\n")
+
+    assert pretty_response in response.data.decode('utf-8')

tests/test_graphqlview.py

@@ -327,6 +327,15 @@ def test_supports_pretty_printing(client):
     )
 
 
+@pytest.mark.parametrize('app', [create_app(pretty=False)])
+def test_not_pretty_by_default(client):
+    response = client.get(url_string(query='{test}'))
+
+    assert response.data.decode() == (
+        '{"data":{"test":"Hello World"}}'
+    )
+
+
 def test_supports_pretty_printing_by_request(client):
     response = client.get(url_string(query='{test}', pretty='1'))