Skip to content

Commit 9896b84

Browse files
committed
polish(IncrementalPublisher): remove unnecessary check and method call
Replicates graphql/graphql-js@e160b6f
1 parent ecf33f2 commit 9896b84

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/graphql/execution/incremental_publisher.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,6 @@ def _handle_completed_deferred_grouped_field_set(
230230
append_completed(
231231
CompletedResult(id_, deferred_grouped_field_set_result.errors)
232232
)
233-
remove_deferred(deferred_fragment_record)
234233
return
235234

236235
deferred_grouped_field_set_result = cast(
@@ -250,12 +249,13 @@ def _handle_completed_deferred_grouped_field_set(
250249

251250
complete_deferred = self._incremental_graph.complete_deferred_fragment
252251
for deferred_fragment_record in record.deferred_fragment_records:
253-
id_ = deferred_fragment_record.id
254-
if id_ is None:
255-
continue # pragma: no cover
256252
reconcilable_results = complete_deferred(deferred_fragment_record)
257253
if reconcilable_results is None:
258254
continue
255+
id_ = deferred_fragment_record.id
256+
if id_ is None: # pragma: no cover
257+
msg = "Missing deferred fragment record identifier."
258+
raise RuntimeError(msg)
259259
for reconcilable_result in reconcilable_results:
260260
best_id, sub_path = self._get_best_id_and_sub_path(
261261
id_, deferred_fragment_record, reconcilable_result

0 commit comments

Comments
 (0)