Addressing PR comments

Author: carlblan

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

@@ -100,54 +100,39 @@ protected String columnType(int sqlTypeCode) {
 			case SqlTypes.BOOLEAN:
 			case SqlTypes.BIT:
 			case SqlTypes.TINYINT:
-				return "TT_TINYINT";
+				return "tt_tinyint";
 			case SqlTypes.SMALLINT:
-				return "TT_SMALLINT";
+				return "tt_smallint";
 			case SqlTypes.INTEGER:
-				return "TT_INTEGER";
+				return "tt_integer";
 			case SqlTypes.BIGINT:
-				return "TT_BIGINT";
+				return "tt_bigint";
 			//note that 'binary_float'/'binary_double' might
 			//be better mappings for Java Float/Double
 
-			case SqlTypes.CHAR:
-				return "CHAR($l)";
 			case SqlTypes.VARCHAR:
 			case SqlTypes.LONGVARCHAR:
-				return "VARCHAR2($l)";
+				return "varchar2($l)";
 
-			case SqlTypes.BINARY:
-				return "BINARY($l)";
-			case SqlTypes.VARBINARY:
 			case SqlTypes.LONGVARBINARY:
-				return "VARBINARY($l)";
+				return "varbinary($l)";
 
 			//'numeric'/'decimal' are synonyms for 'number'
 			case SqlTypes.NUMERIC:
 			case SqlTypes.DECIMAL:
-				return "NUMBER($p,$s)";
+				return "number($p,$s)";
 			case SqlTypes.FLOAT:
-				return "BINARY_FLOAT";
+				return "binary_float";
 			case SqlTypes.DOUBLE:
-				return "BINARY_DOUBLE";
+				return "binary_double";
 
 			case SqlTypes.DATE:
-				return "TT_DATE";
+				return "tt_date";
 			case SqlTypes.TIME:
-				return "TT_TIME";
-			case SqlTypes.TIMESTAMP:
-				return "TIMESTAMP";
-			//`timestamp` has more precision than `tt_timestamp`
+				return "tt_time";
 			case SqlTypes.TIMESTAMP_WITH_TIMEZONE:
 				return "timestamp($p)";
 
-			case SqlTypes.BLOB:
-				return "BLOB";
-			case SqlTypes.CLOB:
-				return "CLOB";
-			case SqlTypes.NCLOB:
-				return "NCLOB";
-
 			default:
 				return super.columnType( sqlTypeCode );
 		}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenSqlAstTranslator.java

@@ -163,13 +163,8 @@ protected void renderRowsToClause(Expression offsetClauseExpression, Expression
 				clauseStack.pop();
 			}
 		}
-		else if ( offsetClauseExpression != null && fetchClauseExpression == null ) {
-			throw new UnsupportedOperationException( 
-				"Only passing setFirstResult(m) and not setMaxResults(n) to 'ROWS m TO n' clause not supported." 
-			);
-		}
-		else if ( offsetClauseExpression != null && fetchClauseExpression != null ) {
-			// We have offset and maxRows/limit. We use 'SELECT ROWS offset TO limit' syntax
+		else if ( offsetClauseExpression != null ) {
+			// We have an offset. We use 'SELECT ROWS m TO n' syntax
 			appendSql( "rows " );
 
 			// Render offset parameter
@@ -186,9 +181,14 @@ else if ( offsetClauseExpression != null && fetchClauseExpression != null ) {
 			// Render maxRows/limit parameter
 			clauseStack.push( Clause.FETCH );
 			try {
-				// TimesTen includes both m and n rows of 'ROWS m to n'; 
-				// We need to substract 1 row to fit maxRows
-				renderFetchPlusOffsetExpressionAsLiteral( fetchClauseExpression, offsetClauseExpression, -1 );
+				if ( fetchClauseExpression != null ) {
+					// We need to substract 1 row to fit maxRows
+					renderFetchPlusOffsetExpressionAsLiteral( fetchClauseExpression, offsetClauseExpression, -1 );
+				}
+				else{
+					// We dont have a maxRows param, we will just use a MAX_VALUE
+					appendSql( Integer.MAX_VALUE );
+				}
 			}
 			finally {
 				clauseStack.pop();