Skip to content

Commit e1520da

Browse files
committed
Fixup some leftovers from the Oracle TimesTenDialect updates
1 parent 8961238 commit e1520da

File tree

3 files changed

+5
-26
lines changed

3 files changed

+5
-26
lines changed

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -351,10 +351,9 @@ public RowLockStrategy getWriteRowLockStrategy() {
351351
return RowLockStrategy.COLUMN;
352352
}
353353

354-
355354
@Override
356-
public String getForUpdateString() {
357-
return " for update";
355+
public String getForUpdateString(String aliases) {
356+
return " for update of " + aliases;
358357
}
359358

360359
@Override

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/pagination/TimesTenLimitHandler.java

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,20 @@
66
*/
77
package org.hibernate.community.dialect.pagination;
88

9+
import org.hibernate.dialect.pagination.AbstractSimpleLimitHandler;
910
import org.hibernate.dialect.pagination.LimitHandler;
10-
import org.hibernate.dialect.pagination.LimitHandler;
11-
import org.hibernate.dialect.pagination.AbstractLimitHandler;
1211

1312
/**
1413
* A {@link LimitHandler} for TimesTen, which uses {@code ROWS n},
1514
* but at the start of the query instead of at the end.
1615
*/
17-
public class TimesTenLimitHandler extends AbstractLimitHandler {
16+
public class TimesTenLimitHandler extends AbstractSimpleLimitHandler {
1817

1918
public static final TimesTenLimitHandler INSTANCE = new TimesTenLimitHandler();
2019

2120
public TimesTenLimitHandler(){
2221
}
2322

24-
@Override
25-
public boolean supportsLimit() {
26-
return true;
27-
}
28-
2923
@Override
3024
public boolean supportsOffset() {
3125
return false;
@@ -36,14 +30,6 @@ public boolean supportsLimitOffset() {
3630
return true;
3731
}
3832

39-
@Override
40-
public boolean supportsVariableLimit() {
41-
// a limit string using literals instead of parameters is
42-
// required to translate from Hibernate's 0 based row numbers
43-
// to TimesTen 1 based row numbers
44-
return false;
45-
}
46-
4733
@Override
4834
// TimesTen is 1 based
4935
public int convertToFirstRowValue(int zeroBasedFirstResult) {
@@ -60,6 +46,7 @@ public boolean bindLimitParametersFirst() {
6046
return true;
6147
}
6248

49+
@Override
6350
protected String limitClause(boolean hasFirstRow) {
6451
return hasFirstRow ? " rows ? to ?" : " first ?";
6552
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/sequence/TimesTenSequenceSupport.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,6 @@ public final class TimesTenSequenceSupport implements SequenceSupport {
1717

1818
public static final SequenceSupport INSTANCE = new TimesTenSequenceSupport();
1919

20-
21-
22-
@Override
23-
public boolean supportsSequences() {
24-
return true;
25-
}
26-
2720
@Override
2821
public boolean supportsPooledSequences() {
2922
return true;

0 commit comments

Comments
 (0)