HV-1363 Encapsulate ConstraintLocationKind inside ConstraintLocation

gsmet · gsmet · commit 254537e51893 · 2018-06-04T14:34:14.000+02:00
diff --git a/engine/src/main/java/org/hibernate/validator/internal/cfg/context/ConfiguredConstraint.java b/engine/src/main/java/org/hibernate/validator/internal/cfg/context/ConfiguredConstraint.java
@@ -19,8 +19,6 @@
 import org.hibernate.validator.cfg.AnnotationDef;
 import org.hibernate.validator.cfg.ConstraintDef;
 import org.hibernate.validator.internal.metadata.location.ConstraintLocation;
-import org.hibernate.validator.internal.metadata.location.ConstraintLocation.ConstraintLocationKind;
-import org.hibernate.validator.internal.metadata.raw.ConstrainedElement.ConstrainedElementKind;
 import org.hibernate.validator.internal.properties.Callable;
 import org.hibernate.validator.internal.properties.Property;
 import org.hibernate.validator.internal.util.annotation.AnnotationDescriptor;
@@ -34,6 +32,7 @@
  * related to its location (bean type etc.).
  *
  * @author Gunnar Morling
+ * @author Guillaume Smet
  */
 class ConfiguredConstraint<A extends Annotation> {
 
@@ -44,49 +43,36 @@ class ConfiguredConstraint<A extends Annotation> {
 
 	private final ConstraintDef<?, A> constraint;
 	private final ConstraintLocation location;
-	private final ConstraintLocationKind kind;
 
-	private ConfiguredConstraint(ConstraintDef<?, A> constraint, ConstraintLocation location, ConstraintLocationKind kind) {
+	private ConfiguredConstraint(ConstraintDef<?, A> constraint, ConstraintLocation location) {
 		this.constraint = constraint;
 		this.location = location;
-		this.kind = kind;
 	}
 
 	static <A extends Annotation> ConfiguredConstraint<A> forType(ConstraintDef<?, A> constraint, Class<?> beanType) {
-		return new ConfiguredConstraint<>( constraint, ConstraintLocation.forClass( beanType ), ConstraintLocationKind.TYPE );
+		return new ConfiguredConstraint<>( constraint, ConstraintLocation.forClass( beanType ) );
 	}
 
 	static <A extends Annotation> ConfiguredConstraint<A> forFieldProperty(ConstraintDef<?, A> constraint, Property property) {
-		return new ConfiguredConstraint<>(
-				constraint,
-				ConstraintLocation.forProperty( property ),
-				ConstraintLocationKind.PROPERTY
-		);
+		return new ConfiguredConstraint<>( constraint, ConstraintLocation.forProperty( property ) );
 	}
 
 	public static <A extends Annotation> ConfiguredConstraint<A> forParameter(ConstraintDef<?, A> constraint, Callable callable, int parameterIndex) {
-		return new ConfiguredConstraint<>(
-				constraint, ConstraintLocation.forParameter( callable, parameterIndex ), getConstraintLocationKindFromCallable( callable )
-		);
+		return new ConfiguredConstraint<>( constraint, ConstraintLocation.forParameter( callable, parameterIndex ) );
 	}
 
 	public static <A extends Annotation> ConfiguredConstraint<A> forExecutable(ConstraintDef<?, A> constraint, Callable callable) {
-		return new ConfiguredConstraint<>(
-				constraint, ConstraintLocation.forReturnValue( callable ), getConstraintLocationKindFromCallable( callable )
-		);
+		return new ConfiguredConstraint<>( constraint, ConstraintLocation.forReturnValue( callable ) );
 	}
 
 	public static <A extends Annotation> ConfiguredConstraint<A> forCrossParameter(ConstraintDef<?, A> constraint, Callable callable) {
-		return new ConfiguredConstraint<>(
-				constraint, ConstraintLocation.forCrossParameter( callable ), getConstraintLocationKindFromCallable( callable )
-		);
+		return new ConfiguredConstraint<>( constraint, ConstraintLocation.forCrossParameter( callable ) );
 	}
 
 	public static <A extends Annotation> ConfiguredConstraint<A> forTypeArgument(ConstraintDef<?, A> constraint, ConstraintLocation delegate, TypeVariable<?> typeArgument, Type typeOfAnnotatedElement) {
 		return new ConfiguredConstraint<>(
 				constraint,
-				ConstraintLocation.forTypeArgument( delegate, typeArgument, typeOfAnnotatedElement ),
-				ConstraintLocationKind.TYPE_USE
+				ConstraintLocation.forTypeArgument( delegate, typeArgument, typeOfAnnotatedElement )
 		);
 	}
 
@@ -116,16 +102,6 @@ public String toString() {
 		return constraint.toString();
 	}
 
-	public ConstraintLocationKind getConstraintLocationKind() {
-		return kind;
-	}
-
-	private static ConstraintLocationKind getConstraintLocationKindFromCallable(Callable callable) {
-		return callable.getConstrainedElementKind() == ConstrainedElementKind.CONSTRUCTOR
-				? ConstraintLocationKind.CONSTRUCTOR
-				: ConstraintLocationKind.METHOD;
-	}
-
 	/**
 	 * Runs the given privileged action, using a privileged block if required.
 	 * <b>NOTE:</b> This must never be changed into a publicly available method to avoid execution of arbitrary
diff --git a/engine/src/main/java/org/hibernate/validator/internal/cfg/context/ConstraintMappingContextImplBase.java b/engine/src/main/java/org/hibernate/validator/internal/cfg/context/ConstraintMappingContextImplBase.java
@@ -75,7 +75,7 @@ private <A extends Annotation> MetaConstraint<A> asMetaConstraint(ConfiguredCons
 				constraintHelper,
 				config.getLocation().getMember(),
 				config.createAnnotationDescriptor(),
-				config.getConstraintLocationKind(),
+				config.getLocation().getKind(),
 				getConstraintType()
 		);
 
diff --git a/engine/src/main/java/org/hibernate/validator/internal/cfg/context/ContainerElementConstraintMappingContextImpl.java b/engine/src/main/java/org/hibernate/validator/internal/cfg/context/ContainerElementConstraintMappingContextImpl.java
@@ -239,7 +239,7 @@ private <A extends Annotation> MetaConstraint<A> asMetaConstraint(ConfiguredCons
 				constraintHelper,
 				config.getLocation().getMember(),
 				config.createAnnotationDescriptor(),
-				config.getConstraintLocationKind(),
+				config.getLocation().getKind(),
 				getConstraintType()
 		);
 
diff --git a/engine/src/main/java/org/hibernate/validator/internal/metadata/location/BeanConstraintLocation.java b/engine/src/main/java/org/hibernate/validator/internal/metadata/location/BeanConstraintLocation.java
@@ -18,6 +18,7 @@
  *
  * @author Hardy Ferentschik
  * @author Gunnar Morling
+ * @author Guillaume Smet
  */
 class BeanConstraintLocation implements ConstraintLocation {
 
@@ -66,6 +67,11 @@ public Object getValue(Object parent) {
 		return parent;
 	}
 
+	@Override
+	public ConstraintLocationKind getKind() {
+		return ConstraintLocationKind.TYPE;
+	}
+
 	@Override
 	public String toString() {
 		return "BeanConstraintLocation [declaringClass=" + declaringClass + ", typeForValidatorResolution=" + typeForValidatorResolution + "]";
diff --git a/engine/src/main/java/org/hibernate/validator/internal/metadata/location/ConstraintLocation.java b/engine/src/main/java/org/hibernate/validator/internal/metadata/location/ConstraintLocation.java
@@ -92,6 +92,11 @@ static ConstraintLocation forParameter(Callable callable, int index) {
 	 */
 	Object getValue(Object parent);
 
+	/**
+	 * Returns the nature of the constraint location.
+	 */
+	ConstraintLocationKind getKind();
+
 	enum ConstraintLocationKind {
 		TYPE( ElementType.TYPE ),
 		CONSTRUCTOR( ElementType.CONSTRUCTOR ),
diff --git a/engine/src/main/java/org/hibernate/validator/internal/metadata/location/CrossParameterConstraintLocation.java b/engine/src/main/java/org/hibernate/validator/internal/metadata/location/CrossParameterConstraintLocation.java
@@ -9,6 +9,8 @@
 import java.lang.reflect.Type;
 
 import org.hibernate.validator.internal.engine.path.PathImpl;
+import org.hibernate.validator.internal.metadata.raw.ConstrainedElement.ConstrainedElementKind;
+import org.hibernate.validator.internal.properties.Callable;
 import org.hibernate.validator.internal.properties.Constrainable;
 import org.hibernate.validator.internal.util.ExecutableParameterNameProvider;
 
@@ -17,23 +19,29 @@
  *
  * @author Hardy Ferentschik
  * @author Gunnar Morling
+ * @author Guillaume Smet
  */
 class CrossParameterConstraintLocation implements ConstraintLocation {
 
-	private final Constrainable executable;
+	private final Callable callable;
 
-	CrossParameterConstraintLocation(Constrainable executable) {
-		this.executable = executable;
+	private final ConstraintLocationKind kind;
+
+	CrossParameterConstraintLocation(Callable callable) {
+		this.callable = callable;
+		this.kind = callable.getConstrainedElementKind() == ConstrainedElementKind.CONSTRUCTOR
+				? ConstraintLocationKind.CONSTRUCTOR
+				: ConstraintLocationKind.METHOD;
 	}
 
 	@Override
 	public Class<?> getDeclaringClass() {
-		return executable.getDeclaringClass();
+		return callable.getDeclaringClass();
 	}
 
 	@Override
 	public Constrainable getMember() {
-		return executable;
+		return callable;
 	}
 
 	@Override
@@ -51,14 +59,19 @@ public Object getValue(Object parent) {
 		return parent;
 	}
 
+	@Override
+	public ConstraintLocationKind getKind() {
+		return kind;
+	}
+
 	@Override
 	public String toString() {
-		return "CrossParameterConstraintLocation [executable=" + executable + "]";
+		return "CrossParameterConstraintLocation [callable=" + callable + "]";
 	}
 
 	@Override
 	public int hashCode() {
-		return executable.hashCode();
+		return callable.hashCode();
 	}
 
 	@Override
@@ -73,7 +86,7 @@ public boolean equals(Object obj) {
 			return false;
 		}
 		CrossParameterConstraintLocation other = (CrossParameterConstraintLocation) obj;
-		if ( !executable.equals( other.executable ) ) {
+		if ( !callable.equals( other.callable ) ) {
 			return false;
 		}
 
diff --git a/engine/src/main/java/org/hibernate/validator/internal/metadata/location/ParameterConstraintLocation.java b/engine/src/main/java/org/hibernate/validator/internal/metadata/location/ParameterConstraintLocation.java
@@ -9,6 +9,7 @@
 import java.lang.reflect.Type;
 
 import org.hibernate.validator.internal.engine.path.PathImpl;
+import org.hibernate.validator.internal.metadata.raw.ConstrainedElement.ConstrainedElementKind;
 import org.hibernate.validator.internal.properties.Callable;
 import org.hibernate.validator.internal.properties.Constrainable;
 import org.hibernate.validator.internal.util.ExecutableParameterNameProvider;
@@ -19,17 +20,22 @@
  *
  * @author Hardy Ferentschik
  * @author Gunnar Morling
+ * @author Guillaume Smet
  */
 public class ParameterConstraintLocation implements ConstraintLocation {
 
 	private final Callable callable;
 	private final int index;
 	private final Type typeForValidatorResolution;
+	private final ConstraintLocationKind kind;
 
 	public ParameterConstraintLocation(Callable callable, int index) {
 		this.callable = callable;
 		this.index = index;
 		this.typeForValidatorResolution = ReflectionHelper.boxedType( callable.getParameterGenericType( index ) );
+		this.kind = callable.getConstrainedElementKind() == ConstrainedElementKind.CONSTRUCTOR
+				? ConstraintLocationKind.CONSTRUCTOR
+				: ConstraintLocationKind.METHOD;
 	}
 
 	@Override
@@ -61,9 +67,14 @@ public Object getValue(Object parent) {
 		return ( (Object[]) parent )[index];
 	}
 
+	@Override
+	public ConstraintLocationKind getKind() {
+		return kind;
+	}
+
 	@Override
 	public String toString() {
-		return "ParameterConstraintLocation [executable=" + callable + ", index=" + index + "]";
+		return "ParameterConstraintLocation [callable=" + callable + ", index=" + index + "]";
 	}
 
 	@Override
diff --git a/engine/src/main/java/org/hibernate/validator/internal/metadata/location/PropertyConstraintLocation.java b/engine/src/main/java/org/hibernate/validator/internal/metadata/location/PropertyConstraintLocation.java
@@ -17,6 +17,7 @@
  * Property constraint location.
  *
  * @author Marko Bekhta
+ * @author Guillaume Smet
  */
 public class PropertyConstraintLocation implements ConstraintLocation {
 
@@ -58,6 +59,11 @@ public Object getValue(Object parent) {
 		return property.getValueFrom( parent );
 	}
 
+	@Override
+	public ConstraintLocationKind getKind() {
+		return ConstraintLocationKind.PROPERTY;
+	}
+
 	@Override
 	public String toString() {
 		return "PropertyConstraintLocation [property=" + property + "]";
diff --git a/engine/src/main/java/org/hibernate/validator/internal/metadata/location/ReturnValueConstraintLocation.java b/engine/src/main/java/org/hibernate/validator/internal/metadata/location/ReturnValueConstraintLocation.java
@@ -9,6 +9,7 @@
 import java.lang.reflect.Type;
 
 import org.hibernate.validator.internal.engine.path.PathImpl;
+import org.hibernate.validator.internal.metadata.raw.ConstrainedElement.ConstrainedElementKind;
 import org.hibernate.validator.internal.properties.Callable;
 import org.hibernate.validator.internal.properties.Constrainable;
 import org.hibernate.validator.internal.util.ExecutableParameterNameProvider;
@@ -19,13 +20,19 @@
  * @author Hardy Ferentschik
  * @author Gunnar Morling
  * @author Marko Bekhta
+ * @author Guillaume Smet
  */
 class ReturnValueConstraintLocation implements ConstraintLocation {
 
 	private final Callable callable;
 
+	private final ConstraintLocationKind kind;
+
 	ReturnValueConstraintLocation(Callable callable) {
 		this.callable = callable;
+		this.kind = callable.getConstrainedElementKind() == ConstrainedElementKind.CONSTRUCTOR
+				? ConstraintLocationKind.CONSTRUCTOR
+				: ConstraintLocationKind.METHOD;
 	}
 
 	@Override
@@ -53,9 +60,14 @@ public Object getValue(Object parent) {
 		return parent;
 	}
 
+	@Override
+	public ConstraintLocationKind getKind() {
+		return kind;
+	}
+
 	@Override
 	public String toString() {
-		return "ReturnValueConstraintLocation [executable=" + callable + "]";
+		return "ReturnValueConstraintLocation [callable=" + callable + "]";
 	}
 
 	@Override
diff --git a/engine/src/main/java/org/hibernate/validator/internal/metadata/location/TypeArgumentConstraintLocation.java b/engine/src/main/java/org/hibernate/validator/internal/metadata/location/TypeArgumentConstraintLocation.java
@@ -87,6 +87,11 @@ public ConstraintLocation getOuterDelegate() {
 		return outerDelegate;
 	}
 
+	@Override
+	public ConstraintLocationKind getKind() {
+		return ConstraintLocationKind.TYPE_USE;
+	}
+
 	@Override
 	public String toString() {
 		return "TypeArgumentValueConstraintLocation [typeForValidatorResolution=" + StringHelper.toShortString( typeForValidatorResolution )
