feat: throw error on malformed tsconfig reference (#423)

close #415

Author: JounQin

.changeset/wise-singers-own.md

@@ -0,0 +1,5 @@
+---
+"eslint-import-resolver-typescript": minor
+---
+
+feat: throw error on malformed `tsconfig` reference

.size-limit.json

@@ -1,6 +1,6 @@
 [
   {
     "path": "./lib/index.js",
-    "limit": "1.4kB"
+    "limit": "1.5kB"
   }
 ]

src/constants.ts

@@ -73,3 +73,5 @@ export const DEFAULT_TRY_PATHS = ['', ...DEFAULT_CONFIGS]
 export const MATCH_ALL = '**'
 
 export const DEFAULT_IGNORE = [MATCH_ALL, 'node_modules', MATCH_ALL].join('/')
+
+export const TSCONFIG_NOT_FOUND_REGEXP = /^Tsconfig not found\b/

src/index.ts

@@ -12,7 +12,11 @@ import { isBunBuiltin } from 'is-bun-module'
 import { stableHash } from 'stable-hash'
 import { ResolverFactory } from 'unrs-resolver'
 
-import { IMPORT_RESOLVER_NAME, JS_EXT_PATTERN } from './constants.js'
+import {
+  IMPORT_RESOLVER_NAME,
+  JS_EXT_PATTERN,
+  TSCONFIG_NOT_FOUND_REGEXP,
+} from './constants.js'
 import {
   mangleScopedPackage,
   removeQuerystring,
@@ -47,6 +51,9 @@ const unrsResolve = (
   }
   if (result.error) {
     log('oxc resolve error:', result.error)
+    if (TSCONFIG_NOT_FOUND_REGEXP.test(result.error)) {
+      throw new Error(result.error)
+    }
   }
   return {
     found: false,

tests/unit/malformed-references/tsconfig.json renamed to tests/unit/malformed-reference/index.ts

@@ -0,0 +1,7 @@
+{
+  "references": [
+    {
+      "path": "./non-existed"
+    }
+  ]
+}

tests/unit/malformed-reference/tsconfig.json

@@ -2,20 +2,25 @@ import path from 'node:path'
 
 import { exec } from 'tinyexec'
 
-import { createTypeScriptImportResolver } from 'eslint-import-resolver-typescript'
+import {
+  createTypeScriptImportResolver,
+  TSCONFIG_NOT_FOUND_REGEXP,
+} from 'eslint-import-resolver-typescript'
 
 describe('createTypeScriptImportResolver', async () => {
-  const pnpDir = path.resolve(import.meta.dirname, 'pnp')
+  const { dirname } = import.meta
+
+  const pnpDir = path.resolve(dirname, 'pnp')
 
   await exec('yarn', [], {
     nodeOptions: {
       cwd: pnpDir,
     },
   })
 
-  const resolver = createTypeScriptImportResolver()
-
   it('should work with pnp', async () => {
+    const resolver = createTypeScriptImportResolver()
+
     const testfile = path.resolve(pnpDir, '__test__.js')
 
     expect(resolver.resolve('pnpapi', testfile)).toMatchInlineSnapshot(`
@@ -32,4 +37,16 @@ describe('createTypeScriptImportResolver', async () => {
         }
       `)
   })
+
+  it('should error on malformed tsconfig reference', () => {
+    const project = path.resolve(dirname, 'malformed-reference')
+
+    const resolver = createTypeScriptImportResolver({ project })
+
+    const testfile = path.resolve(project, '__test__.js')
+
+    expect(() => resolver.resolve('index.js', testfile)).toThrowError(
+      TSCONFIG_NOT_FOUND_REGEXP,
+    )
+  })
 })