Skip to content

Commit 9398ef5

Browse files
[CI] Unify E2E/CTS inputs args in sycl-*-run-tests.yml (#20567)
Note: `sycl-linux-build.yml` has multiple tests artifacts, e.g. regular e2e/preview/SPIR-V backed, so no unification there. I also plan on some fixes regarding `in-container` `binaries_artifact` in a later PR that would unify the handling of artifact uploading between E2E/CTS (if it requires both `binaries_artifact` and `build-only` to be set or not).
1 parent 0f39e01 commit 9398ef5

File tree

10 files changed

+73
-93
lines changed

10 files changed

+73
-93
lines changed

.github/workflows/sycl-linux-precommit.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,19 +188,19 @@ jobs:
188188
runner: '["Linux", "gen12"]'
189189
target_devices: level_zero:gpu;opencl:gpu;opencl:cpu
190190
extra_lit_opts: --param test-preview-mode=True
191-
e2e_binaries_artifact: e2e_bin_preview
191+
binaries_artifact: e2e_bin_preview
192192
- name: ABI compatibility / sycl-rel-6_2
193193
runner: '["Linux", "pvc"]'
194194
image: ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_2
195195
target_devices: level_zero:gpu
196196
extra_lit_opts: '--param test-preview-mode=False --filter-out "${{ needs.compat_read_exclude.outputs.FILTER_6_2 }}"'
197-
e2e_binaries_artifact: 'in-container'
197+
binaries_artifact: 'in-container'
198198
- name: ABI compatibility / sycl-rel-6_3
199199
runner: '["Linux", "pvc"]'
200200
image: ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_3
201201
target_devices: level_zero:gpu
202202
extra_lit_opts: '--param test-preview-mode=False --filter-out "${{ needs.compat_read_exclude.outputs.FILTER_6_3 }}"'
203-
e2e_binaries_artifact: 'in-container'
203+
binaries_artifact: 'in-container'
204204

205205
uses: ./.github/workflows/sycl-linux-run-tests.yml
206206
with:
@@ -214,8 +214,8 @@ jobs:
214214
toolchain_artifact: ${{ needs.build.outputs.toolchain_artifact }}
215215
toolchain_artifact_filename: ${{ needs.build.outputs.toolchain_artifact_filename }}
216216
toolchain_decompress_command: ${{ needs.build.outputs.toolchain_decompress_command }}
217-
e2e_binaries_artifact: ${{ matrix.e2e_binaries_artifact || 'e2e_bin' }}
218-
e2e_testing_mode: 'run-only'
217+
binaries_artifact: ${{ matrix.binaries_artifact || 'e2e_bin' }}
218+
testing_mode: 'run-only'
219219

220220
# Do not install drivers on AMD and CUDA runners.
221221
install_igc_driver: >-

.github/workflows/sycl-linux-run-tests.yml

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ on:
5858
default: ''
5959
required: False
6060

61-
e2e_binaries_artifact:
61+
binaries_artifact:
6262
description: |
6363
When set in modes other than `run-only` results in artifact upload.
6464
For `run-only` mode, if specified, means downloading pre-built
@@ -68,9 +68,9 @@ on:
6868
type: string
6969
default: ''
7070
required: False
71-
e2e_testing_mode:
71+
testing_mode:
7272
description: |
73-
Testing mode to run E2E tests in, can be either `full`, `build-only`
73+
Testing mode to run E2E/CTS tests in, can be either `full`, `build-only`
7474
or `run-only`.
7575
type: string
7676
default: 'full'
@@ -95,19 +95,6 @@ on:
9595
default: 'false'
9696
required: False
9797

98-
cts_testing_mode:
99-
description: |
100-
Testing mode to run SYCL-CTS in, can be either `full`, `build-only`
101-
or `run-only`. In `build-only` mode an artifact of the CTS binaries
102-
will be uploaded.
103-
type: string
104-
default: 'full'
105-
106-
sycl_cts_artifact:
107-
type: string
108-
default: ''
109-
required: False
110-
11198
benchmark_upload_results:
11299
description: |
113100
Set to true to upload results to git repository storing benchmarking
@@ -211,7 +198,7 @@ on:
211198
Extra options to be added to LIT_OPTS.
212199
default: ''
213200

214-
e2e_testing_mode:
201+
testing_mode:
215202
type: choice
216203
options:
217204
- "full"
@@ -251,7 +238,7 @@ jobs:
251238
- name: Reset Intel GPU
252239
uses: ./devops/actions/reset_gpu
253240
- name: Install drivers
254-
if: inputs.e2e_binaries_artifact != 'in-container' && (inputs.install_igc_driver == 'true' || inputs.install_dev_igc_driver == 'true')
241+
if: inputs.binaries_artifact != 'in-container' && (inputs.install_igc_driver == 'true' || inputs.install_dev_igc_driver == 'true')
255242
env:
256243
GITHUB_TOKEN: ${{ github.token }}
257244
run: |
@@ -345,8 +332,8 @@ jobs:
345332
timeout-minutes: 60
346333
with:
347334
ref: ${{ inputs.tests_ref || inputs.repo_ref || github.sha }}
348-
binaries_artifact: ${{ inputs.e2e_binaries_artifact }}
349-
testing_mode: ${{ inputs.e2e_testing_mode }}
335+
binaries_artifact: ${{ inputs.binaries_artifact }}
336+
testing_mode: ${{ inputs.testing_mode }}
350337
extra_cmake_args: ${{ inputs.extra_cmake_args }}
351338
target_devices: ${{ inputs.target_devices }}
352339
extra_lit_opts: ${{ inputs.extra_lit_opts }}
@@ -361,8 +348,8 @@ jobs:
361348
with:
362349
ref: ${{ inputs.tests_ref || 'main' }}
363350
extra_cmake_args: ${{ inputs.extra_cmake_args }}
364-
cts_testing_mode: ${{ inputs.cts_testing_mode }}
365-
sycl_cts_artifact: ${{ inputs.sycl_cts_artifact }}
351+
testing_mode: ${{ inputs.testing_mode }}
352+
binaries_artifact: ${{ inputs.binaries_artifact }}
366353
target_devices: ${{ inputs.target_devices }}
367354
retention-days: ${{ inputs.retention-days }}
368355

.github/workflows/sycl-nightly.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -271,14 +271,14 @@ jobs:
271271
with:
272272
name: Build SYCL-CTS for Linux
273273
runner: '["Linux", "build"]'
274-
cts_testing_mode: 'build-only'
274+
testing_mode: 'build-only'
275275
image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN
276276
tests_selector: cts
277277
repo_ref: ${{ github.sha }}
278278
toolchain_artifact: ${{ needs.ubuntu2204_build.outputs.toolchain_artifact }}
279279
toolchain_artifact_filename: ${{ needs.ubuntu2204_build.outputs.toolchain_artifact_filename }}
280280
toolchain_decompress_command: ${{ needs.ubuntu2204_build.outputs.toolchain_decompress_command }}
281-
sycl_cts_artifact: sycl_cts_bin_linux
281+
binaries_artifact: sycl_cts_bin_linux
282282

283283
run-sycl-cts-linux:
284284
needs: [ubuntu2204_build, build-sycl-cts-linux]
@@ -303,15 +303,15 @@ jobs:
303303
with:
304304
name: ${{ matrix.name }}
305305
runner: ${{ matrix.runner }}
306-
cts_testing_mode: 'run-only'
306+
testing_mode: 'run-only'
307307
image_options: ${{ matrix.image_options }}
308308
target_devices: ${{ matrix.target_devices }}
309309
tests_selector: cts
310310
repo_ref: ${{ github.sha }}
311311
toolchain_artifact: ${{ needs.ubuntu2204_build.outputs.toolchain_artifact }}
312312
toolchain_artifact_filename: ${{ needs.ubuntu2204_build.outputs.toolchain_artifact_filename }}
313313
toolchain_decompress_command: ${{ needs.ubuntu2204_build.outputs.toolchain_decompress_command }}
314-
sycl_cts_artifact: sycl_cts_bin_linux
314+
binaries_artifact: sycl_cts_bin_linux
315315

316316
build-sycl-cts-win:
317317
needs: build-win
@@ -320,11 +320,11 @@ jobs:
320320
with:
321321
name: Build SYCL-CTS for Windows
322322
runner: '["Windows", "build"]'
323-
cts_testing_mode: 'build-only'
323+
testing_mode: 'build-only'
324324
tests_selector: cts
325325
repo_ref: ${{ github.sha }}
326326
toolchain_artifact_filename: ${{ needs.build-win.outputs.toolchain_artifact_filename }}
327-
sycl_cts_artifact: sycl_cts_bin_win
327+
binaries_artifact: sycl_cts_bin_win
328328

329329
run-sycl-cts-win:
330330
needs: [build-win, build-sycl-cts-win]
@@ -340,12 +340,12 @@ jobs:
340340
with:
341341
name: ${{ matrix.name }}
342342
runner: ${{ matrix.runner }}
343-
cts_testing_mode: 'run-only'
343+
testing_mode: 'run-only'
344344
target_devices: ${{ matrix.target_devices }}
345345
tests_selector: cts
346346
repo_ref: ${{ github.sha }}
347347
toolchain_artifact_filename: ${{ needs.build-win.outputs.toolchain_artifact_filename }}
348-
sycl_cts_artifact: sycl_cts_bin_win
348+
binaries_artifact: sycl_cts_bin_win
349349

350350
# Verification example:
351351
# cosign-windows-amd64.exe verify-blob sycl_linux.tar.gz \

.github/workflows/sycl-post-commit.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ jobs:
8181
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
8282
target_devices: level_zero:gpu;opencl:gpu;opencl:cpu
8383
extra_lit_opts: --param spirv-backend=True
84-
e2e_binaries_artifact: e2e_bin_spirv_backend
85-
e2e_testing_mode: 'run-only'
84+
binaries_artifact: e2e_bin_spirv_backend
85+
testing_mode: 'run-only'
8686
uses: ./.github/workflows/sycl-linux-run-tests.yml
8787
with:
8888
name: ${{ matrix.name }}
@@ -99,8 +99,8 @@ jobs:
9999
toolchain_artifact_filename: ${{ needs.build-lin.outputs.toolchain_artifact_filename }}
100100
toolchain_decompress_command: ${{ needs.build-lin.outputs.toolchain_decompress_command }}
101101

102-
e2e_binaries_artifact: ${{ matrix.e2e_binaries_artifact }}
103-
e2e_testing_mode: ${{ matrix.e2e_testing_mode || 'full' }}
102+
binaries_artifact: ${{ matrix.binaries_artifact }}
103+
testing_mode: ${{ matrix.testing_mode || 'full' }}
104104

105105
# Do not install drivers on AMD and CUDA runners.
106106
install_igc_driver: >-

.github/workflows/sycl-weekly.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,15 @@ jobs:
3030
with:
3131
name: Build SYCL-CTS
3232
runner: '["Linux", "build"]'
33-
cts_testing_mode: 'build-only'
33+
testing_mode: 'build-only'
3434
image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN
3535
tests_selector: cts
3636
repo_ref: ${{ github.sha }}
3737
toolchain_artifact: ${{ needs.ubuntu2204_build.outputs.toolchain_artifact }}
3838
toolchain_artifact_filename: ${{ needs.ubuntu2204_build.outputs.toolchain_artifact_filename }}
3939
toolchain_decompress_command: ${{ needs.ubuntu2204_build.outputs.toolchain_decompress_command }}
4040
extra_cmake_args: -DDPCPP_FLAGS=-fsycl-use-spirv-backend-for-spirv-gen
41-
sycl_cts_artifact: sycl_cts_bin
41+
binaries_artifact: sycl_cts_bin
4242

4343
run-sycl-cts:
4444
needs: [ubuntu2204_build, build-sycl-cts]
@@ -63,12 +63,12 @@ jobs:
6363
with:
6464
name: ${{ matrix.name }}
6565
runner: ${{ matrix.runner }}
66-
cts_testing_mode: 'run-only'
66+
testing_mode: 'run-only'
6767
image_options: ${{ matrix.image_options }}
6868
target_devices: ${{ matrix.target_devices }}
6969
tests_selector: cts
7070
repo_ref: ${{ github.sha }}
7171
toolchain_artifact: ${{ needs.ubuntu2204_build.outputs.toolchain_artifact }}
7272
toolchain_artifact_filename: ${{ needs.ubuntu2204_build.outputs.toolchain_artifact_filename }}
7373
toolchain_decompress_command: ${{ needs.ubuntu2204_build.outputs.toolchain_decompress_command }}
74-
sycl_cts_artifact: sycl_cts_bin
74+
binaries_artifact: sycl_cts_bin

.github/workflows/sycl-windows-precommit.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,5 +79,5 @@ jobs:
7979
runner: ${{ matrix.runner }}
8080
target_devices: "level_zero:gpu"
8181
toolchain_artifact_filename: ${{ needs.build.outputs.toolchain_artifact_filename }}
82-
e2e_testing_mode: run-only
83-
e2e_binaries_artifact: sycl_windows_e2ebin
82+
testing_mode: run-only
83+
binaries_artifact: sycl_windows_e2ebin

.github/workflows/sycl-windows-run-tests.yml

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -58,27 +58,20 @@ on:
5858
required: false
5959
default: "cl"
6060

61-
e2e_testing_mode:
62-
type: string
63-
default: "full"
64-
65-
e2e_binaries_artifact:
66-
type: string
67-
default: ''
68-
required: False
69-
70-
cts_testing_mode:
61+
testing_mode:
7162
description: |
72-
Testing mode to run SYCL-CTS in, can be either `full`, `build-only`
73-
or `run-only`. In `build-only` mode an artifact of the CTS binaries
63+
Testing mode to run E2E/SYCL-CTS in, can be either `full`, `build-only`
64+
or `run-only`. In `build-only` mode an artifact of the tests binaries
7465
will be uploaded.
7566
type: string
7667
default: 'full'
7768

78-
sycl_cts_artifact:
69+
70+
binaries_artifact:
7971
type: string
8072
default: ''
8173
required: False
74+
8275
artifact_retention_days:
8376
description: 'E2E/SYCL-CTS binaries artifact retention period.'
8477
type: string
@@ -153,8 +146,8 @@ jobs:
153146
timeout-minutes: 60
154147
with:
155148
ref: ${{ inputs.tests_ref || inputs.repo_ref || github.sha }}
156-
binaries_artifact: ${{ inputs.e2e_binaries_artifact }}
157-
testing_mode: ${{ inputs.e2e_testing_mode }}
149+
binaries_artifact: ${{ inputs.binaries_artifact }}
150+
testing_mode: ${{ inputs.testing_mode }}
158151
extra_cmake_args: ${{ inputs.extra_cmake_args }}
159152
target_devices: ${{ inputs.target_devices }}
160153
extra_lit_opts: ${{ inputs.extra_lit_opts }}
@@ -167,8 +160,8 @@ jobs:
167160
with:
168161
ref: ${{ inputs.tests_ref || 'main' }}
169162
extra_cmake_args: ${{ inputs.extra_cmake_args }}
170-
cts_testing_mode: ${{ inputs.cts_testing_mode }}
171-
sycl_cts_artifact: ${{ inputs.sycl_cts_artifact }}
163+
testing_mode: ${{ inputs.testing_mode }}
164+
binaries_artifact: ${{ inputs.binaries_artifact }}
172165
target_devices: ${{ inputs.target_devices }}
173166
retention-days: ${{ inputs.artifact_retention_days }}
174167

0 commit comments

Comments
 (0)