Improve DB detection in spec

Author: n-rodriguez

spec/ajax-datatables-rails/datatable/simple_order_spec.rb

@@ -21,7 +21,7 @@
       after  { parent.nulls_last = false }
 
       it 'sql query' do
-        skip('unsupported database adapter') if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+        skip('unsupported database adapter') if RunningSpec.oracle?
 
         expect(simple_order.query('email')).to eq(
           "email DESC #{nulls_last_sql(parent)}"

spec/ajax-datatables-rails/orm/active_record_filter_records_spec.rb

@@ -168,7 +168,7 @@
         expect(result).to be_a(Arel::Nodes::And)
       end
 
-      if ENV['DB_ADAPTER'] == 'postgresql'
+      if RunningSpec.postgresql?
         context 'when db_adapter is postgresql' do
           it 'can call #to_sql on returned object' do
             result = datatable.build_conditions_for_selected_columns
@@ -180,7 +180,7 @@
         end
       end
 
-      if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+      if RunningSpec.oracle?
         context 'when db_adapter is oracle' do
           it 'can call #to_sql on returned object' do
             result = datatable.build_conditions_for_selected_columns
@@ -192,7 +192,7 @@
         end
       end
 
-      if ENV['DB_ADAPTER'] == 'mysql2'
+      if RunningSpec.mysql?
         context 'when db_adapter is mysql2' do
           it 'can call #to_sql on returned object' do
             result = datatable.build_conditions_for_selected_columns
@@ -471,7 +471,7 @@
           create(:user, last_name: 'MARY')
         end
 
-        if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+        if RunningSpec.oracle?
           context 'when db_adapter is oracleenhanced' do
             it 'filters records matching' do
               datatable.params[:columns]['3'][:search][:value] = 'RY'

spec/ajax-datatables-rails/orm/active_record_paginate_records_spec.rb

@@ -18,7 +18,7 @@
     end
 
     it 'paginates records properly' do
-      if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+      if RunningSpec.oracle?
         if Rails.version.in? %w[4.2.11]
           expect(datatable.paginate_records(records).to_sql).to include(
             'rownum <= 10'
@@ -36,7 +36,7 @@
 
       datatable.params[:start] = '26'
       datatable.params[:length] = '25'
-      if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+      if RunningSpec.oracle?
         if Rails.version.in? %w[4.2.11]
           expect(datatable.paginate_records(records).to_sql).to include(
             'rownum <= 51'

spec/ajax-datatables-rails/orm/active_record_sort_records_spec.rb

@@ -51,7 +51,7 @@
     after  { datatable.nulls_last = false }
 
     it 'can handle multiple sorting columns' do
-      skip('unsupported database adapter') if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+      skip('unsupported database adapter') if RunningSpec.oracle?
 
       # set to order by Users username in ascending order, and
       # by Users email in descending order
@@ -65,7 +65,7 @@
 
   describe '#sort_records with nulls last using column config' do
     it 'can handle multiple sorting columns' do
-      skip('unsupported database adapter') if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+      skip('unsupported database adapter') if RunningSpec.oracle?
 
       # set to order by Users username in ascending order, and
       # by Users email in descending order

spec/spec_helper.rb

@@ -61,8 +61,27 @@
   end
 end
 
+class RunningSpec
+  def self.sqlite?
+    ENV['DB_ADAPTER'] == 'sqlite3'
+  end
+
+  def self.oracle?
+    ENV['DB_ADAPTER'] == 'oracle_enhanced'
+  end
+
+  def self.mysql?
+    ENV['DB_ADAPTER'] == 'mysql2'
+  end
+
+  def self.postgresql?
+    ENV['DB_ADAPTER'] == 'postgresql'
+  end
+end
+
 # Configure ActiveRecord
 adapter = ENV.fetch('DB_ADAPTER', 'postgresql')
+ENV['DB_ADAPTER'] = adapter
 
 options = {
   adapter:  adapter,