chore(ContextGraph): remove publicly accessible member

exposes unnecessary implementation details

Author: jaredcnance

src/JsonApiDotNetCore/Builders/ContextGraphBuilder.cs

@@ -1,11 +1,11 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Reflection;
-using Microsoft.EntityFrameworkCore;
+using JsonApiDotNetCore.Extensions;
 using JsonApiDotNetCore.Internal;
 using JsonApiDotNetCore.Models;
-using JsonApiDotNetCore.Extensions;
-using System.Linq;
+using Microsoft.EntityFrameworkCore;
 
 namespace JsonApiDotNetCore.Builders
 {
@@ -20,11 +20,8 @@ public IContextGraph Build()
             // this must be done at build so that call order doesn't matter
             _entities.ForEach(e => e.Links = GetLinkFlags(e.EntityType));
 
-            var graph = new ContextGraph()
-            {
-                Entities = _entities,
-                UsesDbContext = _usesDbContext
-            };
+            var graph = new ContextGraph(_entities, _usesDbContext);
+
             return graph;
         }
 

src/JsonApiDotNetCore/Internal/ContextGraph.cs

@@ -1,20 +1,28 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Reflection;
 
 namespace JsonApiDotNetCore.Internal
 {
     public class ContextGraph : IContextGraph
     {
-        public List<ContextEntity> Entities { get; set; }
-        public bool UsesDbContext { get; set; }
+        private List<ContextEntity> _entities;
+
+        public ContextGraph() { }
+        
+        public ContextGraph(List<ContextEntity> entities, bool usesDbContext) 
+        {
+            _entities = entities;
+            UsesDbContext = usesDbContext;
+        }
+
+        public bool UsesDbContext { get; }
 
         public ContextEntity GetContextEntity(string entityName)
-            => Entities.SingleOrDefault(e => string.Equals(e.EntityName, entityName, StringComparison.OrdinalIgnoreCase));
+            => _entities.SingleOrDefault(e => string.Equals(e.EntityName, entityName, StringComparison.OrdinalIgnoreCase));
 
         public ContextEntity GetContextEntity(Type entityType)
-            => Entities.SingleOrDefault(e => e.EntityType == entityType);
+            => _entities.SingleOrDefault(e => e.EntityType == entityType);
 
         public object GetRelationship<TParent>(TParent entity, string relationshipName)
         {
@@ -33,7 +41,7 @@ public object GetRelationship<TParent>(TParent entity, string relationshipName)
         public string GetRelationshipName<TParent>(string relationshipName)
         {
             var entityType = typeof(TParent);
-            return Entities
+            return _entities
                 .SingleOrDefault(e => e.EntityType == entityType) 
                 ?.Relationships
                 .SingleOrDefault(r => string.Equals(r.PublicRelationshipName, relationshipName, StringComparison.OrdinalIgnoreCase)) 

src/JsonApiDotNetCore/Internal/IContextGraph.cs

@@ -8,6 +8,6 @@ public interface IContextGraph
         string GetRelationshipName<TParent>(string relationshipName);
         ContextEntity GetContextEntity(string dbSetName);
         ContextEntity GetContextEntity(Type entityType);
-        bool UsesDbContext { get; set; }
+        bool UsesDbContext { get; }
     }
 }