Merge pull request #48 from medokin/master

Use 204 on empty delete response

Author: jaredcnance

src/JsonApiDotNetCore/Controllers/JsonApiController.cs

@@ -201,7 +201,7 @@ public virtual async Task<IActionResult> DeleteAsync(TId id)
             if (!wasDeleted)
                 return NotFound();
 
-            return Ok();
+            return NoContent();
         }
 
         private IQueryable<T> ApplySortAndFilterQuery(IQueryable<T> entities)

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/DeletingDataTests.cs

@@ -1,20 +1,15 @@
-using System.Collections.Generic;
 using System.Linq;
 using System.Net;
 using System.Net.Http;
-using System.Net.Http.Headers;
 using System.Threading.Tasks;
 using Bogus;
 using DotNetCoreDocs;
 using DotNetCoreDocs.Writers;
-using JsonApiDotNetCore.Serialization;
-using JsonApiDotNetCore.Services;
 using JsonApiDotNetCoreExample;
 using JsonApiDotNetCoreExample.Data;
 using JsonApiDotNetCoreExample.Models;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.TestHost;
-using Newtonsoft.Json;
 using Xunit;
 
 namespace JsonApiDotNetCoreExampleTests.Acceptance.Spec

test/JsonApiDotNetCoreExampleTests/Acceptance/TodoItemsControllerTests.cs

@@ -424,7 +424,7 @@ public async Task Can_Delete_TodoItem()
             var response = await _fixture.MakeRequest<TodoItem>(description, request);
 
             // Assert
-            Assert.Equal(HttpStatusCode.OK, response.StatusCode);
+            Assert.Equal(HttpStatusCode.NoContent, response.StatusCode);
             Assert.Null(_context.TodoItems.FirstOrDefault(t => t.Id == todoItem.Id));
         }
     }