[Fix] jsx-key: detect missing keys in logical expressions

Author: yalperg

lib/rules/jsx-key.js

@@ -147,7 +147,11 @@ module.exports = {
           getReturnStatements(node.body)
             .filter((returnStatement) => returnStatement && returnStatement.argument)
             .forEach((returnStatement) => {
+              const argument = returnStatement.argument;
               checkIteratorElement(returnStatement.argument);
+              if (argument.type === 'LogicalExpression' && isJSX(argument.right)) {
+                checkIteratorElement(argument.right);
+              }
             });
         }
       }

tests/lib/rules/jsx-key.js

@@ -205,6 +205,9 @@ ruleTester.run('jsx-key', rule, {
       `,
       settings,
     },
+    { code: '[1, 2, 3].map(x => { return x && <App key={x} />; });' },
+    { code: '[1, 2, 3].map(x => { return x && y && <App key={x} />; });' },
+    { code: '[1, 2, 3].map(x => { return x && foo(); });' },
   ]),
   invalid: parsers.all([
     {
@@ -424,5 +427,13 @@ ruleTester.run('jsx-key', rule, {
       options: [{ checkKeyMustBeforeSpread: true }],
       errors: [{ messageId: 'keyBeforeSpread' }],
     },
+    {
+      code: '[1, 2, 3].map(x => { return x && <App />; });',
+      errors: [{ messageId: 'missingIterKey' }],
+    },
+    {
+      code: '[1, 2, 3].map(x => { return x || y || <App />; });',
+      errors: [{ messageId: 'missingIterKey' }],
+    },
   ]),
 });